Re: Another low-hanging fruit

[Ihor Radchenko <yantar92@posteo.net>]

Pedro Andres Aranda Gutierrez <paaguti@gmail.com> writes:

> Subject: [PATCH] Silent anonymous footnote creation

This is a bit confusing. Maybe something like

org-footnote-new: Add an option to create new anonymous labels

> * lisp/org-footnote.el: Add symbol anonymous to `org-footnote-auto-label'.
> With this, anonymous footnotes will be created. This is sometimes more
> useful in long texts. Mimics \footnote{} in LaTeX.

This is a reasonable addition.

Although, please fix the changelog entry to mention that
`org-footnote-new' is altered.

> --- a/lisp/org-footnote.el
> +++ b/lisp/org-footnote.el
> @@ -137,6 +137,7 @@ Possible values are:
>
>  nil        Prompt the user for each label.
>  t          Create unique labels of the form [fn:1], [fn:2], etc.
> +anonymous  Create anonymous labels

This wording is confusing. No labels are actually created. Just
anonymous footnote. Please reword.

Also, this is a new feature and should thus be announced in
etc/ORG-NEWS.

Further, please consider adding a new #+STARTUP option to
`org-startup-options'. We already have some facilities to set
`org-footnote-auto-label' there: fnauto, fnprompt, etc.
If you do, you will also need to update the manual section "Summary of
In-Buffer Settings".

Finally, please add a test for the new option to `test-org-footnote/new'
in testing/lisp/test-org-footnote.el

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>