From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id wHiLMb3Wv2WwJwAA62LTzQ:P1 (envelope-from ) for ; Sun, 04 Feb 2024 19:26:05 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id wHiLMb3Wv2WwJwAA62LTzQ (envelope-from ) for ; Sun, 04 Feb 2024 19:26:05 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=Sn+W4ChQ; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1707071165; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=utSoDrwOLD//uysiaXY13vpJ2i5QbfN5b6NOl5mKu6c=; b=D/XDbctziM/LfSv66oXrgPK2mbwVWejzChG8X8HvvMRslJmn5l77FZXILMJoDt9PARI/Bu WeaQHfWR7M8NZdFnGuvK+/sNM/pF5mTUHBFNfZ3H0X4mIM9IVxTHk6Yb0Cp41pqNSrSjlJ L+EtBnkv63D3w+MWkHrNAMAfXGdG90dn2lWDmC7s5YWogwrtJajCkzldyWCxO7CQugLeS3 GgCnGXWOxqoulVxAMUdyDxOaYUAqPzYT7Qjz1oitsMSrbpiw14EMWsHaHQ8TdBD/rCGGGD Oe4A/3bFxzSwUEZ8s0pdOUQPD0XORxq+3m3zgF6i9f61vinKNChao43ZD+BRxg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=Sn+W4ChQ; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1707071165; a=rsa-sha256; cv=none; b=gRiLM1woib+30CeFc54UyjpxgWLv2ocuqmKRb0h8x/5w/jYjJqOnPxnpSPwKPZYlvP5kz5 DfYbVL8tNexIKFLu6/emmpQSLST10KrKMJQ6V52Bn7iGBNcq6c5iAHP6x4E5Z/SO32ST5g 1MOcEhuKgwsqGd0JTJqr4LypeHpHf46K/FxMU/yd4q8gdiCiT3deK3oDBtwXfJoWMk7RPO eQtX+/bpOrxL6ApTRPKKJ3hBu45tNfy/0kq3LvFxUD6tfsvLUrsy2YhxwaHBpeI6e7ejKF sc9d3gf5wcBqY39m6nIZK3YT+anLAk5JSoN43mUwI41B6jQ5ZMjv7rqwlzpGWQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1578650291 for ; Sun, 4 Feb 2024 19:26:05 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rWhBf-0003p9-4K; Sun, 04 Feb 2024 13:25:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rWhBY-0003ou-Ck for emacs-orgmode@gnu.org; Sun, 04 Feb 2024 13:25:44 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rWhBW-0000kf-Lx for emacs-orgmode@gnu.org; Sun, 04 Feb 2024 13:25:44 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 50F56240104 for ; Sun, 4 Feb 2024 19:25:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1707071140; bh=y0sA6rLGbLih54WdWBpZHemGVCS1gcmGslSsEDYjxKQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: Content-Transfer-Encoding:From; b=Sn+W4ChQINXc2B1+JNlWvDY3/ZsAKLM0sUxwC0kNNKaejIk3WJbQuURqOoEAC48dh T6+WFzwq8zC/l9Z6P6nQ1QzPQNUsP8Kork9A8UyalgpdE8svow/+lpQZJIOe59a22l 35OM5382sUJkkltrZ2ndJhnxuvrm/YuV0695/9eHbo8zRXQvuZnWHMN2tKF7ySPkjI FTCea9FZA3kU1hcLvXSL7FcDbRFC1dxXcyja9/PrHFaEbJ5q4pIKOivH3PrlmTTEED 5g/0bE839//EKF6wfIxhf1TMN7pStOLAOKbhCHhImWpKdG0AfSF4wmCDCbVt3ao+Lz mhgBX8spAE9Nw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4TSdH75CQLz6tsg; Sun, 4 Feb 2024 19:25:39 +0100 (CET) From: Ihor Radchenko To: =?utf-8?Q?S=C5=82awomir?= Grochowski Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] lisp/org-colview.el: [refactor] [extract function] `org-columns-move-up' & `org-columns-move-down' In-Reply-To: <8734u82ipf.fsf@gmail.com> References: <8734u82ipf.fsf@gmail.com> Date: Sun, 04 Feb 2024 18:29:11 +0000 Message-ID: <87mssg13t4.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -7.75 X-Migadu-Scanner: mx13.migadu.com X-Spam-Score: -7.75 X-Migadu-Queue-Id: 1578650291 X-TUID: xpYW3PZo30t1 S=C5=82awomir Grochowski writes: > It's a small refactoring - extract function - and the patch is > self-explanatory. Thanks! > +(defun org-columns-move-up () > + (interactive) > ... > +(defun org-columns-move-down () > + (interactive) > ... May you also add docstrings? And maybe better names would be org-columns-next/previous-line. --=20 Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at