From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id yCctHzCR5mbsuQAAqHPOHw:P1 (envelope-from ) for ; Sun, 15 Sep 2024 07:48:00 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id yCctHzCR5mbsuQAAqHPOHw (envelope-from ) for ; Sun, 15 Sep 2024 09:48:00 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=gtbr4vsh; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1726386480; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=SBeDQi3vwyCXpFtzbwv6MtlHYzTmv2R6CXhUb3TIOEM=; b=A+LzD4zZ4kFdoM8vkjoEEeyRSmtdMLwE90o5JiWPDT2NIA8ZtTESpFv6V5WrillqSCHtxE MtRz3ZOmKznGYP2kXkOt6txnYD9qZtZdC1Jss3J97QrZmkez2j/2VaIHrq9KkZWOs+C1aM /6iu3WY6KOOI0f2vvlQlan0UzRAjjqiAVQvrxdMXdT629Ebpofbygim9ID9fEFYioI2vPw z8JAkjJsmEi1S8fbe0+2v6AVhCo2pQ1P92ESB22bF7oeNxIx2tYiUgZo7Bgqo/Y8vtvQkt LRC7sLDsQOpoWjZGCBx2SexUzFcl73BYN4Yr6/wruqT3qTyzoKaagVHl2kklLQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1726386480; a=rsa-sha256; cv=none; b=BVZIDowgCulJFPlPN9RmhmldbV1fthPoO/19jKzUHXUbmiaKoYXhkHpMyUBSSR3rOTXMRa lQDoPQZpcsu5vpbynKQCbgaAMNPXBBKREP9TvEPXjDYX8G8GtPiqrFRrKyzZU5QbYT3OQr W1qSdWTwh62PfOxDs3WydTThoTcLByo8NibzLxvuhV0jydk+e2irLMeVChBJfKI8CvgW1w QUZ88rfsJ+3AqclTyqcxJEZvoIP7/cE3GausMc3oCWd69pkFMfW0GTBzUrSD4vFRdqCBv8 3fWnHfV3m3w3Ro1EePVuPY/o3+V3eAeH3mg1gS9Fjo1/eHO4czfgHEKTvsFzsA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=gtbr4vsh; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 954511687B for ; Sun, 15 Sep 2024 09:47:59 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1spjyF-00007y-Tb; Sun, 15 Sep 2024 03:46:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1spjyE-00007m-7r for emacs-orgmode@gnu.org; Sun, 15 Sep 2024 03:46:58 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1spjyB-0005rS-10 for emacs-orgmode@gnu.org; Sun, 15 Sep 2024 03:46:57 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id B662D240027 for ; Sun, 15 Sep 2024 09:46:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1726386412; bh=ifvh7NGDf7WE7cAIVLhtiR0dg5QbzuEsLZ09DOhbkfo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=gtbr4vsh9UR+V3VqMufRJTXMMLfn7j5vvS3zOscnSn9BwW65MmzIeGVBpVywNiuDO VrkIkBZXbdyaaKhFVSI3xxa9FH6RnlQUvGb6GE/NFkFBaPxDJCcm8ZkPuG3GrWufCv FW+uTzaZgd6hcM7+nvvY1R/j8KCXSGt8/C6zckpKvUa+z9b3tT0h0Fu1L3AmhJvXPD HtlchyOLlvycVabiVJMtuubLGzZiAJTGS8QhOQ+4NBluwpKgb7F83g2lB/20SP+xU5 A3g9TlLeCVQTgYy/BHUg7fmmsCVa/O1izx/6+rNlbA6ykRCILw7q4Co9B8+xw2tMpi S6r0T48uYcrDQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4X60Vg6CLrz6tm8; Sun, 15 Sep 2024 09:46:51 +0200 (CEST) From: Ihor Radchenko To: Karthik Chikmagalur Cc: emacs-orgmode@gnu.org Subject: Re: [BUG] Image width specifications like :width 300px not working In-Reply-To: <87h6ai6frp.fsf@gmail.com> References: <87h6ai6frp.fsf@gmail.com> Date: Sun, 15 Sep 2024 07:48:22 +0000 Message-ID: <87msk973y1.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -9.73 X-Migadu-Queue-Id: 954511687B X-Spam-Score: -9.73 X-TUID: Pgp2R1cxGemL Karthik Chikmagalur writes: > Due to the change in 50be048ad0cbe0e9150ca2351b894b041ae7cf49, image > display specifications like > > #+attr_org: 300px > > don't work. From the commit message, it looks like the intent was to > ignore specifications like :width 4in. I'm not sure if ignoring "px" > specifications was intentional. > > If this is not a bug and width should be specified as an integer > (i.e. 300 instead of 300px), then the manual needs to be updated. > In (info "(org) Images") I still see examples like > > #+ATTR_HTML: :width 300px I agree that it is a regression from the existing behavior. (just as trating 4in and pixels was a regression from earlier behavior) Probably, we can extend the regexp to treat things like px/pt as pixel width as well. I suggest doing it in a separate patch rather than making many changes together with introducing a new feature as you suggested. Having too many things in a single commit can lead to confusion. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at