From: Ihor Radchenko <yantar92@posteo.net>
To: Karthik Chikmagalur <karthikchikmagalur@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG] Image width specifications like :width 300px not working
Date: Sun, 15 Sep 2024 07:48:22 +0000 [thread overview]
Message-ID: <87msk973y1.fsf@localhost> (raw)
In-Reply-To: <87h6ai6frp.fsf@gmail.com>
Karthik Chikmagalur <karthikchikmagalur@gmail.com> writes:
> Due to the change in 50be048ad0cbe0e9150ca2351b894b041ae7cf49, image
> display specifications like
>
> #+attr_org: 300px
>
> don't work. From the commit message, it looks like the intent was to
> ignore specifications like :width 4in. I'm not sure if ignoring "px"
> specifications was intentional.
>
> If this is not a bug and width should be specified as an integer
> (i.e. 300 instead of 300px), then the manual needs to be updated.
> In (info "(org) Images") I still see examples like
>
> #+ATTR_HTML: :width 300px
I agree that it is a regression from the existing behavior.
(just as trating 4in and pixels was a regression from earlier behavior)
Probably, we can extend the regexp to treat things like px/pt as pixel
width as well.
I suggest doing it in a separate patch rather than making many changes
together with introducing a new feature as you suggested. Having too
many things in a single commit can lead to confusion.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2024-09-15 7:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-14 4:06 [BUG] Image width specifications like :width 300px not working Karthik Chikmagalur
2024-09-14 4:18 ` Karthik Chikmagalur
2024-09-15 7:48 ` Ihor Radchenko [this message]
2024-09-15 21:59 ` Karthik Chikmagalur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87msk973y1.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=karthikchikmagalur@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).