ob-haskell support for haskell-ts-mode?

ob-haskell support for haskell-ts-mode?

[Pranshu Sharma via General discussions about Org-mode.]

Can we also remove the requirment of haskell-mode to run code?

-- 
Pranshu Sharma <https://p.bauherren.ovh>

Re: ob-haskell support for haskell-ts-mode?

[Ihor Radchenko]

Pranshu Sharma via "General discussions about Org-mode."
<emacs-orgmode@gnu.org> writes:

> Can we also remove the requirment of haskell-mode to run code?

AFAIU, it is not strictly required, unless you need session support.
If you do not use sessions, things should work without haskell-mode.

-- 
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: ob-haskell support for haskell-ts-mode?

[Pranshu via General discussions about Org-mode.]

On 19 January 2025 1:52:28 pm GMT+05:30, Ihor Radchenko <yantar92@posteo.net> wrote:
>Pranshu Sharma via "General discussions about Org-mode."
><emacs-orgmode@gnu.org> writes:
>
>> Can we also remove the requirment of haskell-mode to run code?
>
>AFAIU, it is not strictly required, unless you need session support.
>If you do not use sessions, things should work without haskell-mode.

When I tried to run code normally, without session, it still required haskell mode 

Re: ob-haskell support for haskell-ts-mode?

[Ihor Radchenko]

Pranshu <pranshu@bauherren.ovh> writes:

>>AFAIU, it is not strictly required, unless you need session support.
>>If you do not use sessions, things should work without haskell-mode.
>
> When I tried to run code normally, without session, it still required haskell mode 

May you show a reproducer?

-- 
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: ob-haskell support for haskell-ts-mode?

[Pranshu via General discussions about Org-mode.]

On 19 January 2025 2:57:20 pm GMT+05:30, Ihor Radchenko <yantar92@posteo.net> wrote:
>Pranshu <pranshu@bauherren.ovh> writes:
>
>>>AFAIU, it is not strictly required, unless you need session support.
>>>If you do not use sessions, things should work without haskell-mode.
>>
>> When I tried to run code normally, without session, it still required haskell mode 
>
>May you show a reproducer?

Just uninstall haskell mode, restart emacs, execute babel haskell code block without session and see what happens.

The let block in org-babel-execute:haskell function actually defines the variable session two times,  and in the second definition it calls  
org-babel-haskell-initiate-session, which calls run-haskell, a function defined in haskell mode

Re: ob-haskell support for haskell-ts-mode?

[Ihor Radchenko]

Pranshu <pranshu@bauherren.ovh> writes:

> Just uninstall haskell mode, restart emacs, execute babel haskell code block without session and see what happens.

Ok. I see what happens. haskell-mode is not required only in a single
scenario - when :compile yes header argument is provided. Otherwise, you
have to use haskell-mode.

-- 
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: ob-haskell support for haskell-ts-mode?

[Pranshu via General discussions about Org-mode.]

On 19 January 2025 3:32:33 pm GMT+05:30, Ihor Radchenko <yantar92@posteo.net> wrote:
>Pranshu <pranshu@bauherren.ovh> writes:
>
>> Just uninstall haskell mode, restart emacs, execute babel haskell code block without session and see what happens.
>
>Ok. I see what happens. haskell-mode is not required only in a single
>scenario - when :compile yes header argument is provided. Otherwise, you
>have to use haskell-mode.
>

I think being able to customise the run-haskell function and the haskell buffer name should be enough, since they both use comit

Re: ob-haskell support for haskell-ts-mode?

[Ihor Radchenko]

Pranshu <pranshu@bauherren.ovh> writes:

> I think being able to customise the run-haskell function and the haskell buffer name should be enough, since they both use comit

No, it is not.
We use `haskell-mode', `run-haskell', `inferior-haskell-load-file',
`haskell-prompt-regexp', `inferior-haskell-buffer', and
`inferior-haskell-root-dir' variables relying on very specific behavior
of haskell-mode.

Changing things to support alternatives to haskell-mode might be doable,
but certainly not trivial. Most likely, we can only do it on
case-by-case basis.

-- 
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: ob-haskell support for haskell-ts-mode?

[Pranshu via General discussions about Org-mode.]

On 19 January 2025 3:45:05 pm GMT+05:30, Ihor Radchenko <yantar92@posteo.net> wrote:
>Pranshu <pranshu@bauherren.ovh> writes:
>
>> I think being able to customise the run-haskell function and the haskell buffer name should be enough, since they both use comit
>
>No, it is not.
>We use `haskell-mode', `run-haskell', `inferior-haskell-load-file',
>`haskell-prompt-regexp', `inferior-haskell-buffer', and
>`inferior-haskell-root-dir' variables relying on very specific behavior
>of haskell-mode.
>
>Changing things to support alternatives to haskell-mode might be doable,
>but certainly not trivial. Most likely, we can only do it on
>case-by-case basis.
>

I see, I will have a look at trying to make it work later.