From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric S Fraga <ucecesf@ucl.ac.uk>
Subject: Re: [patch] icalendar extended to define alarm triggers for timed
 events
Date: Fri, 02 Jul 2010 13:56:18 +0100
Message-ID: <87lj9um499.wl%ucecesf@ucl.ac.uk>
References: <87lj9wta1r.wl%ucecesf@ucl.ac.uk>
	<31F9B22E-8EA7-48C4-86EB-F24645E4DB2A@gmail.com>
Reply-To: Eric S Fraga <e.fraga@ucl.ac.uk>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: multipart/mixed; boundary="Multipart_Fri_Jul__2_13:56:18_2010-1"
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from [140.186.70.92] (port=57723 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OUfnH-00011U-BC
	for emacs-orgmode@gnu.org; Fri, 02 Jul 2010 08:56:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <ucecesf@ucl.ac.uk>) id 1OUfnG-000135-1b
	for emacs-orgmode@gnu.org; Fri, 02 Jul 2010 08:56:35 -0400
Received: from vscane-b.ucl.ac.uk ([144.82.108.141]:34311)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <ucecesf@ucl.ac.uk>) id 1OUfnF-00011h-Ty
	for emacs-orgmode@gnu.org; Fri, 02 Jul 2010 08:56:34 -0400
In-Reply-To: <31F9B22E-8EA7-48C4-86EB-F24645E4DB2A@gmail.com>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Carsten Dominik <carsten.dominik@gmail.com>
Cc: org-mode mailing list <emacs-orgmode@gnu.org>

--Multipart_Fri_Jul__2_13:56:18_2010-1
Content-Type: text/plain; charset=US-ASCII

On Fri, 2 Jul 2010 08:53:06 +0200, Carsten Dominik <carsten.dominik@gmail.com> wrote:
> 
> Hi Eric,
> 
> 
> On Jul 1, 2010, at 12:44 AM, Eric S Fraga wrote:
> 
> > Hello,
> >
> > attached is a rudimentary patch for org-icalendar.el to add the
> > definition of alarm triggers for timed events that are exported to
> > icalendar format.  The default is to behave as it does at the moment
> > however.
> >
> > I hope it proves passable (given my less than brilliant elisp
> > expertise...).
> 
> This looks pretty good!
> But can you please
> 
> - Make sure that the first line of the docstring of the new variable
>   fits into 75 characters (better: 72)?
>   You already have made it a stand-alone sentence, which is also
> needed.
> 
> - It would also be helpful if if can make git commit and
>   include the proper commit message including a ChangeLog-like entry
>   as the second paragraph in that message.
> 
> Great work!
> 
> - Carsten
> 

Thanks Carsten.

I have seen the few messages regarding how to submit patches so I see
now what you would like.  I'll try to do that this weekend (I'm not au
fait with git but I think the instructions are fairly clear...).

--Multipart_Fri_Jul__2_13:56:18_2010-1
Content-Type: text/plain; charset=US-ASCII

-- 
Eric S Fraga
GnuPG: 8F5C 279D 3907 E14A 5C29  570D C891 93D8 FFFC F67D

--Multipart_Fri_Jul__2_13:56:18_2010-1
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

--Multipart_Fri_Jul__2_13:56:18_2010-1--