From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric S Fraga Subject: Re: [Orgmode] Automatic screenshot insertion Date: Tue, 10 Jan 2012 16:08:52 +0000 Message-ID: <87lipfzgiz.fsf@ucl.ac.uk> References: <4CE55F66.80802@gmail.com> <87vd3hmebo.wl%dmaus@ictsoc.de> <20110329144327.GE2902@x201> <87ehveyck1.fsf@iro.umontreal.ca> <87fwfoohn6.fsf@ucl.ac.uk> <87obucaanw.fsf@iro.umontreal.ca> <87wr90c4u0.fsf@ucl.ac.uk> <87y5tf622q.fsf@iro.umontreal.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([140.186.70.92]:42556) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rkfgx-0000zn-NP for emacs-orgmode@gnu.org; Tue, 10 Jan 2012 12:41:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rkfgw-0004rB-7c for emacs-orgmode@gnu.org; Tue, 10 Jan 2012 12:40:59 -0500 Received: from vscane-c.ucl.ac.uk ([144.82.108.43]:49422) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rkfgw-0004qw-1C for emacs-orgmode@gnu.org; Tue, 10 Jan 2012 12:40:58 -0500 In-Reply-To: <87y5tf622q.fsf@iro.umontreal.ca> (=?utf-8?Q?=22Fran=C3=A7ois?= Pinard"'s message of "Tue, 10 Jan 2012 09:53:49 -0500") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: =?utf-8?Q?Fran=C3=A7ois?= Pinard Cc: emacs-orgmode@gnu.org pinard@iro.umontreal.ca (Fran=C3=A7ois Pinard) writes: > Eric S Fraga writes: > > Hi again, Eric. I'll be using your corrections on the code, thanks! You're welcome! >> I had to add a call to expand-file-name for getting a file name which >> worked on my system for some reason. > > (make-temp-name > (expand-file-name > (concat (file-name-as-directory name) > (subst-char-in-string > "." "-" > (file-name-sans-extension > (file-name-nondirectory > (buffer-file-name))))))) > ".png"))) > > Not a big deal, but I wonder if it should not rather be: > > (make-temp-name > (concat (expand-file-name > (file-name-as-directory name)) > (subst-char-in-string > "." "-" > (file-name-sans-extension > (file-name-nondirectory > (buffer-file-name)))))) > > as there is nothing to expand in the base part of the file name? Yes, this would be equivalent in this case. I guess I prefer the former but only for reasons of style! >> I also re-arranged your second (unless ...) to an (if ...): > > (if (file-writable-p name) > (progn > (message "Taking screenshot into %s" name) > (call-process "import" nil nil nil name) > (message "Taking screenshot...done")) > (error "Cannot create image file")) > > I kept it, but I might likely revert it back routinely to the earlier > state, if I later happen to revisit that code. > Just to show you how maniacal I may be, let me explain. I just do not > like "(progn ...)", and make stunts to avoid it. I would rather > write: Well, the progn is only there because of the debugging messages I needed to see what was happening... I should probably get to grips with the debugger instead :( [...] > Maniacal I am, really! No, simply differing styles! I appreciate your reasoning in each case I've elided but, in the end, the different versions or approaches you mention are all essentially equivalent (computationally)... :-) > Fran=C3=A7ois > > P.S. If you happen to grok French, you might have fun reading me (or > making fun of me reading...): > > http://icule.blogspot.com/1997/02/dieu-la-douleur-et-l.html I grok French a little (as a Canadian, albeit one from the west...) so will have a look at this when I am back online! Thanks again, eric --=20 : Eric S Fraga (GnuPG: 0xC89193D8FFFCF67D) in Emacs 24.0.90.1 : using Org-mode version 7.8.03 (release_7.8.03.69.gfadca)