From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Schulte Subject: Re: [Bug] Tests for experimental org-features should expect to fail if not activated by the user Date: Wed, 29 Feb 2012 09:18:33 -0700 Message-ID: <87linlbokm.fsf@gmx.com> References: <87ipit5onv.fsf@Rainer.invalid> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:36497) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2mFC-0003VX-Ly for emacs-orgmode@gnu.org; Wed, 29 Feb 2012 11:19:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S2mEl-00009J-W0 for emacs-orgmode@gnu.org; Wed, 29 Feb 2012 11:19:10 -0500 Received: from mailout-us.gmx.com ([74.208.5.67]:44636 helo=mailout-us.mail.com) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1S2mEl-00007Y-OG for emacs-orgmode@gnu.org; Wed, 29 Feb 2012 11:18:43 -0500 In-Reply-To: <87ipit5onv.fsf@Rainer.invalid> (Achim Gratz's message of "Sun, 26 Feb 2012 21:24:04 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Achim Gratz Cc: emacs-orgmode@gnu.org Moving forward on this point, many of the existing tests explicitly `require' new Org-mode functionality (mainly language support for testing code blocks execution). I do not think that tests should ever be activating new packages changing a users global environment. For this reason I have just pushed up a commit which changes all (require 'org-foo) to (unless (featurep 'org-foo) (signal 'missing-test-dependency "Org support for doing foo.")) so that those tests simple aren't run on the users system. Please let me know if anyone thinks this is a mistake and we can discuss. The only drawback I see is that batch-mode scripts will have to explicitly activate the features which they would like to test, by evaluating forms like (require 'org-foo) before the call to the test suite -- and I would argue that being explicit about such things is a benefit. Cheers, Achim Gratz writes: > Tests for experimental org features (e.g. from contrib/ ) should expect > to fail when the user has not configured their inclusion into the > current setup. In other words, things like "(require org-element)" > should not break the test run, but instead just note that this test has > failed expectedly and continue testing. > > > Regards, > Achim. -- Eric Schulte http://cs.unm.edu/~eschulte/