From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Schulte Subject: Re: [babel, patch] ob-octave does not catch EOE from matlabShell on MS Windows Date: Wed, 30 May 2012 10:05:40 -0600 Message-ID: <87lik9r6wb.fsf@gmx.com> References: <00f901cd39f0$7da5bb00$78f13100$@us> <00ff01cd39f4$7feec3d0$7fcc4b70$@us> <010501cd3a93$ccb65f80$66231e80$@us> <010801cd3a96$d0ac2360$72046a20$@us> <87r4u4s1jj.fsf@gmx.com> <87396kmaf8.fsf@Rainer.invalid> <019b01cd3e7d$06cf3790$146da6b0$@us> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:37757) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SZlPH-0005B4-Hi for emacs-orgmode@gnu.org; Wed, 30 May 2012 12:06:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SZlPF-0001Xu-5k for emacs-orgmode@gnu.org; Wed, 30 May 2012 12:05:55 -0400 Received: from mailout-us.gmx.com ([74.208.5.67]:59674) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1SZlPE-0001Xk-VQ for emacs-orgmode@gnu.org; Wed, 30 May 2012 12:05:53 -0400 In-Reply-To: <019b01cd3e7d$06cf3790$146da6b0$@us> (Mikhail Titov's message of "Wed, 30 May 2012 10:58:15 -0500") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Mikhail Titov Cc: 'Achim Gratz' , emacs-orgmode@gnu.org, 'Eric Schulte' "Mikhail Titov" writes: >> -----Original Message----- >> From: emacs-orgmode-bounces+mlt=gmx.us@gnu.org [mailto:emacs-orgmode- >> bounces+mlt=gmx.us@gnu.org] On Behalf Of Achim Gratz >> Sent: Monday, May 28, 2012 1:24 PM >> To: emacs-orgmode@gnu.org >> Subject: Re: [O] [babel, patch] ob-octave does not catch EOE from > matlabShell >> on MS Windows >> >> Eric Schulte writes: >> > Thanks for sending along the patch and the variable re-definition. If I >> > understand correctly then the patch should be applied for any system, >> > but the variable definition need only be applied on windows systems. Is >> > that correct? >> >> The variable re-definition seems to be be needed for matlab-shell, I >> don't know if that would be restricted to Windows. >> >> > Can anyone confirm that matlab/octave code blocks are still functional >> > on a GNU/Linux machine after the above patch and redefinition have been >> > applied? I do not use octave/matlab myself and can't verify this. >> >> The octave tests still pass on openSUSE with the patch applied along >> with all the other tests (except R, since I'm missing ESS). > > I wonder how it still passes the test... > > I think my patch unintentionally breaks octave. It probably should have been > just > > org-babel-octave-eoe-output > > instead of > > (if matlabp > org-babel-octave-eoe-output > org-babel-octave-eoe-indicator) > > or other way around. > > I apologize for bringing it all over to the list as I'm not proficient in > elisp yet. > > I feel like ob-octave needs an overhaul in general as it does not respect > many header arguments like :width, :height, and graphics format (always > png). Also it would be nice if it removed extra prompts left in results as > does ob-R.el . > > I'll post improved patch once I feel it is ready. > > Eric, so for now, just hold on with the application of what I've sent. > Will do, Thanks for following up on this. The original author of the Octave and Matlab support for Org-mode code blocks (Dan Davison) is no longer following the Org-mode mailing list, so it would be good to have a new pair of eyes on this. If you run into elisp questions I'm sure there are many experts on this list who would be happy to help provide answers. Best, > > Mikhail > > > -- Eric Schulte http://cs.unm.edu/~eschulte