From: Bernt Hansen <bernt@norang.ca>
To: Bastien <bzg@altern.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: bug#12905: 24.2.50; org: edit source block causes data loss
Date: Wed, 12 Dec 2012 22:37:40 -0500 [thread overview]
Message-ID: <87lid262rf.fsf@norang.ca> (raw)
In-Reply-To: 876246skbt.fsf@norang.ca
Bernt Hansen <bernt@norang.ca> writes:
> Bastien <bzg@altern.org> writes:
>
>> Hi Bernt,
>>
>> Bernt Hansen <bernt@norang.ca> writes:
>>
>>> I'm not sure if this is related or not - I don't have time to track down
>>> the offending commit right now.
>>
>> There is nothing new regarding editing source code in master,
>> except Eric's last few patches.
>>
>>> org-edit-special (C-c ') is currently broken in master.
>>>
>>> I get the following backtrace
>>
>> Mhh.. I can't reproduce this.
>>
>>> Org-mode version 7.9.2 (release_7.9.2-664-gb1f369 @
>>> /home/bernt/git/org-mode/lisp/)
>>
>> I'm on release_7.9.2-692-g627d57
>> ^^^
>>
>> Are you sure you are using master HEAD?
>
> I think so. I just updated and have the same behaviour
>
> Org-mode version 7.9.2 (release_7.9.2-693-g8c04fb @
> /home/bernt/git/org-mode/lisp/)
>
> I'll try and locate the problem commit.
git bisect identifies the following commit:
--8<---------------cut here---------------start------------->8---
206257aa7eb83a0a62f297e7cf0e3a7c32ff6f05 is the first bad commit
commit 206257aa7eb83a0a62f297e7cf0e3a7c32ff6f05
Author: Le Wang <le.wang@agworld.com.au>
Date: Sun Nov 18 13:39:51 2012 +0800
org-src: Fix org-edit-src-code for empty blocks and block with just an empty line
* lisp/org-src.el (org-edit-src-code): Use marker with insertion type
t to track end and remove hack requiring delete from beg to (1- end).
:040000 040000 91825ba365592800804e652e3ad66db0f8302772 25f089bf9456b306afd2a0e538bcbfefc4a124f0 M lisp
--8<---------------cut here---------------end--------------->8---
I'm just trying to edit a lisp source block
--8<---------------cut here---------------start------------->8---
* test
[2012-12-09 Sun 20:53]
#+begin_src lisp
(defun bh/show-org-agenda ()
(interactive)
(switch-to-buffer "*Org Agenda*")
(delete-other-windows))
; Use the current window for C-c ' source editing
(setq org-src-window-setup 'current-window)
#+end_src
--8<---------------cut here---------------end--------------->8---
using C-c ' inside the block.
Reverting this commit fixes it for me.
Regards,
Bernt
next prev parent reply other threads:[~2012-12-13 3:37 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <50A62865.8010904@gmail.com>
2012-12-07 15:36 ` bug#12905: 24.2.50; org: edit source block causes data loss Chong Yidong
[not found] ` <87sj7han8a.fsf__16482.9143243425$1354894646$gmane$org@gnu.org>
2012-12-12 16:55 ` Bastien
2012-12-12 21:05 ` Bernt Hansen
2012-12-12 21:34 ` Jonathan Leech-Pepin
2012-12-12 21:51 ` Bernt Hansen
2012-12-12 23:18 ` Bastien
2012-12-13 3:27 ` Bernt Hansen
2012-12-13 3:37 ` Bernt Hansen [this message]
2012-12-13 4:50 ` Nick Dokos
2012-12-13 12:45 ` Bernt Hansen
2012-12-13 13:41 ` Bernt Hansen
2012-12-13 10:36 ` Bastien
2012-12-13 13:42 ` Bernt Hansen
2012-12-13 14:36 ` Le Wang
2012-12-13 15:17 ` Bastien
2012-12-13 16:06 ` Le Wang
2012-12-13 16:25 ` Bastien
2012-12-13 23:40 ` Le Wang
2012-12-13 23:50 ` Le Wang
2012-12-14 9:38 ` Bastien
2012-12-14 9:39 ` Bastien
2012-12-16 14:39 ` Le Wang
2012-12-14 9:40 ` Bastien
2012-12-13 13:48 ` Bernt Hansen
2012-12-13 16:05 ` Bastien
2012-12-14 0:04 ` Bernt Hansen
2012-12-14 9:35 ` Bastien
2012-12-14 9:57 ` Le Wang
[not found] ` <87wqwnyzud.fsf@bzg.ath.cx>
2012-12-12 17:39 ` Andy Moreton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lid262rf.fsf@norang.ca \
--to=bernt@norang.ca \
--cc=bzg@altern.org \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).