From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kyle Meyer <kyle@kyleam.com>
Subject: Re: [PATCH] org-attach.el: Get attachments from git annex
Date: Fri, 29 Jan 2016 00:39:34 -0500
Message-ID: <87lh79t04p.fsf@kyleam.com>
References: <568b532e.d111620a.b25a8.ffffbb7c@mx.google.com>
	<87poxg8s22.fsf@kyleam.com>
	<568c6aaa.c345620a.7f4da.6359@mx.google.com>
	<56a5b193.ca77420a.1551e.667c@mx.google.com> <87lh7dz79f.fsf@gmx.us>
	<56a70513.6861420a.33633.5843@mx.google.com>
	<87egd4u6tq.fsf@kyleam.com>
	<56a7a139.885d620a.6b777.576d@mx.google.com>
	<87io2gb5xh.fsf@kyleam.com> <87oac8hu9p.fsf@gmx.us>
	<56a87251.0e2a620a.4811f.fffff1c6@mx.google.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47967)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kyle@kyleam.com>) id 1aP1md-0003l7-G2
	for emacs-orgmode@gnu.org; Fri, 29 Jan 2016 00:39:48 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kyle@kyleam.com>) id 1aP1mY-0002YK-JW
	for emacs-orgmode@gnu.org; Fri, 29 Jan 2016 00:39:47 -0500
Received: from pb-smtp0.int.icgroup.com ([208.72.237.35]:54700
	helo=sasl.smtp.pobox.com) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kyle@kyleam.com>) id 1aP1mY-0002YB-F8
	for emacs-orgmode@gnu.org; Fri, 29 Jan 2016 00:39:42 -0500
In-Reply-To: <56a87251.0e2a620a.4811f.fffff1c6@mx.google.com> (Erik Hetzner's
	message of "Sun, 24 Jan 2016 20:34:20 -0800")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Erik Hetzner <egh@e6h.org>
Cc: emacs-orgmode@gnu.org, Rasmus <rasmus@gmx.us>

Erik Hetzner <egh@e6h.org> writes:

> I believe this addresses all the issues that have been raised. Thanks for all
> your help with this.

Thanks for the updates.  I just have two minor things to add to Rasmus's
comments.

- Nitpick: It'd be nice if you could re-flow some of your lines to not
  be as wide.

- What's the advantage of using cl-defmacro instead of defmacro below?

> +(cl-defmacro test-org-attach-annex/with-annex (&body body)
> +  `(let ((tmpdir (make-temp-file "org-annex-test" t)))
> +     (unwind-protect
> +	 (let ((default-directory tmpdir)

Thanks again.

-- 
Kyle