From mboxrd@z Thu Jan  1 00:00:00 1970
From: Matt Lundin <mdl@imapmail.org>
Subject: Re: Bug in Recent Agenda Mod
Date: Tue, 21 Mar 2017 09:05:09 -0500
Message-ID: <87lgryybca.fsf@fastmail.fm>
References: <87efxrv5s5.fsf@escafil>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54549)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mdl@imapmail.org>) id 1cqKPX-0005nx-2V
	for emacs-orgmode@gnu.org; Tue, 21 Mar 2017 10:05:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mdl@imapmail.org>) id 1cqKPV-0007gD-RL
	for emacs-orgmode@gnu.org; Tue, 21 Mar 2017 10:05:19 -0400
In-Reply-To: <87efxrv5s5.fsf@escafil> (Ian Dunn's message of "Mon, 20 Mar 2017
	20:21:14 -0400")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Ian Dunn <dunni@gnu.org>
Cc: emacs-orgmode@gnu.org

Ian Dunn <dunni@gnu.org> writes:

> Commit d262ae53c966c7a745c0fa779149f9eb7486333d "org-agenda: Fix
> agenda standard name when going unsticky" sets org-agenda-buffer-name
> to "*Org Agenda*" if not in sticky.
>
> However, org-agenda-redo sets org-agenda-sticky to nil before redoing the agenda command.
>
> Steps to Reproduce:
>
> 1. Turn on org-agenda-sticky
> 2. Execute any agenda command that only involves org-agenda-list
>    - Agenda is in buffer *Org Agenda(CMD)* (ex. *Org Agenda(d:)*)
> 3. Press 'g' (org-agenda-redo)
>    - Agenda is now in *Org Agenda*
>
> The included patch fixes this for sticky redo, and will have no effect
> for anything other than a sticky redo.
>
> --
> Ian Dunn
>
> diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
> index b618653d5..04e6685b5 100644
> --- a/lisp/org-agenda.el
> +++ b/lisp/org-agenda.el
> @@ -4076,6 +4076,7 @@ items if they have an hour specification like [h]h:mm."
>    (catch 'exit
>      (setq org-agenda-buffer-name
>  	  (or org-agenda-buffer-tmp-name
> +	      (and org-agenda-doing-sticky-redo org-agenda-buffer-name)
>  	      (if org-agenda-sticky
>  		  (cond ((and org-keys (stringp org-match))
>  			 (format "*Org Agenda(%s:%s)*" org-keys org-match))

Thanks so much for solving this. I was just trying to figure out why
refreshing my sticky agendas kept creating a new "*Org Agenda* buffer
and am glad I checked here first. I can confirm that this fix works.

Matt