From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sebastian =?utf-8?Q?Reu=C3=9Fe?= <seb@wirrsal.net>
Subject: Re: [PATCH] org: Support creating arbitrary headline paths when
 refiling
Date: Wed, 10 Oct 2018 13:27:37 +0200
Message-ID: <87lg76ca8m.fsf@wirrsal.net>
References: <20181007135831.26003-1-seb@wirrsal.net>
	<87ftxecc03.fsf@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58557)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <seb@wirrsal.net>) id 1gACeW-0007Qa-MA
	for emacs-orgmode@gnu.org; Wed, 10 Oct 2018 07:27:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <seb@wirrsal.net>) id 1gACeR-0000kf-OG
	for emacs-orgmode@gnu.org; Wed, 10 Oct 2018 07:27:44 -0400
Received: from wirrsal.net ([188.68.36.149]:44216 helo=mail.wirrsal.net)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <seb@wirrsal.net>) id 1gACeQ-0000kA-SE
	for emacs-orgmode@gnu.org; Wed, 10 Oct 2018 07:27:39 -0400
In-reply-to: <87ftxecc03.fsf@nicolasgoaziou.fr>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-orgmode@gnu.org

Hello Nicolas,

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Compiling your patch generates the following warnings.
>
>     org.el:11417:1:Warning: Unused lexical variable =E2=80=98parent=E2=80=
=99
>     org.el:11417:1:Warning: Unused lexical variable =E2=80=98child=E2=80=
=99
>     org.el:11417:1:Warning: Unused lexical variable=20
>     =E2=80=98parent-target=E2=80=99

Good catch, thanks. I forgot to remove these let-bindings when=20
factoring the respective =E2=80=98org-refile=E2=80=99 branch into a separat=
e=20
function. I amended the commit correspondingly.

> Also, I couldn't test it because completing asks for a mandatory=20
> match
> among candidates. Such a match is not possible if you need to=20
> create
> a path out of the blue. Am I missing something?

Do you have =E2=80=98org-refile-allow-creating-parent-nodes=E2=80=99 set to=
 an=20
appropriate value? When non-nil, =E2=80=98org-refile=E2=80=99 should invoke=
 the=20
completing read function without requiring a full match.

Kind regards,

SR

--=20
Insane cobra split the wood
Trader of the lowland breed
Call a jittney, drive away
In the slipstream we will stay