From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: restore window configuration after org-edit-src-exit
Date: Sun, 22 Dec 2019 15:45:22 +0100
Message-ID: <87lfr45shp.fsf@nicolasgoaziou.fr>
References: <qtmfthmafqz.fsf@synopsys.com> <87lfrc9qs6.fsf@nicolasgoaziou.fr>
 <87woavd8j4.fsf@kyleam.com> <87sgljf3e1.fsf@gmail.com>
 <87mubrf2mm.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:45927)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <mail@nicolasgoaziou.fr>) id 1ij2U9-0004G8-Id
 for emacs-orgmode@gnu.org; Sun, 22 Dec 2019 09:45:34 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <mail@nicolasgoaziou.fr>) id 1ij2U4-0007Y2-5B
 for emacs-orgmode@gnu.org; Sun, 22 Dec 2019 09:45:32 -0500
Received: from relay6-d.mail.gandi.net ([217.70.183.198]:39809)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
 id 1ij2U3-0007PA-S5
 for emacs-orgmode@gnu.org; Sun, 22 Dec 2019 09:45:28 -0500
In-Reply-To: <87mubrf2mm.fsf@gmail.com> (Jack Kamm's message of "Tue, 17 Dec
 2019 06:28:01 -0800")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
 <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Jack Kamm <jackkamm@gmail.com>
Cc: emacs-orgmode@gnu.org, Richard Kim <Richard.Kim1@synopsys.com>

Hello,

Jack Kamm <jackkamm@gmail.com> writes:

> Rather than adding a new option, how about we make the behavior
> dependent on the value of org-src-window-setup?
>
> Basically, when org-src-window-setup is current-window, it never makes
> sense to restore the original layout. But when org-src-window-setup is
> reorganize-frame (the default), it always makes sense to restore the
> original layout.
>
> I'm not sure what the "correct" behavior would be for the other options
> however.

I think any value that modifies the current layout ought to restore it:
- `split-window-below'
- `split-window-right'
- `reorganize-frame'

OTOH, values that use the current layout should not restore it
afterwards:
- `current-window'
- `other-window'
- `other-frame'

This should be mentioned in the docstring.

WDYT?

Regards,

-- 
Nicolas Goaziou