From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Miele Subject: Re: [PATCH] Respect buffer-local value of `org-edit-src-content-indentation' Date: Wed, 12 Feb 2020 18:35:58 +0000 Message-ID: <87lfp7lkkx.fsf@gmail.com> References: <87eezelxbq.fsf@gmail.com> <87a75nbsol.fsf@gnu.org> Reply-To: sebastian.miele@gmail.com Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:54314) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1wrj-0005kp-HU for emacs-orgmode@gnu.org; Wed, 12 Feb 2020 13:36:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j1wri-0007UM-CH for emacs-orgmode@gnu.org; Wed, 12 Feb 2020 13:36:03 -0500 In-reply-to: <87a75nbsol.fsf@gnu.org> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org Sender: "Emacs-orgmode" To: Bastien Cc: emacs-orgmode@gnu.org Hi Bastien, Bastien writes: > > Sebastian Miele writes: > > > * lisp/org-src.el (org-src--contents-for-write-back): Use the > > potentially buffer-local value of `org-edit-src-content-indentation' > > from the source buffer instead of that from the editing buffer. > > I'm not sure about I see why this patch would be useful. > > IIUC, in case `org-edit-src-content-indentation' is set in the src > block buffer itself, you want Org to honor its value _there_ instead > of the value this variable has in the org buffer (containing the src > block)? I am quite certain, that the content indentation conceptually and technically belongs to the buffer containing the src block. Except for src blocks containing org I see no point at all for setting a content indentation in an edit buffer for the block. There just is no meaning of an org src content indentation in e.g. an Elisp buffer. And for an src buffer containing org the meaning would be the content intentation for the org in the block, and not for the org containing the block. > I find it difficult to see a compelling use case, please let me know > if I don't understand correctly. Nicolas already accepted the patch. Currently it is included as commit 3649d95b in the history of master. Before accepting the patch, he too asked for a use case. Please see https://lists.gnu.org/archive/html/emacs-orgmode/2019-11/msg00052.html for the answer. Best wishes Sebastian