From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id mLX/G+i+vV6BPgAA0tVLHw (envelope-from ) for ; Thu, 14 May 2020 21:58:00 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id uH3aF+i+vV6NcAAA1q6Kng (envelope-from ) for ; Thu, 14 May 2020 21:58:00 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E1535940275 for ; Thu, 14 May 2020 21:57:59 +0000 (UTC) Received: from localhost ([::1]:33872 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jZLra-0005zL-CR for larch@yhetil.org; Thu, 14 May 2020 17:57:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54562) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZLrE-0005zC-Tk for emacs-orgmode@gnu.org; Thu, 14 May 2020 17:57:36 -0400 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]:35275) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jZLrD-0003Fl-Aj for emacs-orgmode@gnu.org; Thu, 14 May 2020 17:57:35 -0400 Received: by mail-wr1-x433.google.com with SMTP id j5so819438wrq.2 for ; Thu, 14 May 2020 14:57:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version:content-transfer-encoding; bh=zOakuKmKeyf0m8aaLmgLyJnDxs8Y19mQRBBSTfCyL5g=; b=JQCaJWYLbiWbXha3wxpL9CAKeLhyNTl636X0om7rzwsc5ZjwxYUZfZf4kO3Q1PUf8o XEtDoS0Ey9XZv+FPXSGYNvdcDxF8zD97Ybim9tHvsfvHBlgkNgtNJdlNZ5mUxTeYAo7+ RBUFUNayd3tX3lVSL/eRyRqMlBzt9mSr/nXP8ByQ16vJUGuu2QCi/mJaP9Xaz3h55kiu NRWDYzVowitg2ehLadBL/0DuNzvmkK5bR0d6/V2n4K5A/jxOan2UEy3w0mH8d+823ZjZ e2rWEUTmnObqtrV2Wd5v+eCWwQHosp88CwbfNSAqXj+uzgJBY5NIzW/q4AJvk8RXzBBd 1EbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=zOakuKmKeyf0m8aaLmgLyJnDxs8Y19mQRBBSTfCyL5g=; b=uSrQzznIh+m8vmW7CYrmVqPy9nRnMhIOZIbqqROLn0zLjqHw5niM3PYG4cRGYmZhOT Ng4pNmrrj2jfeJo00GpWZkcglvpy80uzCx2oF51uwye4M2biiBByIG8dsj/VEeB8bH/G 0xu251NipV19RqYtxm2iRIKMwaDI5NZXQJuv6crxMdO7i54G7F7uT7fyQkuwlU7WqI/a 1zSyIzTm7Wt5gRdijn+HFoyguVXyVQS4P4xgrShNJr3rd6BgLSye9BuS7n5gmtdvkotz veVgMiWKZBhXe/2rgcIsOXYNGvSa5WId5cOLgJsvgSxdAC8M29wRdHTKI6P2fjnWtP84 rJvw== X-Gm-Message-State: AOAM532GyBzXuMeBhPYHXCqhQoFcqFaX8pVmp9mC6qZ0vqZ6LVEaYgvA oo13JHMHuzZphqSTwIvj3+iC/gwHKx5zvw== X-Google-Smtp-Source: ABdhPJz4wx+wIpRLJym2ighi6QKtnb2v0/AeNrDMTzhLZeg1lF1iGUzG1a2yG7XaBtwSQ7TqWXnqFw== X-Received: by 2002:a5d:4447:: with SMTP id x7mr529455wrr.424.1589493452456; Thu, 14 May 2020 14:57:32 -0700 (PDT) Received: from my-little-tumbleweed (200.143.13.109.rev.sfr.net. [109.13.143.200]) by smtp.gmail.com with ESMTPSA id h1sm556330wme.42.2020.05.14.14.57.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2020 14:57:31 -0700 (PDT) From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= To: emacs-orgmode@gnu.org Subject: Re: [bug] error on RET in read-only buffer with org-return-follows-link set to t References: <87wo5egv93.fsf@no.workgroup> <87eerm6wae.fsf@nicolasgoaziou.fr> Date: Thu, 14 May 2020 23:57:31 +0200 In-Reply-To: <87eerm6wae.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Thu, 14 May 2020 23:28:41 +0200") Message-ID: <87lfluuqlw.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::433; envelope-from=kevin.legouguec@gmail.com; helo=mail-wr1-x433.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=JQCaJWYL; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -0.21 X-TUID: 2TOFO8ha5kBO Nicolas Goaziou writes: > Hello, > > Gregor Zattler writes: > >> with `org-return-follows-link` set to `t` in a read-only >> buffer I now get a `Buffer is read-only: #> notmuch-startpage.org>` error when pressing ENTER/RETURN >> with point on an org-mode link. > > Fixed. Thank you. Thanks for fixing this Nicolas, and for adding a unit test. Shouldn't the call to org-return be wrapped in (call-interactively =E2=80= =A6) though? Since the problem was with the interactive spec, org-return will work (i.e. follow links) in read-only buffers if called programmatically, so the test will fail to catch a regression if I'm not mistaken. IOW: if I revert the fix, the new test still passes.