* [BUG] All drawers except property drawers are open at startup
@ 2020-05-27 21:52 Matt Lundin
2020-05-28 12:35 ` Nicolas Goaziou
0 siblings, 1 reply; 6+ messages in thread
From: Matt Lundin @ 2020-05-27 21:52 UTC (permalink / raw)
To: Org Mode List
All drawers default to open at startup except for property drawers. This
includes :LOGBOOK: drawers, which can be quite long and block view of an
entry.
I ran a git bisect and discovered that the bug was introduced with
commit 8b05c06d427e850d45684f69c5165cd7684e1071 on May 9.
Matt
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [BUG] All drawers except property drawers are open at startup
2020-05-27 21:52 [BUG] All drawers except property drawers are open at startup Matt Lundin
@ 2020-05-28 12:35 ` Nicolas Goaziou
2020-05-28 14:18 ` Matthew Lundin
0 siblings, 1 reply; 6+ messages in thread
From: Nicolas Goaziou @ 2020-05-28 12:35 UTC (permalink / raw)
To: Matt Lundin; +Cc: Org Mode List
Hello,
Matt Lundin <mdl@imapmail.org> writes:
> All drawers default to open at startup except for property drawers. This
> includes :LOGBOOK: drawers, which can be quite long and block view of an
> entry.
I think all drawers are opened at startup, including property drawers.
> I ran a git bisect and discovered that the bug was introduced with
> commit 8b05c06d427e850d45684f69c5165cd7684e1071 on May 9.
Isn't it related to 88f5ed91c5cf9cb6962c1b441eac7dbab9a4734e instead?
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [BUG] All drawers except property drawers are open at startup
2020-05-28 12:35 ` Nicolas Goaziou
@ 2020-05-28 14:18 ` Matthew Lundin
2020-06-06 2:25 ` Matt Lundin
0 siblings, 1 reply; 6+ messages in thread
From: Matthew Lundin @ 2020-05-28 14:18 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: Org Mode List
Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
> Matt Lundin <mdl@imapmail.org> writes:
>
>> All drawers default to open at startup except for property drawers. This
>> includes :LOGBOOK: drawers, which can be quite long and block view of an
>> entry.
>
> I think all drawers are opened at startup, including property drawers.
>
>> I ran a git bisect and discovered that the bug was introduced with
>> commit 8b05c06d427e850d45684f69c5165cd7684e1071 on May 9.
>
> Isn't it related to 88f5ed91c5cf9cb6962c1b441eac7dbab9a4734e instead?
>
No. I have the following in my emacs file:
(setq org-startup-folded t)
Here's a minimal recipe for reproducing:
Config file:
(add-to-list 'load-path "~/org-mode/lisp/")
(add-to-list 'load-path "~/org-mode/contrib/lisp/")
(setq org-startup-folded t)
Org file:
* Heading
:PROPERTIES:
:APROP: 1234
:END:
:LOGBOOK:
- State "DONE" from "NOW" [2020-05-27 Wed 23:03]
:END:
:RANDOM:
Some text
:END:
Navigate to file. Navigate to outline heading and hit TAB to cycle/open.
Before commit 8b05c06d427e850d45684f69c5165cd7684e1071 all drawers
remain folded (expected behavior):
* Heading
:PROPERTIES:
:LOGBOOK:
:RANDOM:
Beginning with commit 8b05c06d427e850d45684f69c5165cd7684e1071 only the
PROPERTIES drawer remains folded, so the entry looks like this
(undesired behavior):
* Heading
:PROPERTIES:
:LOGBOOK:
- State "DONE" from "NOW" [2020-05-27 Wed 23:03]
:END:
:RANDOM:
Some text
:END:
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [BUG] All drawers except property drawers are open at startup
2020-05-28 14:18 ` Matthew Lundin
@ 2020-06-06 2:25 ` Matt Lundin
2020-06-06 3:34 ` stardiviner
2020-06-09 11:52 ` Nicolas Goaziou
0 siblings, 2 replies; 6+ messages in thread
From: Matt Lundin @ 2020-06-06 2:25 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: Org Mode List
Matthew Lundin <mdl@imapmail.org> writes:
> Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
>
>> Matt Lundin <mdl@imapmail.org> writes:
>>
>>> All drawers default to open at startup except for property drawers. This
>>> includes :LOGBOOK: drawers, which can be quite long and block view of an
>>> entry.
>>
>> I think all drawers are opened at startup, including property drawers.
>>
>>> I ran a git bisect and discovered that the bug was introduced with
>>> commit 8b05c06d427e850d45684f69c5165cd7684e1071 on May 9.
>>
>> Isn't it related to 88f5ed91c5cf9cb6962c1b441eac7dbab9a4734e instead?
>>
> No. I have the following in my emacs file:
>
> (setq org-startup-folded t)
>
I did some more investigating and it seems my initial git bisect was off
by one commit. (I think I forgot to reload org files on the last
bisect.)
The commit that introduced this bug was
1027e0256903bc2c4ef9edfb1f7279294fa3f195.
In the function org-set-startup-visibility, that commit replaced
(org-cycle-hide-drawers 'all)
with
(org-cycle-hide-property-drawers 'all)
Thus, only property drawers are hidden at startup.
Best,
Matt
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [BUG] All drawers except property drawers are open at startup
2020-06-06 2:25 ` Matt Lundin
@ 2020-06-06 3:34 ` stardiviner
2020-06-09 11:52 ` Nicolas Goaziou
1 sibling, 0 replies; 6+ messages in thread
From: stardiviner @ 2020-06-06 3:34 UTC (permalink / raw)
To: Matt Lundin; +Cc: emacs-orgmode, Nicolas Goaziou
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Matt Lundin <mdl@imapmail.org> writes:
> Matthew Lundin <mdl@imapmail.org> writes:
>
>> Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
>>
>>> Matt Lundin <mdl@imapmail.org> writes:
>>>
>>>> All drawers default to open at startup except for property drawers. This
>>>> includes :LOGBOOK: drawers, which can be quite long and block view of an
>>>> entry.
>>>
>>> I think all drawers are opened at startup, including property drawers.
>>>
>>>> I ran a git bisect and discovered that the bug was introduced with
>>>> commit 8b05c06d427e850d45684f69c5165cd7684e1071 on May 9.
>>>
>>> Isn't it related to 88f5ed91c5cf9cb6962c1b441eac7dbab9a4734e instead?
>>>
>> No. I have the following in my emacs file:
>>
>> (setq org-startup-folded t)
>>
>
> I did some more investigating and it seems my initial git bisect was off
> by one commit. (I think I forgot to reload org files on the last
> bisect.)
>
> The commit that introduced this bug was
> 1027e0256903bc2c4ef9edfb1f7279294fa3f195.
>
> In the function org-set-startup-visibility, that commit replaced
>
> (org-cycle-hide-drawers 'all)
>
> with
>
> (org-cycle-hide-property-drawers 'all)
>
> Thus, only property drawers are hidden at startup.
>
I have same problem. Glad you found the problem commit.
> Best,
>
> Matt
- --
[ stardiviner ]
I try to make every word tell the meaning that I want to express.
Blog: https://stardiviner.github.io/
IRC(freenode): stardiviner, Matrix: stardiviner
GPG: F09F650D7D674819892591401B5DF1C95AE89AC3
-----BEGIN PGP SIGNATURE-----
iQFIBAEBCAAyFiEE8J9lDX1nSBmJJZFAG13xyVromsMFAl7bDsMUHG51bWJjaGls
ZEBnbWFpbC5jb20ACgkQG13xyVromsONQwgAvgeSgmZuX5lnmgUP30dzVgpVA0vS
O5cKfYD3aMwd5hkCzwUXFfc+LotKBFZJHJy1lRAesHHZclKRyNLpdQHWHwLbhbKM
jBRLnaFQhVHa12QqPplF7/cBMfv41RFYcqiGcwfY+F8ZOrHe++7dOdcmxRKdZtVb
f3WUwZDMQTfKhLLKj44kcKOcah32Utg/3WDG5ovUMiNQ8PUJryOR1eLTW1w//hI5
bLoJGFI69UW6F/MOMBmWyY9BEZyONYGpIWvTqLt/189F0+6VedDbbIlMbjjcNQ8n
VykVGnVqo5Ca5AUbsLysg3Me6ddyiZXh8FzliCobUmAblLTsEi1yRW1B9g==
=DIgk
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [BUG] All drawers except property drawers are open at startup
2020-06-06 2:25 ` Matt Lundin
2020-06-06 3:34 ` stardiviner
@ 2020-06-09 11:52 ` Nicolas Goaziou
1 sibling, 0 replies; 6+ messages in thread
From: Nicolas Goaziou @ 2020-06-09 11:52 UTC (permalink / raw)
To: Matt Lundin; +Cc: Org Mode List
Hello,
Matt Lundin <mdl@imapmail.org> writes:
> In the function org-set-startup-visibility, that commit replaced
>
> (org-cycle-hide-drawers 'all)
>
> with
>
> (org-cycle-hide-property-drawers 'all)
>
> Thus, only property drawers are hidden at startup.
I forgot to say this was, hopefully, fixed in master.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-06-09 11:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-27 21:52 [BUG] All drawers except property drawers are open at startup Matt Lundin
2020-05-28 12:35 ` Nicolas Goaziou
2020-05-28 14:18 ` Matthew Lundin
2020-06-06 2:25 ` Matt Lundin
2020-06-06 3:34 ` stardiviner
2020-06-09 11:52 ` Nicolas Goaziou
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).