From: John Herrlin <firstname.lastname@example.org>
To: ian martins <email@example.com>
Cc: org-mode-email <firstname.lastname@example.org>
Subject: Re: [PATCH] ob-java: Allow import to end with asterisk
Date: Wed, 27 Jan 2021 08:24:52 +0100 [thread overview]
Message-ID: <email@example.com> (raw)
Thank you for the guidence! I will try to figure it out and sending a
updated patch soon.
ian martins <firstname.lastname@example.org> writes:
>> I found this case:
>> And it seems to me that the import regex dont see the asterisk.
>> I attached a possible patch.
> Thanks again, John. You're right the regex is missing the asterisk
> include. Thanks for the patch fixing. This works but it will add
> redundant includes if the source block includes something that is also
> in the list of classes to automatically include.
> for example, this:
> #+begin_src java :results value
> import java.util.*;
> return "test";
> will end up pulling in
> import java.util.List;
> import java.util.*;
> It wouldn't hurt anything, but could probably be prevented by changing
> the regexp in =org-babel-java--import-maybe= to look for asterisk as
> well as =class=. Do you feel like updating the patch?
>  https://code.orgmode.org/bzg/org-mode/src/master/lisp/ob-java.el#L314
next prev parent reply other threads:[~2021-01-27 7:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 7:53 John Herrlin
2021-01-27 3:21 ` ian martins
2021-01-27 7:24 ` John Herrlin [this message]
2021-01-28 20:03 ` John Herrlin
2021-01-30 10:50 ` ian martins
2021-04-25 3:43 ` Timothy
2021-04-25 10:40 ` ian martins
2021-04-26 6:52 ` Bastien
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).