From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id sA59D94giWBaMAEAgWs5BA (envelope-from ) for ; Wed, 28 Apr 2021 10:46:22 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id mCkpC94giWAdEgAAB5/wlQ (envelope-from ) for ; Wed, 28 Apr 2021 08:46:22 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 616191EDD8 for ; Wed, 28 Apr 2021 10:46:21 +0200 (CEST) Received: from localhost ([::1]:55762 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbfps-0006Q9-8D for larch@yhetil.org; Wed, 28 Apr 2021 04:46:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60956) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbfpD-0006Oe-EU for emacs-orgmode@gnu.org; Wed, 28 Apr 2021 04:45:39 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:39799) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbfot-0008Rf-4q for emacs-orgmode@gnu.org; Wed, 28 Apr 2021 04:45:39 -0400 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 39ECD60006; Wed, 28 Apr 2021 08:45:14 +0000 (UTC) From: Nicolas Goaziou To: Stefan Monnier Subject: Re: More use of lexical-binding in ox.el References: <87wnsnig8h.fsf@nicolasgoaziou.fr> Mail-Followup-To: Stefan Monnier , emacs-orgmode@gnu.org Date: Wed, 28 Apr 2021 10:45:14 +0200 Message-ID: <87lf92x0f9.fsf@nicolasgoaziou.fr> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.183.195; envelope-from=mail@nicolasgoaziou.fr; helo=relay3-d.mail.gandi.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_PASS=-0.001, T_SPF_HELO_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619599581; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=+RPWm0zaiWkEi0VDGmAIXrg8oEEUCguxopljg7jbCNg=; b=LcDLNg+14QSBviLN05RigSTOvmnXTA1iVOSJoQ/zGr1EAKPKj2AmbzI0R8xl4HSNX0pi+1 YikuIEVWqsp5NcmQ21OcSWRQs72C6iRKowSUutC4Jk3saDfeJbbbnkR//AGLQGjl6wPuD2 HhHaLY3Enuyyc5iZvmGOFIbEzf3OfdZ7v0syiHZ/dkqjUBkq491yg5+JZbZnVQIWcnN5I+ dZ47U/YREgLisVuB9FH/Hrt0BKKK6aB1MfOZon9/H7jiuHPCPCovGuULTRfjEMFqJ7W/Dj BrNXEDT9K75W/TMjkcqXgbaoBBxAmJyipg7xkrXwAmEjwBUctM0mq2JgKs2zvA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619599581; a=rsa-sha256; cv=none; b=PYLOiuXAFBhPuuUnKRr042OKD5Uh+kN6PT2yUPtFSnA4Dp9Jtnr2Fhem7QxRV/pvfST6Qv geQKL95vy2z+BfUFjxZRyE+h0BNeeFkwpGI7iIURin70oouNCs/tya94Gy8KtJAMz7k0z5 vOd1wm12SX4ClnOaFO5xlwkFnl6OLhrjfuHbg9kqi9DSM8CDVoy+xjwSC5/TUd1YMZg3cI osnzWrGgdUA3HlX+DEJG4emenK5E8kkgM5HxsdaCuvl3Q9vx75rGXMhbTOg6THfqRJJbti CKz5BDh+qSKLcNFlikOf67jwJIVKvsZFRdpQNF5qbJ4RM+vz5Q1rF2erZ6PYaA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -2.45 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 616191EDD8 X-Spam-Score: -2.45 X-Migadu-Scanner: scn0.migadu.com X-TUID: Cqn6rL9nbHYB Hello, Stefan Monnier writes: > That's because the "buffer copy" also copies the local vars, For some reason, I misread the code and thought `buffer-file-name' and `default-directory' were explicitly ignored. Go figure. > Yes: > > (push (cons var val) varvals)))) > varvals))) > > should be > > (push (cons var val) varvals))))) > varvals)) > > so that the final `varvals` is outside the `dolist` (it's the thing we > want to return to store it in the outer `varvals` variable). Indeed. I couldn't spot this. I applied your patch. Thank you! Regards, -- Nicolas Goaziou