emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-orgmode@gnu.org
Subject: Re: More use of lexical-binding in ox.el
Date: Wed, 28 Apr 2021 10:45:14 +0200	[thread overview]
Message-ID: <87lf92x0f9.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: jwvy2d3jqbi.fsf-monnier+emacs@gnu.org


Stefan Monnier <monnier@iro.umontreal.ca> writes:

> That's because the "buffer copy" also copies the local vars,

For some reason, I misread the code and thought `buffer-file-name' and
`default-directory' were explicitly ignored. Go figure.

> Yes:
> 			(push (cons var val) varvals))))
> 	       varvals)))
> should be
> 			(push (cons var val) varvals)))))
> 	     varvals))
> so that the final `varvals` is outside the `dolist` (it's the thing we
> want to return to store it in the outer `varvals` variable).

Indeed. I couldn't spot this.

I applied your patch.

Thank you!

Nicolas Goaziou

  reply	other threads:[~2021-04-28  8:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-20  3:37 More use of lexical-binding in ox.el Stefan Monnier
2021-04-27 21:12 ` Nicolas Goaziou
2021-04-27 22:51   ` Stefan Monnier
2021-04-28  8:45     ` Nicolas Goaziou [this message]
2021-04-28 14:15       ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lf92x0f9.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=monnier@iro.umontreal.ca \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).