From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id SJ6uAVTT5mEtAwEAgWs5BA (envelope-from ) for ; Tue, 18 Jan 2022 15:48:52 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id WGbQOVPT5mFCKAAAauVa8A (envelope-from ) for ; Tue, 18 Jan 2022 15:48:51 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A15E7413A8 for ; Tue, 18 Jan 2022 15:48:51 +0100 (CET) Received: from localhost ([::1]:39498 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n9pn0-0004ul-N9 for larch@yhetil.org; Tue, 18 Jan 2022 09:48:50 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41130) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n9oUn-00049c-DQ for emacs-orgmode@gnu.org; Tue, 18 Jan 2022 08:25:59 -0500 Received: from [2a00:1450:4864:20::12e] (port=33746 helo=mail-lf1-x12e.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n9oUl-0003qF-Qy for emacs-orgmode@gnu.org; Tue, 18 Jan 2022 08:25:57 -0500 Received: by mail-lf1-x12e.google.com with SMTP id m3so56574290lfu.0 for ; Tue, 18 Jan 2022 05:25:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-transfer-encoding; bh=2hmd7zJ1Zj/sch7mxzWRrZjKxsv1ZU332hkMfxo4mr4=; b=krni1HCXAewqSRfthuzJB95PNfvaZZ3WCZAbCObMjYup4J9UH+VSlD3It78W1zDNMQ WWmY4F5ZdMpy/x00guz17HTUHuuJwd8m74VUomesBpF0pOx/YeDHVNuIIu1O42gPmwox vQ5KrXF4tm/xg/nYt8H1WC42Mpdfd/SXWgg0YAgYrrt7AHyHTxGiQce8H1B6oLY8NAx4 GarhtHPDNjKNoLfHUgXiQhxnFQ3c0B52mLbc50a6uGOtm4eZ6x/uWS0xven+dIbfgiHU YZNmtpoB7LNsEl78uxO2dAmNJHyPGxzt/m8wvQNraz3yQ2dqvRWG2Dmowi5fHEfrCXy/ 5bWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=2hmd7zJ1Zj/sch7mxzWRrZjKxsv1ZU332hkMfxo4mr4=; b=ASBRSAqY3GttHfGDT9YpTvx2zCfct32QquEd+kn1NFzKjQwOh731a5zcXHoltNb0w/ AD/OfrcAB2QWF1IPmHXVEzNvRXZP6CydxWqjiElm24fSg5hqBW2DqVXTM+p1QFBPFuDU MoPNBUktwrvNH3eznPGZjVx6Y7NUYr6e+T12HOLqNPVccwxQftpg0XWVwCDGz5e5VN0M h30HGFRIK9awEMwEouK8JCMGTiSWimhxBV5FoyIvMeN0gTbOFimJfgiKw6k8tknRYSm3 LeM4GWoJuAYsw1TYxRk3QN80YtHZPg0iKy/tGMSr0PpqDaCnljnINud5y8jrFasnJeGw WT7w== X-Gm-Message-State: AOAM533eZwn3DeTDWQAYnkUQKNhOm4A48VjxBzhdHggpvMznBKJe7J5r +yrGCEWBvxECIF24GsIveDnsrUCrKT8= X-Google-Smtp-Source: ABdhPJwImKmn9gZbMd3GnOHNLDJrWmaWKjirTmKBEqRAGEte5HL4JFOPAlA0ilJgYTbtBvL5/8ngpg== X-Received: by 2002:ac2:4c45:: with SMTP id o5mr10740387lfk.525.1642512353493; Tue, 18 Jan 2022 05:25:53 -0800 (PST) Received: from localhost ([158.255.2.9]) by smtp.gmail.com with ESMTPSA id m15sm942485ljg.67.2022.01.18.05.25.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jan 2022 05:25:52 -0800 (PST) From: Ihor Radchenko To: Dejan =?utf-8?Q?Josifovi=C4=87?= Subject: Re: [PATCH] ob-plantuml: Allow setting PlantUML args for jar file In-Reply-To: <1a42304e-47b6-48c3-01b4-6d858ddf7770@gmail.com> References: <5d7eba13-b717-a12a-5f89-7d2c9414917e@gmail.com> <87y23hr045.fsf@localhost> <1a42304e-47b6-48c3-01b4-6d858ddf7770@gmail.com> Date: Tue, 18 Jan 2022 21:30:14 +0800 Message-ID: <87lezdnpcp.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::12e (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::12e; envelope-from=yantar92@gmail.com; helo=mail-lf1-x12e.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Max Nikulin , emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1642517331; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=2hmd7zJ1Zj/sch7mxzWRrZjKxsv1ZU332hkMfxo4mr4=; b=dv93d3cSodl3H2LpSBcLQeMBLoc4yv+Dze/ROHjn7dxDgCULrS+c6h3ZtqZq2qjQxibmpO +WCqClc/WySatYdyT+9nE+htF0QSH7E/e6Hsr4qbOmCS07D1rRzbSJu3crcWzCvBWnAZPY ikHlX35TOwSavzRQEURfzxLN+ndeWUwq4TthhQ7JtFRNERAmiB4bSFQmXbpGNyFoeLmJAt sNcNDAp7MlkSp/MJBGx2VONFVDApej1C6lFW2JOWBo7DHuQOgqQbNOdNmhMKdroFZxLh6O 3GpkwcuHj7c5h9+mjLMLf6xCqWptIqVkgVvQ0E2z6msNSSBnFIf8w2KPXr4mKA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1642517331; a=rsa-sha256; cv=none; b=fcXR2kSqXVnsNQ7JVyq+I4nuRU4vBelFYCvJPhQYMPYY0MOuylQJLKDznfg58c+CTe7yfd 4DZCQzDmZ1PBrHWlVqTlcBnT+s0hRfIyuLTVpMBDD6N3fF+T2aXLcWvjWCdQMwzNVob25B eHRrz2vr2VON9nJUqzob1JV/y2GSYvWg/QIpCJgFr2FeCc3tM/QYEc/B3FJ+1UVuIhgEM9 gvBrwLUylhjp3dCXQKpynq82foqeLwC20J0gZJZCezc90K2uJi3jxXfu7lUaMzZ0gf0R+B /dTlqZmFByVsQcRkWx8XB10kzOfJH2pxuRXkbJkQmVQE342wmyvu9o2jdS0Q+Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=krni1HCX; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -8.82 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=krni1HCX; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: A15E7413A8 X-Spam-Score: -8.82 X-Migadu-Scanner: scn0.migadu.com X-TUID: jpbBUA4mEHNZ Dejan Josifovi=C4=87 writes: > But, since ob-plantuml already had variable for arguments for executable= =20 > it fells natural to me to have customizable variables for when using=20 > jar. These headers are of course easier, but the user would have to=20 > write them on each source block to achieve something that should be=20 > globally customizable (like charset). FYI, you can customise any header arg globally. See manual page 16.3 Using Header Arguments. > I second the concern that Max stated: >> Is there a case when some arguments are suitable for dedicated binary bu= t should be avoided for jar (when a user has both executable from system pa= ckage and manually downloaded jar having newer version)? It may be a reason= to have separate variables (or header arguments). > I believe it is better design decision to separate arguments for=20 > executable and jar. I am not sure about this specific case. The PlantUML executable is literally a wrapper around java call to jar. Below is the contents of plantuml file in my system: #!/bin/bash gjl_package=3Dplantuml gjl_jar=3D"plantuml.jar" source /usr/share/java-config-2/launcher/launcher.bash Unless it is any different on your side, the arguments for jar and executable should be literally the same. > Since we are making jar arguments customizable, we should think about=20 > adding java arguments customizable (also mentioned by Max!). This line=20 > in patch: > + "-Djava.awt.headless=3Dtrue" > can be also added to a separate variable. I feel that running headless mode in the ob-plantuml is deliberate. We may not want users to change it. Otherwise, you are free to customize java arguments in org-babel-default-header-args:plantuml > Lastly, there is a typo in the patch: > +** Removed or renamed functions and variables > +*** =3Dorg-plantump-executable-args=3D is renamed and applies to jar as = well > + > +The new variable name is =3Dorg-plantump-args=3D. It now applies to both > +jar PlantUML file and executable. > Word plantump should be plantuml I guess. :-) Thanks! Will fix. Best, Ihor