From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>
Received: from mp12.migadu.com ([2001:41d0:2:4a6f::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by ms5.migadu.com with LMTPS
	id GDpqORV6ymP18QAAbAwnHQ
	(envelope-from <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Fri, 20 Jan 2023 12:25:10 +0100
Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by mp12.migadu.com with LMTPS
	id YMwmORV6ymMI9wAAauVa8A
	(envelope-from <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Fri, 20 Jan 2023 12:25:09 +0100
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by aspmx1.migadu.com (Postfix) with ESMTPS id D24DD1E11
	for <larch@yhetil.org>; Fri, 20 Jan 2023 12:25:08 +0100 (CET)
Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-orgmode-bounces@gnu.org>)
	id 1pIpVS-00017X-44; Fri, 20 Jan 2023 06:24:26 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <yantar92@posteo.net>)
 id 1pIpVQ-000161-Po
 for emacs-orgmode@gnu.org; Fri, 20 Jan 2023 06:24:24 -0500
Received: from mout01.posteo.de ([185.67.36.65])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <yantar92@posteo.net>)
 id 1pIpVO-0002TT-JU
 for emacs-orgmode@gnu.org; Fri, 20 Jan 2023 06:24:24 -0500
Received: from submission (posteo.de [185.67.36.169]) 
 by mout01.posteo.de (Postfix) with ESMTPS id 6DF09240691
 for <emacs-orgmode@gnu.org>; Fri, 20 Jan 2023 12:24:18 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
 t=1674213859; bh=/edTFJ4D3DkA0BcIYYYgIjqTNNRnNGSQocecyN1CNiU=;
 h=From:To:Cc:Subject:Date:From;
 b=jhZvWqSVKqbuZaqL59J1jpq7IskssdIGirdSOm47fBlNI5joOtzL2Yb8cOR5fsrOp
 uGSlU3uvtJZTZO5rcoxzIZAjk3q2E7SVrp5PzQRiVCO6OKxLjDGUNDY0pdSxBI9loU
 H8RyD8BHo/poyxlN3M+ixYbgnqR8kr0gXtgqrlEiWObZ4I+FtVeQFQNcMbvo7ZM33E
 nb/SygwKpMAyyLN1i99+hKWNdydBoBPVZEhs3MhETqB0GYZeBeh+YEq42/fJFJFn5p
 IcVgop/xJhYIz2m5FW1AHvUo6fXSoj3EVujcD6dGTupW1p5DXjiqkgfR8TiDOFDT0E
 7ITQNvbqbWgOg==
Received: from customer (localhost [127.0.0.1])
 by submission (posteo.de) with ESMTPSA id 4NyxwK3s8vz6tmV;
 Fri, 20 Jan 2023 12:24:17 +0100 (CET)
From: Ihor Radchenko <yantar92@posteo.net>
To: gautier@gautierponsinet.xyz
Cc: Bastien <bzg@gnu.org>, emacs-orgmode@gnu.org
Subject: Re: New face: org-agenda-calendar-timerange
In-Reply-To: <12a8d2e8b36fb5c6f61a2b084e22a7b8@gautierponsinet.xyz>
References: <873597xtqr.fsf@gautierponsinet.xyz> <87y1q1h0gm.fsf@localhost>
 <63f0246aa85d34eb4fc787d4fad4c3e3@gautierponsinet.xyz>
 <87v8l46tos.fsf@localhost>
 <bcbbae8e9098b49016529bb64e216e15@gautierponsinet.xyz>
 <87lely4wne.fsf@localhost>
 <12a8d2e8b36fb5c6f61a2b084e22a7b8@gautierponsinet.xyz>
Date: Fri, 20 Jan 2023 11:24:45 +0000
Message-ID: <87lelxsb2a.fsf@localhost>
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net;
 helo=mout01.posteo.de
X-Spam_score_int: -43
X-Spam_score: -4.4
X-Spam_bar: ----
X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: emacs-orgmode@gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org
Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org
X-Migadu-Flow: FLOW_IN
X-Migadu-Country: US
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org;
	s=key1; t=1674213909;
	h=from:from:sender:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:cc:mime-version:mime-version:
	 content-type:content-type:in-reply-to:in-reply-to:
	 references:references:list-id:list-help:list-unsubscribe:
	 list-subscribe:list-post:dkim-signature;
	bh=ooeuyiG9a5y92puPUF6Httr0SxNgWiyu/L53EJP9INk=;
	b=LXuRPd+32omjrTcVfd+MQiH3rebyX/wKieHBDUtspL0tjAA6vu3icqx/Fs5Euz2KieO2Ce
	2XHqRsYXZJV7vL2heZgrQkjVjZpKx/bQHGNT7ylaG4RRPdTWH6i5RDQKdeuRIz5enDFykg
	hYPsoyu5xoH+OUxfDHl7g7z/0GYYYHtkoDWodt7cjvAkt15T8/e2C8Q3TqUIXagPgIPcOU
	SeGnL6+WFDq+u2Fk7ktJjBGrss2kq4cGWdhSWcul16d2yzcJXWH0UN/tIg9vGnjCKtqCVX
	QskArPGM9BQibwMtqza7Ne+hbVfEGb8+oLnRWZSoV2xlh49cQ3Xky1b5Z53Bbg==
ARC-Authentication-Results: i=1;
	aspmx1.migadu.com;
	dkim=pass header.d=posteo.net header.s=2017 header.b=jhZvWqSV;
	dmarc=pass (policy=none) header.from=posteo.net;
	spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"
ARC-Seal: i=1; s=key1; d=yhetil.org; t=1674213909; a=rsa-sha256; cv=none;
	b=eVMScSXUzDW7Gi8JnAeNYHT7ZNWbBFUkzsIP+MLehgH/zfTnnx/CEg+0hxy66AENBRG2nM
	r8eC3rashCh+YQBR97hrzeeowc4M2t7yIX/LW0tl4RtNGZnISl2hMou98s4cWvljdGmKMp
	cKB3Anmfyox/4uZTrL2/W04h67vnLcbS+U9J+H1E7q8TsU80+QVXFH30J/DvyB5VivwnFG
	L9PVzWnHIUsDytetCkhq5OVYQjRg5NU9GotS2VihfVJMOO6N6lUWzx3Ejy2uQngb/paAQH
	ikZRo52SjKaThwVXd2sG30THixzirTjFWAni41cy+lpbmXX3GFosUvHzbe3i3g==
X-Migadu-Scanner: scn1.migadu.com
X-Migadu-Spam-Score: -4.57
X-Spam-Score: -4.57
X-Migadu-Queue-Id: D24DD1E11
Authentication-Results: aspmx1.migadu.com;
	dkim=pass header.d=posteo.net header.s=2017 header.b=jhZvWqSV;
	dmarc=pass (policy=none) header.from=posteo.net;
	spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"
X-TUID: fbncT9EnEskV

gautier@gautierponsinet.xyz writes:

> Please find attached a patch containing two commits.
> The first one applies the face `org-agenda-calendar-event' to entries
> with a time range within a single day.
> The second one defines the new face `org-agenda-calendar-daterange'
> and applies it to entries with a time range on several days. (The
> second commit assumes the first one is already applied.)
>
> Since I am still learning elisp and this is my first contribution, it
> would be very nice if someone could double check the patch, and any
> feedback would be very welcome.

The patch looks good.
Now, just waiting for confirmation from Bastien about your copyright
status records.

> By the way, while trying to understand the code I have discovered the
> commit "cb19f5c94e3dc94da78169ec675d5bd07af34427" by Bastien which I
> don't really understand. The commit message says, talking about
> entries with a timerange:
> "* lisp/org-agenda.el (org-agenda-get-blocks): When both dates are of
> the same value, assume this is a time to display for each date in the
> range."
>
> It seems to me that this should be done by creating repeating tasks
> rather than an entry with a timerange, because suppose I want to put
> in my agenda an event spanning on several days including the precise
> hours at which it starts and ends but which starts and ends on the
> same hour, for example an entry with the following timerange:
>
> <2023-01-19 jeu. 12:00>--<2023-01-26 jeu. 12:00> .

AFAIU, the commit fixed a different scenario:
https://orgmode.org/list/BYAPR07MB573496C31816FE64B71E9D70A5CD0@BYAPR07MB5734.namprd07.prod.outlook.com

<2019-08-05 Mon 08:30-11:00>--<2019-08-09 Fri 08:30-11:00>

(which is, by the way, is not a proper time range, according to Org syntax)

Bastien, the commit asserts that when time parts of the timestamp range
are equal, treat them as repeating event, like <2019-08-05 Mon 08:30-11:00 +1d>
However, when there is an actual date range as in Gautier's example,
things are broken.

I am inclined to revert your commit because the original bug report was
trying to make Org use timestamp format, Org does not really recognize.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>