emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: 赵一宇 <zhyznd@163.com>
Cc: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: [BUG] after execute +org-realign-table-maybe-h may move point [9.6 (9.6-??-bed47b4 @ c:/Users/yhht/.emacs.d/.local/straight/build-28.2/org/)]
Date: Fri, 10 Mar 2023 12:56:34 +0000	[thread overview]
Message-ID: <87lek4ydbx.fsf@localhost> (raw)
In-Reply-To: <b903f90.220f.186ca2eb902.Coremail.zhyznd@163.com>

赵一宇 <zhyznd@163.com> writes:

> +org-realign-table-maybe-h function definition is at the end. 
>
> Instead of using save-excursion macro, it saves current point to a var,
> and restore the point after execute org-table-align.
> That would cause point move visually. Although the (point) value not changed, org-table-align function shall insert  spaces in front of the point. 
> Don't know if it has already fixed, or there are some other concerns.

Note that `+org-realign-table-maybe-h' it is not a function from Org
mode. Likely from Doom Emacs? Did you report to Doom Emacs repo?

`save-excursion' is not always reliable when changes are being made
around point. Sometimes, explicitly storing the (point-marker) is more
reliable. Or storing a relative position. Also, org-table.el provides
`org-table-save-field' macro for similar purposes.

Canceled.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


      reply	other threads:[~2023-03-10 12:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-10  6:21 [BUG] after execute +org-realign-table-maybe-h may move point [9.6 (9.6-??-bed47b4 @ c:/Users/yhht/.emacs.d/.local/straight/build-28.2/org/)] 赵一宇
2023-03-10 12:56 ` Ihor Radchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lek4ydbx.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=emacs-orgmode@gnu.org \
    --cc=zhyznd@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).