From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id YNIUJ5zmlmQ9IQAASxT56A (envelope-from ) for ; Sat, 24 Jun 2023 14:50:36 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id mALGJpzmlmSpxwAAauVa8A (envelope-from ) for ; Sat, 24 Jun 2023 14:50:36 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 522B53BFC1 for ; Sat, 24 Jun 2023 14:50:36 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qD2i1-0000yS-2D; Sat, 24 Jun 2023 08:49:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qD2hz-0000yK-C5 for emacs-orgmode@gnu.org; Sat, 24 Jun 2023 08:49:44 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qD2hx-0006SE-9b for emacs-orgmode@gnu.org; Sat, 24 Jun 2023 08:49:43 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 161C3240028 for ; Sat, 24 Jun 2023 14:49:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1687610979; bh=ldc6sYnbfKnALJPCKiq+Ei40Pf0rEko3/2gmjF0H4Qg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=MIplQTArF/fGsT/n2mfaQGZol2vJoQHrKMFdhrhR6x4Z8y8FH6buREfstvj7M6bBx HkX8ndYOz58gh9mbUeoOTu9XAQLWFROz9qFQUG7ss8Z5rwBmPDRfl45lrToQGKc5Br 4ic0XHV4CyTg88M+6b4bEwXahcgERsLNK9BQSH9D88hWG2jXaGMdXhFyfKtfnbeRcu KUMPVBrMlm4QUQ+/upTvk0SvWdbu5j4PYemC/9L4C4FBrPa4CYhp6dEHM8MTo1yEJK mimrMd4/vTC5rbZg7/IIrtNuLup9QmOGMjwTMFS96nyDrtnj5O2Pf3FufoeD0eoJ/W ygv6sbE4Gn61w== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QpDTG2MSKz6tm4; Sat, 24 Jun 2023 14:49:38 +0200 (CEST) From: Ihor Radchenko To: Max Nikulin Cc: emacs-orgmode@gnu.org Subject: Re: [BUG] org-reload reloads unnecessary files In-Reply-To: References: Date: Sat, 24 Jun 2023 12:54:33 +0000 Message-ID: <87leg958c6.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1687611036; a=rsa-sha256; cv=none; b=G41pUwUTr7dWKWgpON6nXKdxHmHNGapjxyJ73yz180JGMiUxCZB/zUGCAh8zQx2dMPprTD Zf69CxARqvcmUCg5p51hfDWWxYAzIyVrHmr3L0/7f+mb9yRixvT17mQw6nJGYgI+gt6gZ8 50qzaAyWNQuJedDIv6URuxj0ctSsHl5ndiQ3yNdEyvPz8synlD6AztGOoKiYzJogLRDkop Z8doMyQBSVBEYuWFZpvCdG7Agj4Aeq+m4kz90gbTF3W/ByfmLr4ZjmxhTXSx3EpPGMO8m9 7510WjAZnLPzasMUSLQaXKSKvxX42ehptymfwtIDsFsTu1hJ3NMgsBbzmzASzA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=MIplQTAr; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1687611036; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=rlGEE7YHLLpf1c4BngwkWDVXIA2GKNTYQzHwchLetuo=; b=nKK1Ub+YsNGZX7ZUbdmFay026YN05m0Lt1Rv8xsD/rTfY/rE2ZISmG2A9DrhcLtPjd4coJ MH30L4oCNSvLEuR4wxWEnrRKqykcIgHTnjrpX6hJ2l16JYTs+PGYo+RQMhvPVk5zvze0jA dcmwLdzFo/HdlD7hg5XeJjzQp8XUi2EXuTdd6SFdcL5HRuTHSxOngykAr1Neo/az9wwkax jLncHfNhI3SdHC0hIKzS8MzR4TKaKs8V03clsfD/csT3RqIDsT5D3TJohA2xMSj0IQqCJU MeoPf2MlEqArYcq7d5FwH53DNRq9iGiFuxOQJgnyOwEUVbRkXIyPHD+da/fMxw== Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=MIplQTAr; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -7.53 X-Spam-Score: -7.53 X-Migadu-Queue-Id: 522B53BFC1 X-TUID: H8oUDfvb/MiK Max Nikulin writes: > `org-reload' reloads obarray and oclosure libraries that are unrelated > to org-babel and org-cite. I believe, the function should not do it. Confirmed. The regexp used to match Org libraries is too inclusive. > ... I suspect `org-reload' may have another issue > similar to the one that `package--list-loaded-files' had. If an .el.gz > is loaded for some reason instead of the corresponding .elc file than > `org-reload' may fail to detect it. I have not tried to test it though. It should not, by accident. (feats (delete-dups (mapcar 'file-name-sans-extension (mapcar 'file-name-nondirectory (delq nil (mapcar 'feature-file features)))))) `file-name-sans-extension' only strips the last extension in .el.gz. Yet, (org-load-noerror-mustsuffix "foo.el") works the same way as (org-load-noerror-mustsuffix "foo") when we pass UNCOMPILED argument to `org-reload'. We should still fix the case when the loaded file is ".el.gz" though. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at