From: Ihor Radchenko <yantar92@posteo.net>
To: Max Nikulin <manikulin@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG] org-reload reloads unnecessary files
Date: Sat, 24 Jun 2023 12:54:33 +0000 [thread overview]
Message-ID: <87leg958c6.fsf@localhost> (raw)
In-Reply-To: <u76jak$sfg$1@ciao.gmane.io>
Max Nikulin <manikulin@gmail.com> writes:
> `org-reload' reloads obarray and oclosure libraries that are unrelated
> to org-babel and org-cite. I believe, the function should not do it.
Confirmed. The regexp used to match Org libraries is too inclusive.
> ... I suspect `org-reload' may have another issue
> similar to the one that `package--list-loaded-files' had. If an .el.gz
> is loaded for some reason instead of the corresponding .elc file than
> `org-reload' may fail to detect it. I have not tried to test it though.
It should not, by accident.
(feats (delete-dups
(mapcar 'file-name-sans-extension
(mapcar 'file-name-nondirectory
(delq nil
(mapcar 'feature-file
features))))))
`file-name-sans-extension' only strips the last extension in .el.gz.
Yet, (org-load-noerror-mustsuffix "foo.el") works the same way as
(org-load-noerror-mustsuffix "foo") when we pass UNCOMPILED argument to
`org-reload'.
We should still fix the case when the loaded file is ".el.gz" though.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
prev parent reply other threads:[~2023-06-24 12:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-24 11:16 [BUG] org-reload reloads unnecessary files Max Nikulin
2023-06-24 12:54 ` Ihor Radchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87leg958c6.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=manikulin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).