From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id gAUjGzEqqWTd1wAASxT56A (envelope-from ) for ; Sat, 08 Jul 2023 11:19:45 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id mCH6GTEqqWQJwgAAG6o9tA (envelope-from ) for ; Sat, 08 Jul 2023 11:19:45 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3A256547D6 for ; Sat, 8 Jul 2023 11:19:44 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=BpXq2omF; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1688807984; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=1QRQJVvpKD14OTfjQR4r5osbZxcvDjdfvzloMlYyWFI=; b=pZBA/4BoFbBZDv3cbPEWV6f0+bzH8j53RptkaY+Du1wAg7/J1ONSvLtFwRjcJ36rmmk0Ia qeB4QlOawdXNPb0FtqJ2y9l6Xx5Pl8ALzLZyq501fUgafuziP8x34NmQsc3whN2bRkHqWj eDKoOKC2eYt97e4/XpkHk0TrUzSAE5craFF/CoUt+BlFyDcVitZcoCcck8ElqFOvkV0ZoM kjfxGR60joUTvQKJDr7/cDh5CC0T5U6TOdskva7MokhW2tc9pjiIRzfUGk5mfsQgVdqEsb 4KqW0O1uVMtZV7KnxkYMyZgsg4vt+52Ce9CTPN6FI1v5Qk+Uh6OihRt92Irt3g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=BpXq2omF; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1688807984; a=rsa-sha256; cv=none; b=gX2QhsOPHFND4As8mLe46zMHMx3qg9cC+ybUCvZrrXdzFj0iMOANDi92ss+GgTxUqDP6Ev 0vHSDFMRgzMGsayEe+AQXAH1/gDyoNsh6cgonsoyED0xN2hVWhkNbRwv/lL1uBbbxCoreN u/h5yU+EXmbseo+hmyMFvZe50Ve6B3UWxL3WNuCqhHaLZjd7+oLS6nUEvUvOJEwZvqMc9e 5Nu7SS/ePbyJIM5zbZXBYe/yAcYx9gE1h3FqLh64n7JPliGVhDSOa6s61pkDd/glpRfqe2 ut0YpliLlvwOz4PioHZYDFO4a219yeUlumQmGBPEInz/oWRInyULMJ5SMizszA== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qI45e-0001Bp-CD; Sat, 08 Jul 2023 05:18:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qI45c-0001BK-Fx for emacs-orgmode@gnu.org; Sat, 08 Jul 2023 05:18:52 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qI45a-0004bN-AW for emacs-orgmode@gnu.org; Sat, 08 Jul 2023 05:18:52 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 5C05E240101 for ; Sat, 8 Jul 2023 11:18:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1688807928; bh=SaGQLur0RN7Xz3gvnlXpxMFL+s8O3rCeFQFb11BbkhA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=BpXq2omF5rPcZj74jMuDAcDvgJ0rwepAf9jWb9fUP5ElaJs+o9AE67NfCFT14B12/ P69EkknD2WPkz1b3XUmNRyy3LcNKg088sDzRwq6d6tHJp0q1tKa9LpuHR9NshsH2yZ 1jykS9Mj6lKJkPsQlNcE8LIC5rqPjGzrQNDITahUqtWLfR5S+6ltHCAbNeoi4oLmp/ lv8glL3tkk826rJsrTEelcJ5wyxJ6GwkuSFvu6ratSVy+OmR9GNQCXjo1juSTt5YPB Osz+FEYhLEgRVIYfAgYfCCS4WSZXjBIO5etlMlXyqhHW2yLS3WsP0NksJtwyVh2hlW E9iW4Tyb+j6qQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Qyl7W51NQz6txK; Sat, 8 Jul 2023 11:18:47 +0200 (CEST) From: Ihor Radchenko To: Max Nikulin Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH v2] Fix Emacs-26 compatibility (was: Re: [BUG] org-element loading fails with "regexp" argument not "stringp") In-Reply-To: References: <2ff109c7-b3ec-27ac-e75d-ae5ddac14746@vallon.homeip.net> <877creabn6.fsf@localhost> <73ee6087-4c89-9d9a-cbc6-197396a023c1@gmail.com> <87ttuh74bl.fsf@localhost> Date: Sat, 08 Jul 2023 09:18:51 +0000 Message-ID: <87lefqahhg.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: -7.75 X-Migadu-Queue-Id: 3A256547D6 X-Migadu-Scanner: mx1.migadu.com X-Migadu-Spam-Score: -7.75 X-TUID: gorseUaRtJJX Max Nikulin writes: > On 06/07/2023 16:54, Ihor Radchenko wrote: >> You are removing `org-protocol-flatten' function, which is a breaking >> change. We should leave an obsolete alias. > > I have added an alias for this function hardly known to anybody else. It was easy enough, so why not. There is no reason to avoid backward-compatible code when it costs us very little. >> Also, you are defining `flatten-tree' function, which is outside Org's >> namespace. We should better avoid it and use something like >> `org-flatten-tree'. > > The idea was to minimize conflicts with your branch for the compat > package. When used together with compat, we would fight for the same namespace, loading either Org's or compat's variant of the function depending on the loading order. Of course, it would not matter this time - compat's definition of `flatten-tree' is a copy-paste from the Emacs implementation, just as ours. But such practice is to be avoided. > ... I hope, it will be merged soon. Applied, onto main. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=caa27be10 https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=879ba22ef Thanks! -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at