From: Ihor Radchenko <yantar92@posteo.net>
To: Max Nikulin <manikulin@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH v2] Fix Emacs-26 compatibility (was: Re: [BUG] org-element loading fails with "regexp" argument not "stringp")
Date: Sat, 08 Jul 2023 09:18:51 +0000 [thread overview]
Message-ID: <87lefqahhg.fsf@localhost> (raw)
In-Reply-To: <u8aqat$860$1@ciao.gmane.io>
Max Nikulin <manikulin@gmail.com> writes:
> On 06/07/2023 16:54, Ihor Radchenko wrote:
>> You are removing `org-protocol-flatten' function, which is a breaking
>> change. We should leave an obsolete alias.
>
> I have added an alias for this function hardly known to anybody else.
It was easy enough, so why not. There is no reason to avoid
backward-compatible code when it costs us very little.
>> Also, you are defining `flatten-tree' function, which is outside Org's
>> namespace. We should better avoid it and use something like
>> `org-flatten-tree'.
>
> The idea was to minimize conflicts with your branch for the compat
> package.
When used together with compat, we would fight for the same namespace,
loading either Org's or compat's variant of the function depending on
the loading order.
Of course, it would not matter this time - compat's definition of
`flatten-tree' is a copy-paste from the Emacs implementation, just as
ours. But such practice is to be avoided.
> ... I hope, it will be merged soon.
Applied, onto main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=caa27be10
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=879ba22ef
Thanks!
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
prev parent reply other threads:[~2023-07-08 9:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-04 23:51 [BUG] org-element loading fails with "regexp" argument not "stringp" Justin
2023-07-05 10:35 ` Ihor Radchenko
2023-07-05 16:00 ` [PATCH] Fix Emacs-26 compatibility (was: Re: [BUG] org-element loading fails with "regexp" argument not "stringp") Max Nikulin
2023-07-06 9:54 ` Ihor Radchenko
2023-07-08 4:56 ` [PATCH v2] " Max Nikulin
2023-07-08 9:18 ` Ihor Radchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lefqahhg.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=manikulin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).