[BUG] [PATCH] Avoid interaction in test ~ob-tangle/detangle-false-positive~

[BUG] [PATCH] Avoid interaction in test ~ob-tangle/detangle-false-positive~

[Evgenii Klimov]

[-- Attachment #1: Type: text/plain, Size: 684 bytes --]

Test ~ob-tangle/detangle-false-positive~ asks for confirmation to kill
the buffer, connected to testing/examples/babel.org file, that is
modified during the couse of the test.

Way to reproduce the bug (from projects main dir):

#+BEGIN_SRC sh :dir (expand-file-name ".")
emacs -Q \
      -L lisp/ -L testing/ -L testing/lisp -l lisp/org.el \
      -l lisp/org-id.el -l testing/org-test.el -l testing/lisp/test-ob-tangle.el \
      --eval "(progn (org-reload) (setq org-confirm-babel-evaluate nil) \
      (org-babel-do-load-languages 'org-babel-load-languages \
      '((emacs-lisp . t) (shell . t) (org . t))))" \
      --eval '(ert "ob-tangle/detangle-false-positive")'
#+END_SRC


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-testing-lisp-test-ob-tangle.el-Avoid-interaction-in-.patch --]
[-- Type: text/x-diff, Size: 1054 bytes --]

From 5905e37a581d4cf2a4a517593c91730d836b6471 Mon Sep 17 00:00:00 2001
From: Evgenii Klimov <eugene.dev@lipklim.org>
Date: Sun, 16 Jul 2023 13:14:38 +0100
Subject: [PATCH] testing/lisp/test-ob-tangle.el: Avoid interaction in test

* testing/lisp/test-ob-tangle.el (ob-tangle/detangle-false-positive):
Unset modification flag from buffer to kill
(testing/examples/babel.org) in tear down step of test to avoid Emacs
asking for confirmation during interactive testing from within Emacs.
---
 testing/lisp/test-ob-tangle.el | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/testing/lisp/test-ob-tangle.el b/testing/lisp/test-ob-tangle.el
index b1b0a0a53..07e75f4d3 100644
--- a/testing/lisp/test-ob-tangle.el
+++ b/testing/lisp/test-ob-tangle.el
@@ -565,6 +565,8 @@ another block
 	    (should (equal (string-trim (org-element-property
 					 :value (org-element-at-point)))
 			   ";; detangle changes"))))
+      (with-current-buffer buffer
+        (set-buffer-modified-p nil))
       (kill-buffer buffer))))
 
 (provide 'test-ob-tangle)
-- 
2.34.1

Re: [BUG] [PATCH] Avoid interaction in test ~ob-tangle/detangle-false-positive~

[Ihor Radchenko]

Evgenii Klimov <eugene.dev@lipklim.org> writes:

> Test ~ob-tangle/detangle-false-positive~ asks for confirmation to kill
> the buffer, connected to testing/examples/babel.org file, that is
> modified during the couse of the test.
>
> Way to reproduce the bug (from projects main dir):

Thanks!
Waiting for your copyright assignment before applying.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [BUG] [PATCH] Avoid interaction in test ~ob-tangle/detangle-false-positive~

[Evgenii Klimov]

Ihor Radchenko <yantar92@posteo.net> writes:

> Evgenii Klimov <eugene.dev@lipklim.org> writes:
>
>> Test ~ob-tangle/detangle-false-positive~ asks for confirmation to kill
>> the buffer, connected to testing/examples/babel.org file, that is
>> modified during the couse of the test.
>>
>> Way to reproduce the bug (from projects main dir):
>
> Thanks!
> Waiting for your copyright assignment before applying.

Thanks, responsible person from FSF just returned from vacation.

While it's not applied, may I also ask: I noticed that non-default value
'other-frame of =org-src-window-setup= variable in my init.el leads to
creation of multiple frames during interactive testing.

I understand that testing should be done on ~emacs -Q~ etc, but since
it's an option to quickly test interactively in the current process
during development, would you accept the patch where
=org-src-window-setup= would be set to default value inside the test?

It took me some time to figure it out, so further developers in the
similar situation could benefit from it.

Re: [BUG] [PATCH] Avoid interaction in test ~ob-tangle/detangle-false-positive~

[Ihor Radchenko]

Evgenii Klimov <eugene.dev@lipklim.org> writes:

> While it's not applied, may I also ask: I noticed that non-default value
> 'other-frame of =org-src-window-setup= variable in my init.el leads to
> creation of multiple frames during interactive testing.
>
> I understand that testing should be done on ~emacs -Q~ etc, but since
> it's an option to quickly test interactively in the current process
> during development, would you accept the patch where
> =org-src-window-setup= would be set to default value inside the test?

It is not very meaningful.
Tests generally assume default values.
With user config loaded, tests can (and tend to) break randomly.
Sometimes, spectacularly :)

The only proper way to allow running tests while user config is in place
is force-binding _all_ the Org defaults for the duration of the tests.
And even then, custom advices and re-definition may break things.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [BUG] [PATCH] Avoid interaction in test ~ob-tangle/detangle-false-positive~

[Evgenii Klimov]

Ihor Radchenko <yantar92@posteo.net> writes:

> Evgenii Klimov <eugene.dev@lipklim.org> writes:
>
>> Test ~ob-tangle/detangle-false-positive~ asks for confirmation to kill
>> the buffer, connected to testing/examples/babel.org file, that is
>> modified during the couse of the test.
>>
>> Way to reproduce the bug (from projects main dir):
>
> Thanks!
> Waiting for your copyright assignment before applying.

Copyright assignment is complete.

Re: [BUG] [PATCH] Avoid interaction in test ~ob-tangle/detangle-false-positive~

[Ihor Radchenko]

Evgenii Klimov <eugene.dev@lipklim.org> writes:

>> Waiting for your copyright assignment before applying.
>
> Copyright assignment is complete.

Bastien, may you confirm?

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [BUG] [PATCH] Avoid interaction in test ~ob-tangle/detangle-false-positive~

[Bastien Guerry]

Ihor Radchenko <yantar92@posteo.net> writes:

> Evgenii Klimov <eugene.dev@lipklim.org> writes:
>
>>> Waiting for your copyright assignment before applying.
>>
>> Copyright assignment is complete.
>
> Bastien, may you confirm?

Yes I do!  Thanks for the heads up.

-- 
 Bastien Guerry

Re: [BUG] [PATCH] Avoid interaction in test ~ob-tangle/detangle-false-positive~

[Ihor Radchenko]

Bastien Guerry <bzg@gnu.org> writes:

>>> Copyright assignment is complete.
>>
>> Bastien, may you confirm?
>
> Yes I do!  Thanks for the heads up.

Thanks!
Recorded.
https://git.sr.ht/~bzg/worg/commit/daaa35a9

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [BUG] [PATCH] Avoid interaction in test ~ob-tangle/detangle-false-positive~

[Evgenii Klimov]

Ihor Radchenko <yantar92@posteo.net> writes:

> Bastien Guerry <bzg@gnu.org> writes:
>
>>>> Copyright assignment is complete.
>>>
>>> Bastien, may you confirm?
>>
>> Yes I do!  Thanks for the heads up.
>
> Thanks!
> Recorded.
> https://git.sr.ht/~bzg/worg/commit/daaa35a9

Thanks, what about the patch itself?

Re: [BUG] [PATCH] Avoid interaction in test ~ob-tangle/detangle-false-positive~

[Ihor Radchenko]

Ihor Radchenko <yantar92@posteo.net> writes:

> Evgenii Klimov <eugene.dev@lipklim.org> writes:
>
>> Test ~ob-tangle/detangle-false-positive~ asks for confirmation to kill
>> the buffer, connected to testing/examples/babel.org file, that is
>> modified during the couse of the test.
>>
>> Way to reproduce the bug (from projects main dir):
>
> Thanks!
> Waiting for your copyright assignment before applying.

Applied, onto main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=d6f3aed7b

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>