From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id eJGqKPFjbWYLvAAA62LTzQ:P1 (envelope-from ) for ; Sat, 15 Jun 2024 09:50:41 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id eJGqKPFjbWYLvAAA62LTzQ (envelope-from ) for ; Sat, 15 Jun 2024 11:50:41 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=HrTqOMCk; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1718445041; a=rsa-sha256; cv=none; b=jhFtcWP0S+bk5F8vCggKdzNUvseBV5XxaItHI0xDG0hMXM4Tep/u1a70r6r2zV9Zj1sbTS L/wxdtYDh+bwgQo2LTy/eoJlaDD5+jsI6c4xJF+DZ/YdVQxddJRMvfHvDils2ajosaeh9a z/G74PStELIw1wvp4q7dXmHBcdfRLsAbOhJ81vE/rRZlfgGaPWd/qon/xSeqVNWq8VEI8k jWSyUIwhGEZ32ZkrxNS22u8lRcKqu+yWoip8fBsDW7JY8TQf6ArXr1yupaQedzEFN+oB2S U5zvvZ8OlshUo9iSsarvvvmjjPRjEaIzsJnKscqZg9btrhEd4LfrJ7OjX2Z+iw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=HrTqOMCk; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1718445041; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=rXlIfVd9vhXiRJHEQS7F3PzOCdMron2DCniPAD5J8D4=; b=l+efWay8HkKKzPI9GpRWU7UOeW3eTmotymTZ7YfloPhZGEGYxPsIW475G0Co1DhGvOsaSd QkXD7BYn4SbxAmI6VsAxMKYJEc2mC0N4Oi/KX2CgfzN2tymn4CGYshtw6eKf5gu0NpiN0j I3+Ysy1EpqYKNzwYRO6xmjx9ocHLLm3RqskbmdaNgco5O/rg5CZXtfu1mdLEWEL2W7bxgv 0Ne7Pk+9UFeUazHOyos6LBywQUYeWUoG7q/wwi+B3nzmbPiYkUrczaomTLWkBeJyMEFMLx JLj3TwtjzRk6iccDCK321VKBFyGGZpb0nmHq/PjRRGKvPAa3/HAQ7lWMFJEOBQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6E6DB3649B for ; Sat, 15 Jun 2024 11:50:41 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sIQ2c-0005o0-Sw; Sat, 15 Jun 2024 05:49:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sIQ2a-0005nU-Du for emacs-orgmode@gnu.org; Sat, 15 Jun 2024 05:49:44 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sIQ2Y-0003v7-6y for emacs-orgmode@gnu.org; Sat, 15 Jun 2024 05:49:44 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 646D2240028 for ; Sat, 15 Jun 2024 11:49:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1718444978; bh=7WRIpe9MMU27TKo2OruGDDgk2nrLdO8rI8vtwSmaSAM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=HrTqOMCkwG646bH+m5TZusfn1kCrkYhw1R5XHFOzNPJdsf5SXAhZ6JaTVfXayGke7 JnoJgLbMzM1fZWIO4IlLu9V5Sbpk6DNcBIHKXMkGcF6YeNVI6SLrnr6ISzmd20JKdH OjROk6hmwzfjU/AzJkTPV9C122MKHtlf6Pysy7DO2Xouud8oZOVG2Jnq+SImYRNM3g RyRuwHAFctrNxnMBCkuMAx19SXxcaOAR9/PKY0KAY39oarEAx/WTCZTL+tFuUhTXWm hiM7KUg0vpZHHIS8V/YW47eAxyuczw0xlNso00qJ0PEAqshjauihXH1V2p3WLKA9zP w42gRX6T/ryNg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4W1WZn1YDCz6tvs; Sat, 15 Jun 2024 11:49:37 +0200 (CEST) From: Ihor Radchenko To: Visuwesh Cc: emacs-orgmode@gnu.org Subject: Re: [BUG] org-plot: Unable to use text xtics with type:2d (+ more) [9.7-pre (N/A @ /home/viz/lib/emacs/straight/build/org/)] In-Reply-To: <87ikyd48f8.fsf@gmail.com> References: <87cypbjw50.fsf@gmail.com> <871q5rv1qy.fsf@localhost> <8734q7jfes.fsf@gmail.com> <87wmmu72pu.fsf@localhost> <87zfrp4939.fsf@gmail.com> <87ikyd48f8.fsf@gmail.com> Date: Sat, 15 Jun 2024 09:51:15 +0000 Message-ID: <87le36ilf0.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: 6E6DB3649B X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -9.57 X-Spam-Score: -9.57 X-TUID: eOsuSahsgVm8 Visuwesh writes: > Sorry for the noise, I copied the wrong link in the commit message. > Please see attached instead. Thanks! I have some comments. > - (type (assoc (plist-get params :plot-type) > - org-plot/preset-plot-types)) > + (type (cdr (assoc (plist-get params :plot-type) > + org-plot/preset-plot-types))) > gnuplot-script) This may break the existing customization. Later in the function, TYPE is used as an argument for `org-plot/gnuplot-term-extra' and `org-plot/gnuplot-script-preamble'. Some users may have these two custom options adjusted to the older calling convention. To not break things, we should pass the full `assoc' to these functions. Also, while you are at it, may your please clarify what TYPE means in the docstrings of `org-plot/gnuplot-term-extra' and `org-plot/gnuplot-script-preamble'? > (setf params (org-plot/collect-options params)))) > + (setq params (org-combine-plists type params)) May you also drop a short comment in the code that explains what this line does? -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at