From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id aBF6L7vEb2ZwxAAAe85BDQ:P1 (envelope-from ) for ; Mon, 17 Jun 2024 05:08:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id aBF6L7vEb2ZwxAAAe85BDQ (envelope-from ) for ; Mon, 17 Jun 2024 07:08:11 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WBPB9kil; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1718600891; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=R58tZALsktD/fGdpu17ebqfg8eDBLl4K4EQw0uJqfSc=; b=rmjgLbJQpzIVHh7J3/nBN5TBCP/ANZ0EuiVS54hdpVMQwV9w/fX83ozFKqbALylqLPvZdA qSZCeJXZOHoT6VaOE4TFOlG71QxGBS2S2FiPjm2BmuecvhmXp70ZHE+uPxsAftjP0u2DHS Rxr32bbGFUbuX/c090PXcUMh8N4Q9idsVwN4CwXZCTQEmD+O2Wi06/DVpJjgXmxpA0P25g Xl0pCnSE7FilqIaMgiNZ2LiNBsTqJXi60+TO5nJ5rnlOPR9oo32mnwov5nXrx9r7dUFOwi A9giHzd//NlA/dzLDoLj+HyzouDK9ymYWqdyoQ2viCYckz8OzNvygA+dZyQWnQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WBPB9kil; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=key1; d=yhetil.org; t=1718600891; a=rsa-sha256; cv=none; b=DcbsTFLrtwsGtsuQ2mb1VwZmc5E3pjQUVsSa679xqeaRs53kw3Z0q8X8RbryvDozNjNve8 kXZJ9Kozrsy/Q1/DknPb2S268WqEpmT/598/6SnPnqGJWcw+MqECmzAKBU/1cJENU9+OY/ CF4phbOWovSkV0ThHKzfL5NB9d4HCZbJvVPcyM89OiGx+POasJNA5VPfwAs2QNRcG1/DEg FellHyu1chv9wBgVYf6ghShJgmzT/NWvUwKhdr13/ijSUm+EPwDuOPmUvIHahbFjHuPkJh Jak28wSY9KNOmGaHtQEYj+vxOR+e+QZdM4u7s8zkaIvXjjCeALnymaVi3/MsPQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8B7BB65873 for ; Mon, 17 Jun 2024 07:08:11 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sJ4ai-0002UH-T6; Mon, 17 Jun 2024 01:07:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJ4ah-0002U9-19 for emacs-orgmode@gnu.org; Mon, 17 Jun 2024 01:07:39 -0400 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sJ4af-0006NV-HV for emacs-orgmode@gnu.org; Mon, 17 Jun 2024 01:07:38 -0400 Received: by mail-pg1-x544.google.com with SMTP id 41be03b00d2f7-70a365a4532so473595a12.1 for ; Sun, 16 Jun 2024 22:07:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718600856; x=1719205656; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:references :message-id:date:in-reply-to:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=R58tZALsktD/fGdpu17ebqfg8eDBLl4K4EQw0uJqfSc=; b=WBPB9kilrdwGcVRBzfn7V39oKOmfHWxRqUfsolIKRGWGm8hPQABy3u5mWO+ch1Pbzw YsQzdTzp+JNIz6Ew3gWDNODRfwNTlmQnDDMiZbh78FdfBcC4igjRj6KRwdu5krYgOVQQ mUe8oe6PMmz79jL5XfcRui9VOp9qiwsWdQPl873ZSjhI9b1PSoW3ssv+oEXhOrFXh/9b NEu90pn9w7EiMPS2GfQSyupHFgfBNv/uRdtfqmiFGrl4g31qUOsuGGJOrdCyQJiXxiZh g/DORBLMjPZU9zTzipYVw5IvvXzVCFa+V5rF2WYATkOm6yAy6rjd+2p5n+sQaU0zvo4T t6zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718600856; x=1719205656; h=content-transfer-encoding:mime-version:user-agent:references :message-id:date:in-reply-to:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=R58tZALsktD/fGdpu17ebqfg8eDBLl4K4EQw0uJqfSc=; b=us31UWgxi9Y59jK0qKpKI8BJjG8kyHIR/vjK/TYtmIilydAxX2ZBc1yiiM9OVL7br4 pCFySnEh8phCY4BUrLxDcVFQd7oJCrpes5te1mIjERHel9JkE/rWYBtM5QXxreG/qH/a JJTBwrTlw6UXSw9OjCEOwirEQyETtEL50VW44qn4z7JjhJNnPeTq30z2Ltx2lurcnAFm CyCG45SCGvUPEHR6SQTpwdokDaFUNJEsElBZPlrtjojSTRS6xyPJ4/FZsVRexT3BolIy oyXImSf41eNU/HjmhsizOpj8FS4FqP2zaCmrgrKyWNLcD0haycsxnO3ZoOMptYfSBjdG FN+g== X-Gm-Message-State: AOJu0YxcYh1rC3Zoo0YQCa5vknLukBMNMmP3rJywuRPHq2Ml7p4w7RAV A4D3fB8+PyDjNMkHgvtuaBS5NbyPg6nn6e+ttU9vH4+4R2+4XmBI8W0EIkap X-Google-Smtp-Source: AGHT+IGzRzn2e8IWhcjUtL+h5yLxJjtF0xdpLwzceCfh1kH9YPe+Tv1uxoeqaJ8S/2rGr646LN4a6Q== X-Received: by 2002:a05:6a20:258e:b0:1b5:ac9b:a59e with SMTP id adf61e73a8af0-1bae7f00813mr10885000637.32.1718600855908; Sun, 16 Jun 2024 22:07:35 -0700 (PDT) Received: from localhost ([103.232.241.147]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-705cc97fd59sm6663066b3a.84.2024.06.16.22.07.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Jun 2024 22:07:35 -0700 (PDT) From: Visuwesh To: Ihor Radchenko Cc: emacs-orgmode@gnu.org Subject: Re: [BUG] org-plot: Unable to use text xtics with type:2d (+ more) [9.7-pre (N/A @ /home/viz/lib/emacs/straight/build/org/)] In-Reply-To: <87le36ilf0.fsf@localhost> (Ihor Radchenko's message of "Sat, 15 Jun 2024 09:51:15 +0000") Date: Mon, 17 Jun 2024 10:36:17 +0530 Message-ID: <87le3440qe.fsf@gmail.com> References: <87cypbjw50.fsf@gmail.com> <871q5rv1qy.fsf@localhost> <8734q7jfes.fsf@gmail.com> <87wmmu72pu.fsf@localhost> <87zfrp4939.fsf@gmail.com> <87ikyd48f8.fsf@gmail.com> <87le36ilf0.fsf@localhost> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::544; envelope-from=visuweshm@gmail.com; helo=mail-pg1-x544.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: 8B7BB65873 X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -9.69 X-Spam-Score: -9.69 X-TUID: KZ5Z47uwtyMB [=E0=AE=9A=E0=AE=A9=E0=AE=BF =E0=AE=9C=E0=AF=82=E0=AE=A9=E0=AF=8D 15, 2024]= Ihor Radchenko wrote: > Visuwesh writes: > >> Sorry for the noise, I copied the wrong link in the commit message. >> Please see attached instead. > > Thanks! > I have some comments. > >> - (type (assoc (plist-get params :plot-type) >> - org-plot/preset-plot-types)) >> + (type (cdr (assoc (plist-get params :plot-type) >> + org-plot/preset-plot-types))) >> gnuplot-script) > > This may break the existing customization. > Later in the function, TYPE is used as an argument for > `org-plot/gnuplot-term-extra' and `org-plot/gnuplot-script-preamble'. > Some users may have these two custom options adjusted to the older > calling convention. > > To not break things, we should pass the full `assoc' to these functions. If you meant org-plot/gnuplot-script eventually calling these functions, then I don't see how the above change will break things. Even in org-plot/gnuplot-script, TYPE passed to both these user options are (let* ((type-name (plist-get params :plot-type)) (type (cdr (assoc type-name org-plot/preset-plot-types)))) so there should be no harm done by the above change since TYPE is not an argument taken by org-plot/gnuplot-script. > Also, while you are at it, may your please clarify what TYPE means in > the docstrings of `org-plot/gnuplot-term-extra' and > `org-plot/gnuplot-script-preamble'? OK. >> (setf params (org-plot/collect-options params)))) >> + (setq params (org-combine-plists type params)) > > May you also drop a short comment in the code that explains what this > line does? I will send an updated patch once my confusion is cleared.