From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Danjou Subject: Re: [PATCH] org-macs: store evaluated version of pom Date: Sat, 26 Feb 2011 19:15:19 +0100 Message-ID: <87k4gmek7c.fsf@keller.adm.naquadah.org> References: <1298640633-17072-1-git-send-email-julien@danjou.info> <87hbbqaet6.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0443958477==" Return-path: Received: from [140.186.70.92] (port=52382 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PtOg5-0006Hx-8u for emacs-orgmode@gnu.org; Sat, 26 Feb 2011 13:15:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PtOg0-0004V5-7E for emacs-orgmode@gnu.org; Sat, 26 Feb 2011 13:15:37 -0500 Received: from prometheus.naquadah.org ([212.85.154.174]:49457 helo=mx1.naquadah.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PtOg0-0004Uq-2Q for emacs-orgmode@gnu.org; Sat, 26 Feb 2011 13:15:32 -0500 In-Reply-To: <87hbbqaet6.fsf@gnu.org> (Bastien's message of "Sat, 26 Feb 2011 18:25:25 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bastien Cc: emacs-orgmode@gnu.org --===============0443958477== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Sat, Feb 26 2011, Bastien wrote: >> * lisp/org-macs.el (org-with-point-at): Store evaluated version of pom. = This >> fixes a potential bug when using (org-with-point-at (func) =E2=80=A6), w= here (func) >> would be evaluated multiple times > > I'm not sure I understand this patch. > > Can you show an actual use of org-with-point-at as the one you describe? > > Maybe that's related to some code your are working on? Yes it is. This patch just fix one problem. Without it, what is set with pom is evaluated multiple times: (org-with-point-at (function-that-return-some-marker) (do-stuff)) (function-that-return-some-marker) will be called several times, which can causes a lot of problem, as you imagine just by reading the current code. This patch evalute the function, store it to `pom' and use this variable instead. =2D-=20 Julien Danjou =E2=9D=B1 http://julien.danjou.info --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBAgAGBQJNaUM3AAoJEGEbqVCLeKXC+3YP/RA972w7OTzL745mS4VUdA8C fvu1BH2eLTAe4hsMC5LzGRPa4anmdySfBqhqFjMlhrbEanfgUpzyWR/pyHvrMY4b kDVOLzO7LbTMjL1DFeERVmQrpbXz1oFaUs4bWTYh01GpH+enttFSmE+KYMpIc2/4 1xRedlSrYl7u5X9QV2JxQocAo29Snh1/r6jxsGxY6t7Ww49qy07RBAMtWK70FOzu IyvDyZNhlCkN4vyU2MGLPUOVbo+P37kUdklzWHdINbia4VwLssui5EErrDiOyOD9 /6hHCluyxyp+bHbBUVPFVVMn8xK6/P4rmCCvj6v34Ox7Q7pRCWDbiwSspyENp+V3 ZGLP9p25JaebXEPbBhX7wdGq1NKW3WS8rpboe43XoXN7ZOxHTzx8yLn/ZDRQ1tXN bWhrK/WoOcmJuGK9No8vD8LCvouKm/4V2Qcy0LfYJ2gAFP8ne1JNyQbbD49aFZPy 02D8ih4/ePTy8JUZwndd3reiM0NccjsOy6S3mnpJu9uAO7ahlEASfURsxKb66ndj OkOH5wci3Nr0RjOM4fLoRgCQ3yespSa2r83cn5CyVahm0O919hJWZis+7bhJhBsb 92fGaZzoz0UWzxProPPcGf0pDsWePlOgf7+x1NcPOljCvoYz+xSBEexMQgq0uBOp eGW0d7DI0Au4Mr25UO5l =L3C8 -----END PGP SIGNATURE----- --=-=-=-- --===============0443958477== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode --===============0443958477==--