From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Schulte <eric.schulte@gmx.com>
Subject: Re: functions from cl package called at runtime
Date: Thu, 19 Jan 2012 11:08:27 -0700
Message-ID: <87k44n4la9.fsf@gmx.com>
References: <87aa5k25ml.fsf@Rainer.invalid>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([140.186.70.92]:42069)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eric.schulte@gmx.com>) id 1Rnwlr-0003FK-4k
	for emacs-orgmode@gnu.org; Thu, 19 Jan 2012 13:31:36 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eric.schulte@gmx.com>) id 1Rnwlp-0006ZG-Qw
	for emacs-orgmode@gnu.org; Thu, 19 Jan 2012 13:31:35 -0500
Received: from mailout-us.gmx.com ([74.208.5.67]:43074)
	by eggs.gnu.org with smtp (Exim 4.71)
	(envelope-from <eric.schulte@gmx.com>) id 1Rnwlp-0006Z6-JO
	for emacs-orgmode@gnu.org; Thu, 19 Jan 2012 13:31:33 -0500
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Achim Gratz <Stromeko@nexgo.de>
Cc: emacs-orgmode@gnu.org

Thanks for catching this, I've just pushed up a fix.

Is there a convention for which macros from cl-macs are allowable and
which are forbidden?  For example `flet' is used extensively throughout
the Org-mode code base.  Is the convention that macros are allowable
while functions are not?

Also, while intersection below is a function defined in cl-seq, the use
of `intersection' in ob.el refers to a local function and not the cl-seq
function, so it should be fine.

Thanks,

Achim Gratz <Stromeko@nexgo.de> writes:

> The sources in ob.el have picked up several runtime invocations to
> functions from the cl package via two commits from Eric:
>
> fc92b2e2 lisp/ob.el (let ((tempvar (gensym "file")))
> fc92b2e2 lisp/ob.el (let ((tempvar (gensym "file")))
> fc92b2e2 lisp/ob.el (let ((tempvar (gensym "file")))
> fc92b2e2 lisp/ob.el (let ((tempvar (gensym "file"))
> fc92b2e2 lisp/ob.el   (rx (gensym "rx")))
> abf3060e lisp/ob.el (flet ((intersection (as bs)
> abf3060e lisp/ob.el                      (intersection (cdr as) bs)))))
> abf3060e lisp/ob.el   (intersection (case context
>
> These may need to be revised...
>
>
> Regards,
> Achim.

-- 
Eric Schulte
http://cs.unm.edu/~eschulte/