emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bastien <bzg@gnu.org>
To: Kevin Buchs <kevin.buchs.junk@gmail.com>
Cc: Org Mode <emacs-orgmode@gnu.org>
Subject: Re: Rounding timeclock and moving to the end of the line
Date: Thu, 24 May 2012 11:25:23 +0200	[thread overview]
Message-ID: <87k402j5h8.fsf@gnu.org> (raw)
In-Reply-To: <CAEqjYhvukHyaZKCxccPX6a_Leapt4tmQ5zQqcPK8WUWTX9C_dg@mail.gmail.com> (Kevin Buchs's message of "Wed, 23 May 2012 15:53:55 -0500")

Hi Kevin,

Kevin Buchs <kevin.buchs.junk@gmail.com> writes:

> This is my first contribution to this email list.

Welcome!

> Having a need to do my clocking in 1/4-hour multiples, I went and
> fully implemented my own solution in org-mode BEFORE I realized that
> org-mode was already set up to do it - it was just not completely
> implemented. I needed to change a few (current-time) in org-clock-in
> (org-clock.el) to be (org-current-time) and it works like a charm.

What is your value of ̀org-time-stamp-rounding-minutes'?

Replacing (current-time) with (org-current-time) here will surprise
users that use ̀org-time-stamp-rounding-minutes' only for modifying
time-stamps and not for clocking in.

We could have an option for this, letting users decide whether they 
want `org-time-stamp-rounding-minutes' to apply to clocking in.  Do 
you want to work in this direction?

> Here are the changes based on the development sources cloned via git
> today:
>
> 1198c1198
> < (/ (- (org-float-time (org-current-time))
> ---
>> (/ (- (org-float-time (current-time))
> 1202c1202
> < (org-current-time)))
> ---
>> (current-time)))

For next patches, please use `C-x v =' from the modified buffer, it
creates a well formatted patch.  Also consider git format-patch for
bigger changes.  Please read this:

  http://orgmode.org/worg/org-contribute.html#sec-4

> I have filled out the paperwork with FSF to be a developer in emacs/
> org-mode.

Let us know when this is done.

> My next project is to solve the problem that C-e does not move to the
> end of the line with long lines that are not headings. I find myself
> doing this often and have to hit multiple C-e s. I don't have the
> org-special-ctrl-a/e set to non-nil. My line-move-visual is the
> default value of t, so I get the end-of-visual-line movement one
> screen's worth. 

C-e always go to the end of ordinary lines here, with various values of
`org-special-ctrl-a/e' and `line-move-visual'.  Can you post a recipe
and an example file so that I can reprodce?

> Before I make any changes, I thought I should be
> clear on the design goals here. It seems as if the declaration of
> line-move-visual says it is dealing with vertical motion, not
> horizontal motion. I don't see any behavior elsewhere that uses the
> interpretation that line-move-visual is for horizontal motion. Anyone
> have thoughts on this subject?

I'm not sure I understand the issue correctly - thanks for further
details. 

Best,

-- 
 Bastien

  reply	other threads:[~2012-05-24  9:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-23 20:53 Rounding timeclock and moving to the end of the line Kevin Buchs
2012-05-24  9:25 ` Bastien [this message]
2012-05-24 16:11   ` Kevin Buchs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k402j5h8.fsf@gnu.org \
    --to=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=kevin.buchs.junk@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).