From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Schulte <eric.schulte@gmx.com>
Subject: Re: make test on Mac
Date: Wed, 01 Aug 2012 09:35:52 -0600
Message-ID: <87k3xi8w13.fsf@gmx.com>
References: <E537AB11-4D10-4BFA-AFEF-A4CEF5955A4D@univie.ac.at>
	<873946ofmt.fsf@gnu.org> <87wr1i8y5d.fsf@gmx.com>
	<87txwmll1d.fsf@gnu.org> <87r4rq8x9j.fsf@gmx.com>
	<87lihyljqu.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:46751)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eric.schulte@gmx.com>) id 1Sway9-00055k-Bz
	for emacs-orgmode@gnu.org; Wed, 01 Aug 2012 11:36:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eric.schulte@gmx.com>) id 1Sway8-0000RJ-2F
	for emacs-orgmode@gnu.org; Wed, 01 Aug 2012 11:36:17 -0400
Received: from mailout-us.gmx.com ([74.208.5.67]:55545)
	by eggs.gnu.org with smtp (Exim 4.71)
	(envelope-from <eric.schulte@gmx.com>) id 1Sway7-0000Qi-Qo
	for emacs-orgmode@gnu.org; Wed, 01 Aug 2012 11:36:15 -0400
In-Reply-To: <87lihyljqu.fsf@gnu.org> (Bastien's message of "Wed, 01 Aug 2012
	17:22:49 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Bastien <bzg@gnu.org>
Cc: Neuwirth Erich <erich.neuwirth@univie.ac.at>, Org Mode <emacs-orgmode@gnu.org>

Bastien <bzg@gnu.org> writes:

> Eric Schulte <eric.schulte@gmx.com> writes:
>
>> Bastien <bzg@gnu.org> writes:
>>
>>> Eric Schulte <eric.schulte@gmx.com> writes:
>>>
>>>> Hmm, these tests should only be run if the "gfortran" executable is in
>>>> your path.  
>>>
>>> So let's take them out of the test suite when gfortran is not present?
>>
>> That is what we do currently, or at least that is what we're supposed to
>> be doing currently...  From the top of test-ob-fortran.el
>>
>>     ;; -*- emacs-lisp -*-
>>     (org-test-for-executable "gfortran")
>>     (unless (featurep 'ob-fortran)
>>       (signal 'missing-test-dependency "Support for Fortran code blocks"))
>
> Maybe this should be 
>
>     (unless (and (org-test-for-executable "gfortran") (featurep 'ob-fortran))
>       (signal 'missing-test-dependency "Support for Fortran code blocks"))
>
> ?
>
> to also ignore the test when gfortran does not exist?  Wild guess.

Nope, `org-test-for-executable' signals it's own error, but if we
changed `org-test-for-executable' to return a boolean and then used your
example above it would be more readable.

Best,

-- 
Eric Schulte
http://cs.unm.edu/~eschulte