From: Eric Schulte <eric.schulte@gmx.com>
To: Bastien <bzg@gnu.org>
Cc: Neuwirth Erich <erich.neuwirth@univie.ac.at>,
Org Mode <emacs-orgmode@gnu.org>
Subject: Re: make test on Mac
Date: Wed, 01 Aug 2012 09:35:52 -0600 [thread overview]
Message-ID: <87k3xi8w13.fsf@gmx.com> (raw)
In-Reply-To: <87lihyljqu.fsf@gnu.org> (Bastien's message of "Wed, 01 Aug 2012 17:22:49 +0200")
Bastien <bzg@gnu.org> writes:
> Eric Schulte <eric.schulte@gmx.com> writes:
>
>> Bastien <bzg@gnu.org> writes:
>>
>>> Eric Schulte <eric.schulte@gmx.com> writes:
>>>
>>>> Hmm, these tests should only be run if the "gfortran" executable is in
>>>> your path.
>>>
>>> So let's take them out of the test suite when gfortran is not present?
>>
>> That is what we do currently, or at least that is what we're supposed to
>> be doing currently... From the top of test-ob-fortran.el
>>
>> ;; -*- emacs-lisp -*-
>> (org-test-for-executable "gfortran")
>> (unless (featurep 'ob-fortran)
>> (signal 'missing-test-dependency "Support for Fortran code blocks"))
>
> Maybe this should be
>
> (unless (and (org-test-for-executable "gfortran") (featurep 'ob-fortran))
> (signal 'missing-test-dependency "Support for Fortran code blocks"))
>
> ?
>
> to also ignore the test when gfortran does not exist? Wild guess.
Nope, `org-test-for-executable' signals it's own error, but if we
changed `org-test-for-executable' to return a boolean and then used your
example above it would be more readable.
Best,
--
Eric Schulte
http://cs.unm.edu/~eschulte
next prev parent reply other threads:[~2012-08-01 15:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-01 14:10 make test on Mac Neuwirth Erich
2012-08-01 14:23 ` Bastien
2012-08-01 14:50 ` Eric Schulte
2012-08-01 14:54 ` Bastien
2012-08-01 15:09 ` Eric Schulte
2012-08-01 15:22 ` Bastien
2012-08-01 15:35 ` Eric Schulte [this message]
2012-08-01 16:00 ` Bastien
2012-08-01 16:25 ` Eric Schulte
2012-08-02 15:14 ` Bastien
2012-08-01 21:02 ` Neuwirth Erich
2012-08-02 6:35 ` Achim Gratz
[not found] ` <01862F34-A919-41E0-965A-360C4836EB91@univie.ac.at>
[not found] ` <1353139.E680GS25m4@rainer>
2012-08-04 7:10 ` Neuwirth Erich
2012-08-04 8:05 ` Achim Gratz
2012-08-08 15:42 ` Neuwirth Erich
2012-08-01 14:46 ` Achim Gratz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k3xi8w13.fsf@gmx.com \
--to=eric.schulte@gmx.com \
--cc=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
--cc=erich.neuwirth@univie.ac.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).