emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Eric Schulte <schulte.eric@gmail.com>
To: Bastien <bzg@altern.org>
Cc: Achim Gratz <Stromeko@nexgo.de>, emacs-orgmode@gnu.org
Subject: Re: babel perl issue
Date: Fri, 14 Dec 2012 11:13:14 -0700	[thread overview]
Message-ID: <87k3skh58l.fsf@gmail.com> (raw)
In-Reply-To: <87hanole91.fsf@bzg.ath.cx> (Bastien's message of "Fri, 14 Dec 2012 18:44:58 +0100")

Bastien <bzg@altern.org> writes:

> Eric Schulte <schulte.eric@gmail.com> writes:
>
>> This patch is still broken
>
> (I don't know why ~$ git format-patch master did not produce an
> applicable patch.)
>
> These three ones are applicable against master/68d4de2.
>
> Bare in mind this is just meant as a proof it "works", we can
> rework the patches later on.

These applied and I now see what they are doing.  This is equivalent to
moving all of the core Babel libraries into a single massive ob.el.  I
explicitly like the separation of functional units of Babel into
separate files, and this sort of refactoring would make Babel harder to
maintain in the future.

What do you find so unappealing about the existence of ob-core.el to
justify such drastic proposals?

Perhaps it would be possible to take all of those functions which are
defined in ob-core *and* are required by other components of Babel, and
move them to an ob-util.el file.  Then we could move the remaining
public facing functions of Babel which are not used in any of it's
components (e.g., org-babel-execute-src-block) and move them into ob.el.

Would that feel cleaner to you?

Thanks,

-- 
Eric Schulte
http://cs.unm.edu/~eschulte

  reply	other threads:[~2012-12-14 18:13 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-09 10:54 babel perl issue flav
2012-12-09 11:15 ` Achim Gratz
2012-12-09 15:22   ` Eric Schulte
2012-12-09 20:34     ` Achim Gratz
2012-12-10 15:11       ` Eric Schulte
2012-12-10 15:22         ` flav
2012-12-10 15:32           ` Eric Schulte
2012-12-10 15:43             ` flav
2012-12-10 17:24               ` Eric Schulte
2012-12-11  9:05                 ` flav
2012-12-11 13:45                   ` Eric Schulte
2012-12-11 15:50                     ` flav
2012-12-11 18:04                     ` Achim Gratz
2012-12-12  6:15                     ` flav
2012-12-10 17:51               ` Achim Gratz
2012-12-10 17:44         ` Achim Gratz
2012-12-10 18:13           ` Eric Schulte
2012-12-10 18:36             ` Achim Gratz
2012-12-11 14:33               ` Eric Schulte
2012-12-11 18:31                 ` Achim Gratz
2012-12-12  0:22                   ` Eric Schulte
2012-12-12 13:34                     ` Achim Gratz
2012-12-11 18:39                 ` Bastien
2012-12-12  0:25                   ` Eric Schulte
2012-12-12 15:57                     ` Bastien
2012-12-12 16:11                       ` Eric Schulte
2012-12-12 16:23                         ` Bastien
2012-12-12 16:33                           ` Eric Schulte
2012-12-12 16:59                             ` Bastien
2012-12-12 17:09                               ` Eric Schulte
2012-12-12 17:13                               ` Achim Gratz
2012-12-12 17:24                                 ` Bastien
2012-12-12 17:47                                   ` Eric Schulte
2012-12-12 18:07                                     ` Bastien
2012-12-12 18:28                                       ` Eric Schulte
2012-12-13 23:27                                         ` Bastien
2012-12-13 23:37                                           ` Bastien
2012-12-14  0:37                                           ` Eric Schulte
2012-12-14  9:55                                             ` Bastien
2012-12-14 15:57                                               ` Eric Schulte
2012-12-14 17:44                                                 ` Bastien
2012-12-14 18:13                                                   ` Eric Schulte [this message]
2012-12-14 19:11                                                     ` Bastien
2012-12-12 18:00                                   ` Achim Gratz
2012-12-12 15:59       ` Bastien
2012-12-12 16:54         ` Achim Gratz
     [not found]   ` <CAOnk0vRL8PWS3JfuCAqcRcNa3FkM7tG3eH5w8cBdwtNrx757Xw@mail.gmail.com>
     [not found]     ` <1497100.pF6dAE0Itl@rainer>
2012-12-10  5:32       ` flav
2012-12-10 10:33         ` flav
2012-12-10 15:13           ` Eric Schulte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k3skh58l.fsf@gmail.com \
    --to=schulte.eric@gmail.com \
    --cc=Stromeko@nexgo.de \
    --cc=bzg@altern.org \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).