From mboxrd@z Thu Jan 1 00:00:00 1970 From: Achim Gratz Subject: Re: [Bug] commit 39070b7fc7 breaks babel test Date: Sat, 07 Dec 2013 09:56:16 +0100 Message-ID: <87k3fh9gzz.fsf@Rainer.invalid> References: <87eh622s3g.fsf@Rainer.invalid> <87ob4t6b3q.fsf@gmail.com> <87ob4tkbhg.fsf@Rainer.invalid> <87zjod2xz2.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52437) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VpDgg-0005eC-J6 for emacs-orgmode@gnu.org; Sat, 07 Dec 2013 03:56:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VpDga-0007tA-7M for emacs-orgmode@gnu.org; Sat, 07 Dec 2013 03:56:34 -0500 Received: from plane.gmane.org ([80.91.229.3]:54341) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VpDga-0007st-1G for emacs-orgmode@gnu.org; Sat, 07 Dec 2013 03:56:28 -0500 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1VpDgZ-0004ug-4g for emacs-orgmode@gnu.org; Sat, 07 Dec 2013 09:56:27 +0100 Received: from pd9eb3248.dip0.t-ipconnect.de ([217.235.50.72]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 07 Dec 2013 09:56:27 +0100 Received: from Stromeko by pd9eb3248.dip0.t-ipconnect.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 07 Dec 2013 09:56:27 +0100 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Eric Schulte writes: > This test (test-ob/catches-all-references) is from commit c21692506d8, > which doesn't have anything to do with newlines (judging from the commit > message). > > To me the more natural behavior is to include the newline in the > expansion. Maybe we have discussed this before on list, and decided > stripping the newline was preferable, but I don't recall that > discussion. I seem to have misremembered. Anyway, when you committed that test you apparently thought it was more natural to leave the trailing newline out. I'm not using such constructs myself, but changing this behaviour more than two years later carries a risk that people have documents that rely on it, for good or bad reasons. > Just because behavior ends up being encoded in a test doesn't > necessarily mean the behavior is correct. I think as test suites > attempt to protect the desired behavior they often end up also > protecting incidental behavior of the implementation at the time the > test was written. Well, a test test should proof the specification is implemented correctly. This is exactly why test methodology has evolved to unit tests, which mostly avoids testing for incident behaviour or emergent phenomena. Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ Wavetables for the Terratec KOMPLEXER: http://Synth.Stromeko.net/Downloads.html#KomplexerWaves