From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien <bzg@gnu.org>
Subject: Re: One broken property drawer prevents setting of any property
Date: Fri, 23 May 2014 07:56:40 +0200
Message-ID: <87k39df36v.fsf@bzg.ath.cx>
References: <87wqdzebq0.fsf@ericabrahamsen.net>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37978)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1WniTK-0001Ws-5O
	for emacs-orgmode@gnu.org; Fri, 23 May 2014 01:56:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1WniTE-0007Fe-DF
	for emacs-orgmode@gnu.org; Fri, 23 May 2014 01:56:50 -0400
Received: from mail-wi0-x22c.google.com ([2a00:1450:400c:c05::22c]:65302)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1WniTE-0007FW-6M
	for emacs-orgmode@gnu.org; Fri, 23 May 2014 01:56:44 -0400
Received: by mail-wi0-f172.google.com with SMTP id hi2so284988wib.5
	for <emacs-orgmode@gnu.org>; Thu, 22 May 2014 22:56:43 -0700 (PDT)
In-Reply-To: <87wqdzebq0.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of
	"Tue, 06 May 2014 13:07:51 +0800")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: Nicolas Goaziou <n.goaziou@gmail.com>, emacs-orgmode@gnu.org

Hi Eric,

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> By passing the FORCE argument to `org-get-property-block', the broken
> block ends up getting silently repaired, and everything works as normal.

Can you show this as a patch?

> I'm not sure, however, that silently repairing things without the user's
> knowledge is the right thing to do...

We can warn the user with a temporary message, or ask him for
confirmation.  Or provide a helper command to repair drawers and
advertize it instead of throwing an error.

I'll look into this after you send me the patch.

Thanks,

-- 
 Bastien