From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Rasmus <rasmus@gmx.us>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug with label names in beamer export
Date: Tue, 16 Jun 2015 22:18:44 +0200 [thread overview]
Message-ID: <87k2v39zkr.fsf@selenimh.access.network> (raw)
In-Reply-To: <87fv5ra1j9.fsf@gmx.us> (rasmus@gmx.us's message of "Tue, 16 Jun 2015 21:36:26 +0200")
Hello,
Rasmus <rasmus@gmx.us> writes:
> Suvayu Ali <fatkasuvayu+linux@gmail.com> writes:
>
>> The attached patch should fix the issue.
>
> Pushed, thanks. I changed the commit message slightly.
>
>> * lisp/ox-beamer.el (org-beamer--get-label): wrap labels in {..}
>
> You don't need the "lisp/" prefix. Capitalize after the colon. Should
> end with period.
Thanks. Nitpick however: wouldn't it be more readable to use "sec-" as
a prefix instead of "sec:" in order to solve the issue?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2015-06-16 20:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-16 19:11 Bug with label names in beamer export Suvayu Ali
2015-06-16 19:36 ` Rasmus
2015-06-16 20:18 ` Nicolas Goaziou [this message]
2015-06-16 20:25 ` Rasmus
2015-06-16 20:41 ` Nicolas Goaziou
2015-06-17 6:35 ` Suvayu Ali
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k2v39zkr.fsf@selenimh.access.network \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=rasmus@gmx.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).