emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* a patch to org.el of git version
@ 2015-09-21  3:13 Tokuya Kameshima
  2015-09-22 19:27 ` Nicolas Goaziou
  0 siblings, 1 reply; 4+ messages in thread
From: Tokuya Kameshima @ 2015-09-21  3:13 UTC (permalink / raw)
  To: mail; +Cc: kametoku, emacs-orgmode

Hi,

This is a tiny patch to `org-show-children' which shoule be an
interactive function but not.

Thanks,
--Tokuya

----------------------------------------------------------------------
diff --git a/lisp/org.el b/lisp/org.el
index ce80129..7a58568 100755
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -24902,6 +24902,7 @@ modified."
   "Show all direct subheadings of this heading.
 Prefix arg LEVEL is how many levels below the current level should be shown.
 Default is enough to cause the following heading to appear."
+  (interactive "P")
   (save-excursion
     (org-back-to-heading t)
     (let* ((current-level (funcall outline-level))

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: a patch to org.el of git version
  2015-09-21  3:13 a patch to org.el of git version Tokuya Kameshima
@ 2015-09-22 19:27 ` Nicolas Goaziou
  2015-09-23  0:33   ` Tokuya Kameshima
  0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Goaziou @ 2015-09-22 19:27 UTC (permalink / raw)
  To: Tokuya Kameshima; +Cc: emacs-orgmode

Hello,

Tokuya Kameshima <kametoku@gmail.com> writes:

> This is a tiny patch to `org-show-children' which shoule be an
> interactive function but not.

Thank you. However, `org-show-children' is not meant to be interactive,
because its functionality is incomplete within Org. It also needs
`org-show-entry'.

In any case, I fixed its docstring since it was misleading.

Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: a patch to org.el of git version
  2015-09-22 19:27 ` Nicolas Goaziou
@ 2015-09-23  0:33   ` Tokuya Kameshima
  2015-09-23 22:04     ` Nicolas Goaziou
  0 siblings, 1 reply; 4+ messages in thread
From: Tokuya Kameshima @ 2015-09-23  0:33 UTC (permalink / raw)
  To: mail; +Cc: kametoku, emacs-orgmode

Hi Nicolas,

Thank you for the update.
But it looks like `org-show-children' is a replacement of `show-children'.
Actually the key bind for `show-children' (C-c TAB in my case) is remapped
to `org-show-children' as below.

org.el:5733:
> (define-key org-mode-map [remap show-children] 'org-show-children)

When I typed C-C TAB on an org-mode buffer, I got the following error:

    Wrong type argument: commandp, org-show-children

Thanks,
--Tokuya

On Tue, 22 Sep 2015 21:27:08 +0200,
Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
>
> Hello,
> 
> Tokuya Kameshima <kametoku@gmail.com> writes:
> 
> > This is a tiny patch to `org-show-children' which shoule be an
> > interactive function but not.
> 
> Thank you. However, `org-show-children' is not meant to be interactive,
> because its functionality is incomplete within Org. It also needs
> `org-show-entry'.
> 
> In any case, I fixed its docstring since it was misleading.
> 
> Regards,
> 
> -- 
> Nicolas Goaziou

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: a patch to org.el of git version
  2015-09-23  0:33   ` Tokuya Kameshima
@ 2015-09-23 22:04     ` Nicolas Goaziou
  0 siblings, 0 replies; 4+ messages in thread
From: Nicolas Goaziou @ 2015-09-23 22:04 UTC (permalink / raw)
  To: Tokuya Kameshima; +Cc: emacs-orgmode

Tokuya Kameshima <kametoku@gmail.com> writes:

> But it looks like `org-show-children' is a replacement of `show-children'.
> Actually the key bind for `show-children' (C-c TAB in my case) is remapped
> to `org-show-children' as below.
>
> org.el:5733:
>> (define-key org-mode-map [remap show-children] 'org-show-children)
>
> When I typed C-C TAB on an org-mode buffer, I got the following error:
>
>     Wrong type argument: commandp, org-show-children

You are right. This is now fixed. Thank you.

Regards,

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-09-23 22:02 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-21  3:13 a patch to org.el of git version Tokuya Kameshima
2015-09-22 19:27 ` Nicolas Goaziou
2015-09-23  0:33   ` Tokuya Kameshima
2015-09-23 22:04     ` Nicolas Goaziou

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).