From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakob Lombacher Subject: Re: [PATCH] custom port for postgresql Date: Fri, 16 Sep 2016 09:48:45 +0200 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a114b6886274e19053c9b316e Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40171) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bknuW-0001Os-C0 for emacs-orgmode@gnu.org; Fri, 16 Sep 2016 03:50:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bknuS-0002Ik-4H for emacs-orgmode@gnu.org; Fri, 16 Sep 2016 03:50:11 -0400 Received: from mail-wm0-f54.google.com ([74.125.82.54]:35865) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bknuR-0002BC-QY for emacs-orgmode@gnu.org; Fri, 16 Sep 2016 03:50:08 -0400 Received: by mail-wm0-f54.google.com with SMTP id b187so22359146wme.1 for ; Fri, 16 Sep 2016 00:49:46 -0700 (PDT) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Adam Porter Cc: emacs-orgmode@gnu.org --001a114b6886274e19053c9b316e Content-Type: multipart/alternative; boundary=001a114b6886274e12053c9b316c --001a114b6886274e12053c9b316c Content-Type: text/plain; charset=UTF-8 Hi Adam, thanks for the "patch" hint ;-) I changed the dbport as optional argument and added the dbpassword option as well. Jakob 2016-09-14 7:04 GMT+02:00 Adam Porter : > Jakob Lombacher writes: > > > -(defun org-babel-sql-dbstring-postgresql (host user database) > > +(defun org-babel-sql-dbstring-postgresql (host port user database) > > Hi Jakob, > > Two suggestions: > > 1. Generally people put something like "[PATCH]" in the subject so that > the maintainers will know it contains a patch. :) > > 2. I'd suggest putting the new `port` argument at the end of the > argument list, after an `&optional`. Even though it makes more sense to > put it after the host, putting it at the end and making it optional > means that people won't have to change existing code that calls this > function. > > Thanks for submitting the patch. > > > --001a114b6886274e12053c9b316c Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Adam,

thanks for the "patch= " hint ;-)

I changed the dbport as optional argument= and added the dbpassword option as well.

Jako= b

2016-09-14 7:04 GMT+02:00 Adam Porter <adam@alphapapa.net>= :
Jakob Lombacher <Jakob@lombacher.net> writes:

> -(defun org-babel-sql-dbstring-postgresql (host user database) > +(defun org-babel-sql-dbstring-postgresql (host port user databas= e)

Hi Jakob,

Two suggestions:

1.=C2=A0 Generally people put something like "[PATCH]" in the sub= ject so that
the maintainers will know it contains a patch.=C2=A0 :)

2.=C2=A0 I'd suggest putting the new `port` argument at the end of the<= br> argument list, after an `&optional`.=C2=A0 Even though it makes more se= nse to
put it after the host, putting it at the end and making it optional
means that people won't have to change existing code that calls this function.

Thanks for submitting the patch.



--001a114b6886274e12053c9b316c-- --001a114b6886274e19053c9b316e Content-Type: text/x-patch; charset=US-ASCII; name="0001-add-dbport-and-dbpassword-options-to-psql.patch" Content-Disposition: attachment; filename="0001-add-dbport-and-dbpassword-options-to-psql.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_it5gnuvp0 RnJvbSBlOTJlNTk4MmMzYThkYjEyNWUxNjFkNjc2ODM1YjQ3ZWQzODA2MDcxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYWtvYiBMb21iYWNoZXIgPEpha29iQExvbWJhY2hlci5uZXQ+ CkRhdGU6IEZyaSwgMTYgU2VwIDIwMTYgMDk6MTI6NTYgKzAyMDAKU3ViamVjdDogW1BBVENIXSBh ZGQgZGJwb3J0IGFuZCBkYnBhc3N3b3JkIG9wdGlvbnMgdG8gcHNxbAoKLS0tCiBsaXNwL29iLXNx bC5lbCB8IDggKysrKystLS0KIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDMgZGVs ZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9vYi1zcWwuZWwgYi9saXNwL29iLXNxbC5lbApp bmRleCA3ODAxYzVmLi5lZDdmZWI4IDEwMDY0NAotLS0gYS9saXNwL29iLXNxbC5lbAorKysgYi9s aXNwL29iLXNxbC5lbApAQCAtOTAsMTIgKzkwLDEzIEBACiAJICAgICAgICh3aGVuIHBhc3N3b3Jk IChjb25jYXQgIi1wIiBwYXNzd29yZCkpCiAJICAgICAgICh3aGVuIGRhdGFiYXNlIChjb25jYXQg Ii1EIiBkYXRhYmFzZSkpKSkpKQogCi0oZGVmdW4gb3JnLWJhYmVsLXNxbC1kYnN0cmluZy1wb3N0 Z3Jlc3FsIChob3N0IHVzZXIgZGF0YWJhc2UpCisoZGVmdW4gb3JnLWJhYmVsLXNxbC1kYnN0cmlu Zy1wb3N0Z3Jlc3FsIChob3N0IHVzZXIgZGF0YWJhc2UgJm9wdGlvbmFsIHBvcnQpCiAgICJNYWtl IFBvc3RncmVTUUwgY29tbWFuZCBsaW5lIGFyZ3MgZm9yIGRhdGFiYXNlIGNvbm5lY3Rpb24uCiBQ YXNzIG5pbCB0byBvbWl0IHRoYXQgYXJnLiIKICAgKGNvbWJpbmUtYW5kLXF1b3RlLXN0cmluZ3MK ICAgIChkZWxxIG5pbAogCSAobGlzdCAod2hlbiBob3N0IChjb25jYXQgIi1oIiBob3N0KSkKKwkg ICAgICAgKHdoZW4gcG9ydCAgICAgKGZvcm1hdCAiLXAlZCIgcG9ydCkpCiAJICAgICAgICh3aGVu IHVzZXIgKGNvbmNhdCAiLVUiIHVzZXIpKQogCSAgICAgICAod2hlbiBkYXRhYmFzZSAoY29uY2F0 ICItZCIgZGF0YWJhc2UpKSkpKSkKIApAQCAtMTY3LDExICsxNjgsMTIgQEAgVGhpcyBmdW5jdGlv biBpcyBjYWxsZWQgYnkgYG9yZy1iYWJlbC1leGVjdXRlLXNyYy1ibG9jaycuIgogCQkJCSAgICAo b3JnLWJhYmVsLXByb2Nlc3MtZmlsZS1uYW1lIGluLWZpbGUpCiAJCQkJICAgIChvcmctYmFiZWwt cHJvY2Vzcy1maWxlLW5hbWUgb3V0LWZpbGUpKSkKIAkJICAgIChgcG9zdGdyZXNxbCAoZm9ybWF0 Ci0JCQkJICAicHNxbCAtLXNldD1cIk9OX0VSUk9SX1NUT1A9MVwiICVzIC1BIC1QIFwKKwkJCQkg ICIlc3BzcWwgLS1zZXQ9XCJPTl9FUlJPUl9TVE9QPTFcIiAlcyAtQSAtUCBcCiBmb290ZXI9b2Zm IC1GIFwiXHRcIiAgJXMgLWYgJXMgLW8gJXMgJXMiCisJCQkJICAoaWYgZGJwYXNzd29yZCAoZm9y bWF0ICJQR1BBU1NXT1JEPSVzICIgZGJwYXNzd29yZCkgIiIpCiAJCQkJICAoaWYgY29sbmFtZXMt cCAiIiAiLXQiKQogCQkJCSAgKG9yZy1iYWJlbC1zcWwtZGJzdHJpbmctcG9zdGdyZXNxbAotCQkJ CSAgIGRiaG9zdCBkYnVzZXIgZGF0YWJhc2UpCisJCQkJICAgZGJob3N0IGRidXNlciBkYXRhYmFz ZSBkYnBvcnQpCiAJCQkJICAob3JnLWJhYmVsLXByb2Nlc3MtZmlsZS1uYW1lIGluLWZpbGUpCiAJ CQkJICAob3JnLWJhYmVsLXByb2Nlc3MtZmlsZS1uYW1lIG91dC1maWxlKQogCQkJCSAgKG9yIGNt ZGxpbmUgIiIpKSkKLS0gCjIuOC4xCgo= --001a114b6886274e19053c9b316e-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [PATCH] custom port for postgresql Date: Sat, 17 Sep 2016 10:39:34 +0200 Message-ID: <87k2earkc9.fsf@saiph.selenimh> References: Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49419) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1blB9w-0002EH-F1 for emacs-orgmode@gnu.org; Sat, 17 Sep 2016 04:39:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1blB9t-0006gu-7r for emacs-orgmode@gnu.org; Sat, 17 Sep 2016 04:39:40 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:36981) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1blB9t-0006gh-28 for emacs-orgmode@gnu.org; Sat, 17 Sep 2016 04:39:37 -0400 In-Reply-To: (Jakob Lombacher's message of "Fri, 16 Sep 2016 09:48:45 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Jakob Lombacher Cc: Adam Porter , emacs-orgmode@gnu.org Hello, Jakob Lombacher writes: > I changed the dbport as optional argument and added the dbpassword option > as well. I applied your patch with the modifications below: - I added a proper commit message - I added TINYCHANGE cookie - I reordered dbport argument as in your initial patch. Although the recommendation of making it optional makes sense, it breaks consistency with other "dbstring" functions, and this is an internal function anyway. Could you provide an entry for ORG-NEWS file? Thank you for the patch. Regards, -- Nicolas Goaziou From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakob Lombacher Subject: Re: [PATCH] custom port for postgresql Date: Thu, 22 Sep 2016 16:03:47 +0200 Message-ID: References: <87k2earkc9.fsf@saiph.selenimh> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=047d7b874df2747e64053d192142 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58559) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bn4cu-00014I-3H for emacs-orgmode@gnu.org; Thu, 22 Sep 2016 10:05:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bn4cp-0006mX-EY for emacs-orgmode@gnu.org; Thu, 22 Sep 2016 10:05:22 -0400 Received: from mail-wm0-f42.google.com ([74.125.82.42]:34309) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bn4cp-0006X2-5h for emacs-orgmode@gnu.org; Thu, 22 Sep 2016 10:05:19 -0400 Received: by mail-wm0-f42.google.com with SMTP id 197so6528924wmk.1 for ; Thu, 22 Sep 2016 07:04:48 -0700 (PDT) In-Reply-To: <87k2earkc9.fsf@saiph.selenimh> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Jakob Lombacher , Adam Porter , emacs-orgmode@gnu.org --047d7b874df2747e64053d192142 Content-Type: multipart/alternative; boundary=047d7b874df2747e60053d192140 --047d7b874df2747e60053d192140 Content-Type: text/plain; charset=UTF-8 Hi Nicolas, sure, here you go. All the best Jakob 2016-09-17 10:39 GMT+02:00 Nicolas Goaziou : > Hello, > > Jakob Lombacher writes: > > > I changed the dbport as optional argument and added the dbpassword option > > as well. > > I applied your patch with the modifications below: > > - I added a proper commit message > > - I added TINYCHANGE cookie > > - I reordered dbport argument as in your initial patch. Although the > recommendation of making it optional makes sense, it breaks > consistency with other "dbstring" functions, and this is an internal > function anyway. > > Could you provide an entry for ORG-NEWS file? > > Thank you for the patch. > > Regards, > > -- > Nicolas Goaziou > --047d7b874df2747e60053d192140 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Nicolas,

sure, here you go.

All the best

Jakob

2016-09-17 10:39 GMT+02:00 Nicolas Goaziou <ma= il@nicolasgoaziou.fr>:
Hell= o,

Jakob Lombacher <Jakob@lombacher.= net> writes:

> I changed the dbport as optional argument and added the dbpassword opt= ion
> as well.

I applied your patch with the modifications below:

- I added a proper commit message

- I added TINYCHANGE cookie

- I reordered dbport argument as in your initial patch. Although the
=C2=A0 recommendation of making it optional makes sense, it breaks
=C2=A0 consistency with other "dbstring" functions, and this is a= n internal
=C2=A0 function anyway.

Could you provide an entry for ORG-NEWS file?

Thank you for the patch.

Regards,

--
Nicolas Goaziou

--047d7b874df2747e60053d192140-- --047d7b874df2747e64053d192142 Content-Type: text/x-patch; charset=US-ASCII; name="0001-ORG-NEWS-support-of-header-argument-for-postgresql.patch" Content-Disposition: attachment; filename="0001-ORG-NEWS-support-of-header-argument-for-postgresql.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iteeqf4l0 RnJvbSBkZDk2NGI3YWY5ZWEwODJhNWQ4ZDcxNjMwNTY1ODk5ZGFiZjdhMTE2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYWtvYiBMb21iYWNoZXIgPEpha29iQExvbWJhY2hlci5uZXQ+ CkRhdGU6IFRodSwgMjIgU2VwIDIwMTYgMTU6NTk6MzUgKzAyMDAKU3ViamVjdDogW1BBVENIXSBP UkctTkVXUyBzdXBwb3J0IG9mIGhlYWRlciBhcmd1bWVudCBmb3IgcG9zdGdyZXNxbAoKLS0tCiBl dGMvT1JHLU5FV1MgfCA1ICsrKysrCiAxIGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspCgpk aWZmIC0tZ2l0IGEvZXRjL09SRy1ORVdTIGIvZXRjL09SRy1ORVdTCmluZGV4IGVkYTAxOGYuLmRl OTlmN2IgMTAwNjQ0Ci0tLSBhL2V0Yy9PUkctTkVXUworKysgYi9ldGMvT1JHLU5FV1MKQEAgLTMx Nyw2ICszMTcsMTEgQEAgQWxpY2UgPC0tIEJvYjogYW5vdGhlciBhdXRoZW50aWNhdGlvbiBSZXNw b25zZQogUGxlYXNlIG5vdGUgdGhhdCAqcGRmKiAqZG9lcyBub3Qgd29yayBvdXQgb2YgdGhlIGJv eCogYW5kIG5lZWRzcwogYWRkaXRpb25hbCBzZXR1cCBpbiBhZGRpdGlvbiB0byBwbGFudHVtbC4g U2VlCiBbW2h0dHA6Ly9wbGFudHVtbC5jb20vcGRmLmh0bWxdXSBmb3IgZGV0YWlscyBhbmQgc2V0 dXAgaW5mb3JtYXRpb24uCisqKioqIEltcHJvdmVkIHN1cHBvcnQgb2YgaGVhZGVyIGFyZ3VtZW50 cyBmb3IgcG9zdGdyZXNxbCAKKyAgICAgVGhlIHBvc3RncmVzcWwgZW5naW5lIGluIGEgc3FsIGNv ZGUgYmxvY2sgc3VwcG9ydHMgbm93ICo6ZGJwb3J0KgorICAgICBhbmQgKjpkYnBhc3N3b3JkKiBh cyBoZWFkZXIgYXJndW1lbnRzLgorICAgICAKKyAgICAgCiAqKiogUmV3cml0ZSBvZiByYWRpbyBs aXN0cwogUmFkaW8gbGlzdHMsIGkuZSwgT3JnIHBsYWluIGxpc3RzIGluIGZvcmVpZ24gYnVmZmVy cywgaGF2ZSBiZWVuCiByZXdyaXR0ZW4gdG8gYmUgb24gcGFyIHdpdGggUmFkaW8gdGFibGVzLiAg WW91IGNhbiB1c2UgYSBsYXJnZSBzZXQgb2YKLS0gCjIuOC4xCgo= --047d7b874df2747e64053d192142-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [PATCH] custom port for postgresql Date: Thu, 22 Sep 2016 21:50:04 +0200 Message-ID: <87h997k93n.fsf@nicolasgoaziou.fr> References: <87k2earkc9.fsf@saiph.selenimh> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:60116) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnA0Y-0007y2-DM for emacs-orgmode@gnu.org; Thu, 22 Sep 2016 15:50:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bnA0V-0004bn-1W for emacs-orgmode@gnu.org; Thu, 22 Sep 2016 15:50:10 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:35136) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnA0U-0004ad-SP for emacs-orgmode@gnu.org; Thu, 22 Sep 2016 15:50:06 -0400 In-Reply-To: (Jakob Lombacher's message of "Thu, 22 Sep 2016 16:03:47 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Jakob Lombacher Cc: Adam Porter , emacs-orgmode@gnu.org Hello, Jakob Lombacher writes: > Hi Nicolas, > > sure, here you go. Applied. Thank you. Regards, -- Nicolas Goaziou