From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [PATCH] custom port for postgresql
Date: Sat, 17 Sep 2016 10:39:34 +0200
Message-ID: <87k2earkc9.fsf@saiph.selenimh>
References: <CALAc-BsHsGo6cRhnSX7B_L=Mxq7kj9Hr=iVZPspxYJTL6nruoA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49419)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1blB9w-0002EH-F1
	for emacs-orgmode@gnu.org; Sat, 17 Sep 2016 04:39:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1blB9t-0006gu-7r
	for emacs-orgmode@gnu.org; Sat, 17 Sep 2016 04:39:40 -0400
Received: from relay3-d.mail.gandi.net ([217.70.183.195]:36981)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1blB9t-0006gh-28
	for emacs-orgmode@gnu.org; Sat, 17 Sep 2016 04:39:37 -0400
In-Reply-To: <CALAc-BsHsGo6cRhnSX7B_L=Mxq7kj9Hr=iVZPspxYJTL6nruoA@mail.gmail.com>
	(Jakob Lombacher's message of "Fri, 16 Sep 2016 09:48:45 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Jakob Lombacher <Jakob@lombacher.net>
Cc: Adam Porter <adam@alphapapa.net>, emacs-orgmode@gnu.org

Hello,

Jakob Lombacher <Jakob@lombacher.net> writes:

> I changed the dbport as optional argument and added the dbpassword option
> as well.

I applied your patch with the modifications below:

- I added a proper commit message

- I added TINYCHANGE cookie

- I reordered dbport argument as in your initial patch. Although the
  recommendation of making it optional makes sense, it breaks
  consistency with other "dbstring" functions, and this is an internal
  function anyway.

Could you provide an entry for ORG-NEWS file?

Thank you for the patch.

Regards,

-- 
Nicolas Goaziou