Bug: Orgguide missing in Org-9.3 package [9.3 (9.3-elpa @ /home/David/.emacs.d/elpa/org-9.3/)]

Bug: Orgguide missing in Org-9.3 package [9.3 (9.3-elpa @ /home/David/.emacs.d/elpa/org-9.3/)]

[David Masterson]

Remember to cover the basics, that is, what you expected to happen and
what in fact did happen.  You don't know how to make a good report?  See

     https://orgmode.org/manual/Feedback.html#Feedback

Your bug report will be posted to the Org mailing list.
------------------------------------------------------------------------

Subject says it all -- I didn't have orgguide in the installation of the
org-9.3 package, so I pulled the latest git master and copied it from
there.  I guess the build process needs a fix.

Emacs  : GNU Emacs 26.3 (build 1, x86_64-pc-cygwin, X toolkit, Xaw3d scroll bars)
 of 2019-08-30
Package: Org mode version 9.3 (9.3-elpa @ /home/David/.emacs.d/elpa/org-9.3/)

Re: Bug: Orgguide missing in Org-9.3 package [9.3 (9.3-elpa @ /home/David/.emacs.d/elpa/org-9.3/)]

[Nicolas Goaziou]

Hello,

David Masterson <dsmasterson@outlook.com> writes:

> Subject says it all -- I didn't have orgguide in the installation of the
> org-9.3 package, so I pulled the latest git master and copied it from
> there.  I guess the build process needs a fix.

AFAICT, the build process properly generates the texinfo file for the
Org guide. It may be an issue related to how Org was merged with Emacs.

I'm Cc'ing Kyle, as I think he has write access to Emacs repository, and
can fix it.

Thank you.

Regards,

-- 
Nicolas Goaziou

Re: Bug: Orgguide missing in Org-9.3 package [9.3 (9.3-elpa @ /home/David/.emacs.d/elpa/org-9.3/)]

[Kyle Meyer]

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> David Masterson <dsmasterson@outlook.com> writes:
>
>> Subject says it all -- I didn't have orgguide in the installation of the
>> org-9.3 package, so I pulled the latest git master and copied it from
>> there.  I guess the build process needs a fix.
>
> AFAICT, the build process properly generates the texinfo file for the
> Org guide. It may be an issue related to how Org was merged with Emacs.
>
> I'm Cc'ing Kyle, as I think he has write access to Emacs repository, and
> can fix it.

Sorry, I don't have write access.  But this issue seems to be about the
Org ELPA tarball, so I don't understand how it'd be related to the
recent Org sync with the Emacs repo.

Checking the tarball at <https://elpa.gnu.org/packages/org-9.3.tar> as
well as some recent ones at <https://orgmode.org/elpa/>, I didn't spot
orgguide in any of them.  And when I run `make elpa' from the Org repo,
the tarball indeed seems to be missing the orgguide info file.  Assuming
there's not a good reason that orgguide is omitted, I think fixing this
is just a matter of adding orgguide to server.mk's ORGELPA variable.

-- >8 --
Subject: [PATCH] server.mk: Add orgguide to ELPA package

* mk/server.mk (ORGELPA): Include orgguide.

Reported-by: David Masterson <dsmasterson@outlook.com>
---
 mk/server.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mk/server.mk b/mk/server.mk
index 94818bb84..2c5294507 100644
--- a/mk/server.mk
+++ b/mk/server.mk
@@ -38,7 +38,7 @@ ORGFULL   = README COPYING lisp/ \
 		etc/ contrib/ doc/ testing/
 ORGFULL  := $(ORGFULL:%/=%/*)
 ORGELPA   = README_ELPA COPYING etc/ORG-NEWS lisp/ \
-		doc/dir doc/org doc/orgcard.pdf \
+		doc/dir doc/org doc/orgguide doc/orgcard.pdf \
 		etc/styles/ org-pkg.el
 ORGELPA  := $(ORGELPA:%/=%/*)
 ORGELPAPLUS := $(ORGELPA:org-pkg%=org-plus-contrib-pkg%)
-- 
2.24.0

Re: Bug: Orgguide missing in Org-9.3 package [9.3 (9.3-elpa @ /home/David/.emacs.d/elpa/org-9.3/)]

[Nicolas Goaziou]

Hello,

Kyle Meyer <kyle@kyleam.com> writes:

> Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Sorry, I don't have write access.  But this issue seems to be about the
> Org ELPA tarball, so I don't understand how it'd be related to the
> recent Org sync with the Emacs repo.

That's because I misread the bug report and though it was related to
Emacs master branch.

In any case, Org ELPA tarball and files merged with Emacs are two
different things. IOW, even if ELPA tarball contains the Org guide, it
is not sufficient for Emacs to ship it, too. So this also needs to be
fixed on the Emacs' side, AFAIU.

> Checking the tarball at <https://elpa.gnu.org/packages/org-9.3.tar> as
> well as some recent ones at <https://orgmode.org/elpa/>, I didn't spot
> orgguide in any of them.  And when I run `make elpa' from the Org repo,
> the tarball indeed seems to be missing the orgguide info file.  Assuming
> there's not a good reason that orgguide is omitted, I think fixing this
> is just a matter of adding orgguide to server.mk's ORGELPA variable.

I have no objection, but, per above, we should check if there's
something to do in the Emacs repository, too.

Regards,

-- 
Nicolas Goaziou

Re: Bug: Orgguide missing in Org-9.3 package [9.3 (9.3-elpa @ /home/David/.emacs.d/elpa/org-9.3/)]

[Kyle Meyer]

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

>> Sorry, I don't have write access.  But this issue seems to be about the
>> Org ELPA tarball, so I don't understand how it'd be related to the
>> recent Org sync with the Emacs repo.
>
> That's because I misread the bug report and though it was related to
> Emacs master branch.
>
> In any case, Org ELPA tarball and files merged with Emacs are two
> different things. IOW, even if ELPA tarball contains the Org guide, it
> is not sufficient for Emacs to ship it, too. So this also needs to be
> fixed on the Emacs' side, AFAIU.

Agreed, we should include orgguide.texi alongside org.tex in Emacs's
doc/misc/.  I've cc'd Bastien in case he'd like to adjust the latest
sync, though, given that orgguide has existed for a long time and has
never been included in the Emacs repo (AFAICS), I also don't see a
problem with waiting for the next sync until handling it.

>> Assuming there's not a good reason that orgguide is omitted, I think
>> fixing this is just a matter of adding orgguide to server.mk's
>> ORGELPA variable.
>
> I have no objection, but, per above, we should check if there's
> something to do in the Emacs repository, too.

OK, I'll apply that patch.

Thanks.