From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien <bzg@gnu.org>
Subject: Re: attachment: link type export to HTML invalid attach dir
Date: Mon, 17 Feb 2020 00:58:17 +0100
Message-ID: <87k14mjd9i.fsf@gnu.org>
References: <PR1PR02MB47323A141AE248937F2FA7D4DAFB0@PR1PR02MB4732.eurprd02.prod.outlook.com>
 <HE1PR02MB30336F9B783F84969FDC74C1DA310@HE1PR02MB3033.eurprd02.prod.outlook.com>
 <HE1PR02MB3033A78363C6CB71D1AFA929DA300@HE1PR02MB3033.eurprd02.prod.outlook.com>
 <87pnfhrob4.fsf@nicolasgoaziou.fr>
 <HE1PR02MB30339DA3A17FBE14F0F924AFDA300@HE1PR02MB3033.eurprd02.prod.outlook.com>
 <871rrvrw0b.fsf@nicolasgoaziou.fr>
 <HE1PR02MB3033EB926B8B582D176EB8E5DA330@HE1PR02MB3033.eurprd02.prod.outlook.com>
 <87muairkam.fsf@nicolasgoaziou.fr>
 <HE1PR02MB303324C053A518999533F379DA090@HE1PR02MB3033.eurprd02.prod.outlook.com>
 <87y2th0yc7.fsf@nicolasgoaziou.fr>
 <HE1PR02MB3033654FFD2F806D0B5EC83DDA1D0@HE1PR02MB3033.eurprd02.prod.outlook.com>
 <878sle1ng9.fsf@nicolasgoaziou.fr>
 <HE1PR02MB3033668D1D2CD40DB2C7E932DA1F0@HE1PR02MB3033.eurprd02.prod.outlook.com>
 <875zgausnb.fsf@nicolasgoaziou.fr>
 <HE1PR02MB3033AA077F9896011A161813DA1A0@HE1PR02MB3033.eurprd02.prod.outlook.com>
 <87o8u2tbhg.fsf@nicolasgoaziou.fr>
 <HE1PR02MB3033FD69FC2C3EC94BA5ECD8DA1A0@HE1PR02MB3033.eurprd02.prod.outlook.com>
 <87zhdlctsm.fsf@bzg.fr> <87a75lt7nc.fsf@nicolasgoaziou.fr>
 <87d0ag29kk.fsf@gnu.org> <87h7zrradl.fsf@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:58578)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <bzg@gnu.org>) id 1j3Tns-0002BB-1C
 for emacs-orgmode@gnu.org; Sun, 16 Feb 2020 18:58:24 -0500
In-Reply-To: <87h7zrradl.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of
 "Sat, 15 Feb 2020 19:08:54 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org
Sender: "Emacs-orgmode"
 <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: Gustav =?utf-8?Q?Wikstr=C3=B6m?= <gustav@whil.se>, "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>

Hi Nicolas,

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> This is the first part of the suggested changes. These do not touch
> attachment modifications, but rather improve the tooling in "ol.el".

Thanks for working on this--and Kyle for the careful review.

> `org-link-parameters' accepts a new property, :open, which is
> like :follow, but function installed there is called with a universal
> prefix argument.

I'm not sure why the distinction between :open and :follow is needed
in the context of the discussion for exporting attachments: is it
because attachment need to be "open", not just followed?

> Also, :export function is called with a fourth argument, the export info
> channel. I updated the export back-ends to handle the new signature, and
> provided a compatibility layers for link libraries in the wild, which
> may still use three arguments.
>
> There are two new tools: `org-link-open-as-file' and
> `org-export-link-as-file'. They can be used as helper functions for,
> respectively, :open and :export functions.

> WDYT?

LGTM, feel free to go ahead when you want.

Thanks,

-- 
 Bastien