From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien <bzg@gnu.org>
Subject: Re: Org agenda -- checking for invisible tasks after filtering...
Date: Tue, 18 Feb 2020 00:13:33 +0100
Message-ID: <87k14k959e.fsf@gnu.org>
References: <87bls9kayb.fsf@gmail.com> <87imknmpv3.fsf@gnu.org>
 <87v9o6c017.fsf@gmail.com> <87blpyqelj.fsf@gnu.org>
 <87r1ytb4ei.fsf@gmail.com> <87sgj9nm6q.fsf@gnu.org>
 <87lfp1aq7p.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:57703)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <bzg@gnu.org>) id 1j3pa3-0005wy-Tg
 for emacs-orgmode@gnu.org; Mon, 17 Feb 2020 18:13:36 -0500
In-Reply-To: <87lfp1aq7p.fsf@gmail.com> (Christian Schwarzgruber's message of
 "Mon, 17 Feb 2020 21:55:38 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org
Sender: "Emacs-orgmode"
 <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org>
To: Christian Schwarzgruber <c.schwarzgruber.cs@gmail.com>
Cc: emacs-orgmode@gnu.org

Hi Christian,

thanks for testing.

Christian Schwarzgruber <c.schwarzgruber.cs@gmail.com> writes:

> thanks for that change. But unfortunate this one doesn't work for the
> org-agenda-filter-by-* functions. However, it would work for all
> org-agenda-filter* functions, if the hook would be called at the end of
> `org-agenda-filter-apply`. But I can see what than would happen, the hook
> would be called several times when more filter types are set.

The added hook is not intrusive and useful, outside the needs related
to your patch to org-super-agenda.

Adding a hook to a function that is called many times is calling for
problems, I don't want to go that way.

> A other option would be the call the hook at the end of all the
> org-agenda-filter* functions, perhaps.

Not sure what you mean (patch welcome just to understand).  But again
I think we don't need more hooks.

Maybe you can explore using post-command-hook in org-super-agenda-mode
in a way that checks whether the last command was a filter command and
then act from there?  Just an idea, not sure it is correct.

Best,

-- 
 Bastien