emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bastien <bzg@gnu.org>
To: Christian Schwarzgruber <c.schwarzgruber.cs@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Org agenda -- checking for invisible tasks after filtering...
Date: Tue, 18 Feb 2020 00:13:33 +0100	[thread overview]
Message-ID: <87k14k959e.fsf@gnu.org> (raw)
In-Reply-To: <87lfp1aq7p.fsf@gmail.com> (Christian Schwarzgruber's message of "Mon, 17 Feb 2020 21:55:38 +0100")

Hi Christian,

thanks for testing.

Christian Schwarzgruber <c.schwarzgruber.cs@gmail.com> writes:

> thanks for that change. But unfortunate this one doesn't work for the
> org-agenda-filter-by-* functions. However, it would work for all
> org-agenda-filter* functions, if the hook would be called at the end of
> `org-agenda-filter-apply`. But I can see what than would happen, the hook
> would be called several times when more filter types are set.

The added hook is not intrusive and useful, outside the needs related
to your patch to org-super-agenda.

Adding a hook to a function that is called many times is calling for
problems, I don't want to go that way.

> A other option would be the call the hook at the end of all the
> org-agenda-filter* functions, perhaps.

Not sure what you mean (patch welcome just to understand).  But again
I think we don't need more hooks.

Maybe you can explore using post-command-hook in org-super-agenda-mode
in a way that checks whether the last command was a filter command and
then act from there?  Just an idea, not sure it is correct.

Best,

-- 
 Bastien

      reply	other threads:[~2020-02-17 23:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-15 12:52 Org agenda -- checking for invisible tasks after filtering Christian Schwarzgruber
2020-02-03 19:29 ` Bastien
2020-02-16 10:13   ` Christian Schwarzgruber
2020-02-16 23:47     ` Bastien
2020-02-17 15:49       ` Christian Schwarzgruber
2020-02-17 17:44         ` Bastien
2020-02-17 20:55           ` Christian Schwarzgruber
2020-02-17 23:13             ` Bastien [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k14k959e.fsf@gnu.org \
    --to=bzg@gnu.org \
    --cc=c.schwarzgruber.cs@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).