From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id YKJAISGpgl8QOgAA0tVLHw (envelope-from ) for ; Sun, 11 Oct 2020 06:41:37 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id SNkRHSGpgl9hMwAAbx9fmQ (envelope-from ) for ; Sun, 11 Oct 2020 06:41:37 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1320D940149 for ; Sun, 11 Oct 2020 06:41:35 +0000 (UTC) Received: from localhost ([::1]:50408 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kRV2z-0005el-5D for larch@yhetil.org; Sun, 11 Oct 2020 02:41:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59318) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kRV2a-0005eQ-5K for emacs-orgmode@gnu.org; Sun, 11 Oct 2020 02:41:08 -0400 Received: from pb-smtp20.pobox.com ([173.228.157.52]:61905) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kRV2U-00073T-OE for emacs-orgmode@gnu.org; Sun, 11 Oct 2020 02:41:07 -0400 Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id B8F0DE3AAD; Sun, 11 Oct 2020 02:41:00 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=sasl; bh=j4MAEkbONO5Eg/k6F9tBN/xVydQ=; b=OgDKt9 5oEMkuQhA9/Su6bPL8k8mJOTmjYGhmNWMlyqVA/jfAtk+MPJ+dIM8vPyh6a/qg3p VZo3D2EbZkNr4zJTVREnh6DGN/MEKd6Z0EVtnOxVD+LKxDnvj+JuAMy0GWOjHlGm mjJDiqyPcFShxeiiv80oPTeGC29mZhpoM3LBQ= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id B1991E3AAC; Sun, 11 Oct 2020 02:41:00 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kyleam.com; h=from:to:cc:subject:in-reply-to:references:date:message-id:mime-version:content-type; s=mesmtp; bh=phBrJYmWwXiZ9XycnqLxD2ZYhYWRngznHXN+gAXUJnk=; b=r1dFLedYd1ZSLJNX1fJ2INDN92WoX9+yyg8pwf/Ptj2GUccbQQGiCbeKR7Y13/AnT53zn99U9VxmsKm5EstFN/xmGKt6BMqbf4BAa8d2jFP6G1sLI4uuHxttN2ikHgQGnNeCzOpzaClIZFRMYYdTluVc70V/QJ+RUBG0zM/dfbE= Received: from localhost (unknown [45.33.91.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id 291B5E3AAA; Sun, 11 Oct 2020 02:40:58 -0400 (EDT) (envelope-from kyle@kyleam.com) From: Kyle Meyer To: Protesilaos Stavrou , Roman Rudakov Subject: Re: Bug: org-priority face has extra space at the end starting from version 9.4 [9.4 (9.4-elpaplus @ /home/rrudakov/.emacs.d/elpa/org-plus-contrib-20200914/)] In-Reply-To: <87o8lit5vk.fsf@protesilaos.com> References: <87r1r2kh77.fsf@pm.me> <87o8m6aysz.fsf@protesilaos.com> <87d025ypu1.fsf@pm.me> <87o8lit5vk.fsf@protesilaos.com> Date: Sun, 11 Oct 2020 02:40:56 -0400 Message-ID: <87k0vx8dtz.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: B8639632-0B8C-11EB-ADD1-E43E2BB96649-24757444!pb-smtp20.pobox.com Received-SPF: pass client-ip=173.228.157.52; envelope-from=kyle@kyleam.com; helo=pb-smtp20.pobox.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/11 02:41:00 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ilja Kocken , emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=pobox.com header.s=sasl header.b=OgDKt9 5; dkim=pass header.d=kyleam.com header.s=mesmtp header.b=r1dFLedY; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: 0.29 X-TUID: YH7Cf6gCAoFK Protesilaos Stavrou writes: > On 2020-09-29, 08:00 +0000, Roman Rudakov wrote: > >> "Protesilaos Stavrou" writes: >> >>> Roman Rudakov [2020-09-15, 18:50 +0000]: >>> >>>> I use theme which draw boxes around priority cookie. Before updating to >>>> version 9.4 box was rendered just around square brackets, but since >>>> version 9.4 it has additional space at the end. >>>> >>>> I think it's related to the fact that org-priority face definition used >>>> to use separate regex which didn't include space, and now it uses >>>> variable org-priority-regexp which does include additional space >>>> character. Thanks, all, for the excellent report and debugging. >> I think proper value for `org-priority-regex` should be >> ".*?\\(\\[#\\([A-Z0-9]+\\)\\]\\) ?", extra space should be moved out of >> the brackets, It won't break anything and face definition will be >> correct. > > This is to confirm that I and Ilja (in Cc) get the desired behaviour by > evaluating the suggested regexp. I'm wary of changing the regexp. Although the docstring does suggest the space shouldn't be a part of the first group, the group has included the space since org-priority-regex was introduced way back in 2008. And making the suggested change results in a failing test (test-org/entry-put). So at this point, I'd lean towards adjusting the docstring. I've applied a different fix for the regression (b1de0c8e4).