From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id LzTFLlW5m2AXTgEAgWs5BA (envelope-from ) for ; Wed, 12 May 2021 13:17:41 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id OOK7KVW5m2DNFQAAbx9fmQ (envelope-from ) for ; Wed, 12 May 2021 11:17:41 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2B7042FB1F for ; Wed, 12 May 2021 13:17:41 +0200 (CEST) Received: from localhost ([::1]:55632 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgmrz-0006mU-9N for larch@yhetil.org; Wed, 12 May 2021 07:17:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43338) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgmqM-0006hA-5E for emacs-orgmode@gnu.org; Wed, 12 May 2021 07:15:58 -0400 Received: from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a]:34555) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lgmqK-0001vF-HW for emacs-orgmode@gnu.org; Wed, 12 May 2021 07:15:57 -0400 Received: by mail-pj1-x102a.google.com with SMTP id na14-20020a17090b4c0eb029015cbbd5f028so56380pjb.1 for ; Wed, 12 May 2021 04:15:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:message-id :date:mime-version:content-transfer-encoding; bh=0vUMNlQmECdRjEWJ//2DJUWYuWo3YKC17EOzJFhDwoE=; b=Z9EuSRhzbGZe6CW7eZ1TOphxOauKVaTCm36ZEI1xWjZfiqy1Vwv/zNSlFl4iw0QfPg LWwzLuBMeErcAscJY3zkyZDgzzs26uKIQNSJo6b+V1lOYQuZOifWHe1tn+6uXT+OH8oC YJOR4wyYtmbcKUgVYkIJerawK0QoSHTTsG1kexYjt+jfI2CwSiLGuCdkGPyaevOe76p+ 4Z6Zt8cXoHQvXMlPB8EcRDbNgArLwobAA2CZkJ/rTEPvLxzVs9eI1R/Vc2uNnNafSNuW vUNI6wA4zpG39MDcNfGO00Z34U6LFiAB2wau99wel47aorCVMCsaIK6u8JFLbeU1ft1I u3Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:message-id:date:mime-version:content-transfer-encoding; bh=0vUMNlQmECdRjEWJ//2DJUWYuWo3YKC17EOzJFhDwoE=; b=hGfI1F/l2zm+44It9RLdLoaJB9SYBetYpbROqW6/giPTRowF6OSFb4L6uU/F1v7Vn6 3Suyqq/n7vVmw4riWpBfR6sWa3RLnRUnbUWDxtzkSFsWGwswQwzxtWQomLrqQGPC78UB o99hpZxzpQwvsq2eRMwf8CkURXxUhXb71xmxpWutOiq0+DTpddDfcrYNinQx046DLwmU J8VtwD63xDjsPNL9wN7LL5n67jTChUwP/WZYvScO3xZJ88T5BIbewarTO9auSQ6g4m0s cFY3f6+k1n5Ldzn8yHsWLG8iMklwaGlODBGEtnrEpgOIbCHEbxcdUAIn5NVUxcmPsAHR hKHw== X-Gm-Message-State: AOAM53345144DpZhw81MYVgG343+vethAjh9db+w78p5zc4iIc9s+Bm6 ZjTITFH0/1GyhTRLRdsSi+U= X-Google-Smtp-Source: ABdhPJyaRXQ/LziRaSDV0/X0c6iPrQmR3n+zKvwZTbxqiRUEFXTW55b8yI0jB7OTCCi34m+x5UyG8w== X-Received: by 2002:a17:903:208b:b029:ed:74ad:4c15 with SMTP id d11-20020a170903208bb02900ed74ad4c15mr34792121plc.6.1620818155191; Wed, 12 May 2021 04:15:55 -0700 (PDT) Received: from localhost (180-150-91-8.b4965b.per.nbn.aussiebb.net. [180.150.91.8]) by smtp.gmail.com with ESMTPSA id t19sm4128222pfg.70.2021.05.12.04.15.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 May 2021 04:15:54 -0700 (PDT) References: <87pmzf4bd0.fsf@gmail.com> <87pmye51a3.fsf@gmail.com> <87zgxcgaba.fsf@gmail.com> <878s4wtrzx.fsf@gmail.com> User-agent: mu4e 1.4.15; emacs 28.0.50 From: Timothy To: Tom Gillespie Subject: Re: [PATCH] Fontification for inline src blocks In-reply-to: <878s4wtrzx.fsf@gmail.com> Message-ID: <87k0o419uh.fsf@gmail.com> Date: Wed, 12 May 2021 19:15:51 +0800 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::102a; envelope-from=tecosaur@gmail.com; helo=mail-pj1-x102a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: org-mode-email Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1620818261; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=0vUMNlQmECdRjEWJ//2DJUWYuWo3YKC17EOzJFhDwoE=; b=GR12J93pDp6kkQemQXza6c4DAW6ZjGMSC0XgDsepozyzOvBTej+hvkgWc0UHTgek/uTUrk TdIvaCzJgqQ9zYWRoyX0MetYvC+Q4AAZBBbDEHAy+UWoD2Kh/iQpY4e1EL00b6vTH4EBKR NzZ1TJ+w2wIkrvunNBu+lyPV7hpvGAGdWBBlBNoAtPX2T3dZQm5RM1b0fPV+lOs5ZvdITO lLIvy29DF8kyStcvQ0h1zzXAARY809Jqn1IPIZe8coe4CspiedQUkKMSth4bm3BLIyEw8Q vFRYKWuhn3AOINYE8hb1DrlxDSQUtJfRmZWgkA3liL+Ybn5thXZCiRDjBWkHfg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1620818261; a=rsa-sha256; cv=none; b=KpsA3FXgCuK/I5bJUlMnumpL9AKlDzNRw3XNf4U+zU2UsK4/MKenyXS3CxIEBzfxtL1Xwh z9LiQCQii8lNYMhCzhSn3d61lm6T1AUEX2YVd9S+F6HduuLm0XSmaBSf+ir+ciPmu3wj5/ TtlbRCpSdNbDquM2aaGfIdbjGiWVo5lgBH8R499lTQi2x91MWnmW5K0f6GfsaD5f79Hr2b mr5vZZ3r1SqCATsnxPRf78ti9GAKewMQR8I/I/ZcJ/CH7dI+iDPVzK2JrNJpTDvrISwfjt oYl1TLvFRmU2sqjHuMq0vzpQE2Wph882pRoOWF8X/KWiEBlQbp/h8yA8jaL0zg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=Z9EuSRhz; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -3.15 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=Z9EuSRhz; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 2B7042FB1F X-Spam-Score: -3.15 X-Migadu-Scanner: scn0.migadu.com X-TUID: vmQTYHfWxdqn If anyone else is interested in this, it would be great to get your thoughts. I'd also appreciate it if a core maintainer might be able to find the time to review the patch and let me know if it looks good. Thanks, Timothy. -- > Tom Gillespie writes: > >> 1. I think there needs to be a function to toggle >> org-inline-src-prettify-results as there is e.g. for hyperlinks. I was >> quite confused by the prettified results. > > Added org-toggle-inline-results-display. > >> 3. I'm not sure about the default choice for prettified delimiters. I >> see there is already a way to customize the delimiters by providing a >> cons. I think a default value of '("" . "") might be a better choice >> since =E2=9F=A8 and =E2=9F=A9 being hardcoded seems like it introduces c= ompletely >> alien characters. Going with empty strings also seems consistent with >> the behavior for hyperlinks. > > Changed to your suggestion. > > Awaiting others' thoughts on 2. and 5.