From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id KDZ7JnacDWEN5AAAgWs5BA (envelope-from ) for ; Fri, 06 Aug 2021 22:32:54 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id YMThIXacDWHbSgAAbx9fmQ (envelope-from ) for ; Fri, 06 Aug 2021 20:32:54 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DA023AFF4 for ; Fri, 6 Aug 2021 22:32:52 +0200 (CEST) Received: from localhost ([::1]:41276 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mC6WR-0002iG-4a for larch@yhetil.org; Fri, 06 Aug 2021 16:32:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33746) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mC6W4-0002i2-64 for emacs-orgmode@gnu.org; Fri, 06 Aug 2021 16:32:28 -0400 Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]:46780) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mC6W2-0001uf-IM for emacs-orgmode@gnu.org; Fri, 06 Aug 2021 16:32:27 -0400 Received: by mail-pl1-x62b.google.com with SMTP id k2so8586506plk.13 for ; Fri, 06 Aug 2021 13:32:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:references:user-agent:in-reply-to :message-id:mime-version; bh=D9g/ZZocErc8pRv82qMmEvQuQuUt6sf7+2KR+iqys4Q=; b=iAvLPeaWmbhpl00zv6ZJiTn/Awc/XgYnZgyuIFa1fFI0p9rcR2J9P58EUQujMCAjRf HtoO0j/V1l8DqoL9dRZy/gBzr5qUtTDC0LA1lISycVd+PHWKEcRNx+haHXkBSAPJnhzs GNe7WQIz0gG7F1KnROfh8QLgrTgJj3DLcfs72c+IoM5AFkrOBHmaxKYQ0ZUw/DEMHXsp CqivX9OCAfxByEqdNvCSd2VolH/66wnU/NM91nGxbR/9X7AmkCkifVMtSgLm5vdDWVe7 cDUEgsbVWGQD3U2seUvSmklyIPv+P5IKwpjsGKrip6oAZevPIMwhxjGwzkDorvGqD3zZ 8/6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:references:user-agent :in-reply-to:message-id:mime-version; bh=D9g/ZZocErc8pRv82qMmEvQuQuUt6sf7+2KR+iqys4Q=; b=plryDp4lxyNtlBsN2LAyEHSTpaiieLp3jo4cqAbKa2WgtyFrkOC8hVyZrwFq8yu5uC +2/rnkU83gu2qr1h5wPN1W18jKv3d0hpGIzUkCke/1BxliLFQc4aKQ9RGrHSIMi81jXb nhDBAy8xubz9ldl+DZnupT1/lGVZm9BnsvSrUuYdjazmUAjCDuMCBxT96DSDD/0gS4Ry 2UC5Sj/LXTVQVeZrnIjf9yyDzk3RaRFLISbVAzTJ1xkgnGZgfDsz2ax1nnaXcweHJnA9 GRcJlLRi8RPgH6UnmWmOmmo+WX2LyYOnO6/lLVGkt7DTK2xbTfEbR2NPVw7zpELG4Fma TS5Q== X-Gm-Message-State: AOAM532WF67XUjE1kQgXijIiKpAYxSwEt4CTNDOCV/ynhV5p3UowHIQY KFW+rTzRYUW7Mf3j5PbBrks= X-Google-Smtp-Source: ABdhPJznXjZIsw1jco3+go0zRQHSJcUTPomWxt8hPUS08arms4+7J47ZPwHx1yySpo+qU0CC5IGcgQ== X-Received: by 2002:a17:90a:c305:: with SMTP id g5mr1650252pjt.79.1628281944467; Fri, 06 Aug 2021 13:32:24 -0700 (PDT) Received: from localhost (180-150-91-8.b4965b.per.nbn.aussiebb.net. [180.150.91.8]) by smtp.gmail.com with ESMTPSA id a12sm11802123pfg.120.2021.08.06.13.32.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Aug 2021 13:32:24 -0700 (PDT) From: Timothy To: Maxim Nikulin Subject: Re: [PATCH] org-agenda.el: Avoid dependency on subr-x Date: Sat, 07 Aug 2021 04:30:49 +0800 References: <09a29a60-b254-9207-0d44-eaf0b1ba964b@ya.ru> <87mtpwhwrj.fsf@ucc.asn.au> User-agent: mu4e 1.4.15; emacs 28.0.50 In-reply-to: Message-ID: <87k0kyiaaz.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2607:f8b0:4864:20::62b; envelope-from=tecosaur@gmail.com; helo=mail-pl1-x62b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1628281973; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=D9g/ZZocErc8pRv82qMmEvQuQuUt6sf7+2KR+iqys4Q=; b=ZBHmr+aGfANaRxhVOeYbWnZqjBgFM4g6jrpj5dI8kEDgqsEYHb+uIujH1nh1a0Jfmu6vBG giBkW8WgxF72vtOUqVDzApMq1izorYUFBG1ZvXPrYDX97XjK0TiVnC8JHq8/WmQinl2SnI z/YfyL1UELNFjSwrOUoKTP5M5XvSs0cFnwU/8NBg1bts+7Zf0buCjIPSBxiN3VZfF6TyJI jsVvdmu/9SlCbeync+rcLBYIdgp86HDzZttCgnk9vvwvG7AXt4NKutcakYWQ6zETNOFMU0 +YtWSVBmjM40gYUXOXBh9sjIAOxx/NlXoLD6dFvd+MC9iSG1uCrdx52lxIqEvw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1628281973; a=rsa-sha256; cv=none; b=REtaUniIMV8o10Chh2a0ns21MNvboA1WRh7SnhQCEkvOOpAi1UukvaEqzp0c/5y1xR/4m7 TxLBHTt/30lufNAWuOSjEHtbw0uZ0nDYYVQ0QfwTdcPNn2uSLRIQPv/ufDM9JFcyUQ672t +NYNlDCNWFcklPnRMkFTSNkjFjoWWv0sEZut5iyEb0ol0drOj1NnDzVrZ0ot6IvUSh0Opl TJx3F/8lTO94fXC8sD12zCi9SLA3JOBNjVIdre6l2GCTRYdBOkWQNL1Z/QdHyiq1yt2QUt olHJHWQSHSI81LxQXm0DAnYDdNa4DPbNBgIKggvYbqizbO27bZaVIpx05Wx2Bg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=iAvLPeaW; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -0.62 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=iAvLPeaW; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: DA023AFF4 X-Spam-Score: -0.62 X-Migadu-Scanner: scn1.migadu.com X-TUID: 2XiMk/cEhiSy --=-=-= Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Maxim, > Timothy, I have seen that discussion. For me it does not matter in which = way > org-agenda.el will be fixed: by adding (require =E2=80=99subr-x) or by us= ing string=3D > instead of string-empty-p. Both variants work with Emacs-26.3. The point = is that > =E2=80=9Cmake single=E2=80=9D should work without warnings and in the cas= e of mixed install > users should not get confusing errors that resemble real issues. > > The only reason why I suggested namely to avoid string-empty-p is that > compatibility with Emacs-24.3 is still declared in Org sources. Ah, cool. I took your original email to indicate that this change was solel= y for Emacs 24.3 comparability, but I now see you simply used that as a reason to choose between two different fixes. All the best, Timothy --=-=-=--