From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 4AVbLavOHWPJ0AAAbAwnHQ (envelope-from ) for ; Sun, 11 Sep 2022 14:03:55 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id aK1sLavOHWNSEQAA9RJhRA (envelope-from ) for ; Sun, 11 Sep 2022 14:03:55 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6C51EB7F5 for ; Sun, 11 Sep 2022 14:03:55 +0200 (CEST) Received: from localhost ([::1]:45678 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oXLgo-0000cw-41 for larch@yhetil.org; Sun, 11 Sep 2022 08:03:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55852) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oXLf4-0000Yp-JN for emacs-orgmode@gnu.org; Sun, 11 Sep 2022 08:02:07 -0400 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]:38884) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oXLf2-0007fm-6i for emacs-orgmode@gnu.org; Sun, 11 Sep 2022 08:02:05 -0400 Received: by mail-pf1-x432.google.com with SMTP id y127so6046909pfy.5 for ; Sun, 11 Sep 2022 05:02:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date; bh=QUTSR/io1oxRcMQIcyfEFon2WqASXXAD9T+JzJlAcwM=; b=M3G0J9WnYWEJS0EBRG0rqZBjmce17AhSO8s/m3o8RS9u6qmZ7KwzBme7fFsv+MwN15 g/yrZL8Uvkhm8gKL+iMIvEjPpVPRmhVnWJZiweknPWlr1AZJpmFGIR3f+xs30ZW+Ch10 y9osu3uosTT4nzCjN8GS0vzK9ybuntrzDRasb04b0Hpi9/xJ0MEfYlVg6hhBFD8G/x/0 7s6d32fGclIbVhJUSGI62MxltlvY4gtTsClrsb89bYEmUud7VGiCbwIw1ZmBdPQZMq3d GZAR0j2l1qbZhzZfakGkKU3MlbMzTcS3fXUq7GhYunyPySrOT79hNZV7sU7k9j1v4HwE cNCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date; bh=QUTSR/io1oxRcMQIcyfEFon2WqASXXAD9T+JzJlAcwM=; b=LI/G7XAUOPQXQ/zP6dyvW00AADaX6EFgWLFbJkUnShJ4IwQeaGP3YUvvIS7PfpKVn1 OfLiwYSRgdTz/2XfSZk0hLiLdSbJPDeeKk3V1oZ4xPeTmE55AgLM5uACOU9m9fjYWL20 eY4URloqWD/w0ch1dS+H/nd4UuVKgLZN0yYu+gWO1A7GKgmEVYIj8AUuVhs2Mn5gcAIj 1PCSdpqeBGiWiJx84Wjw0L6TBBn1xpGWx+2fJLim53hmzJodQ61TldhkcFKX5t1mX78C lDfsuC/oVlevdYMg0Xx6KjPnXb7ezCG/qYmkYAYicgV5Q9qwJd1zVwpXcqHLwVe+kXVU cRxQ== X-Gm-Message-State: ACgBeo1ymbaDN+Ij9UhYdEQbzMQ7vHp/HMHi2+62EyNwMnCH04v7xY/U CY12I0T7emaFUzz3I36y7ME= X-Google-Smtp-Source: AA6agR7f43Yn3tvctGIF/GUM4t6+F7zN/X3xCxs4qXxb8/1OrWAw31LfwM4OUPI4C0RZLeeK0Pdomg== X-Received: by 2002:a05:6a00:1c69:b0:53e:a212:2b0b with SMTP id s41-20020a056a001c6900b0053ea2122b0bmr18763536pfw.30.1662897722673; Sun, 11 Sep 2022 05:02:02 -0700 (PDT) Received: from localhost ([2409:8a70:2bc:c850:8ec6:81ff:fe70:339d]) by smtp.gmail.com with ESMTPSA id q8-20020a170902dac800b0017832c8cc85sm73522plx.292.2022.09.11.05.02.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 05:02:02 -0700 (PDT) From: Ihor Radchenko To: Tim Cross Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] ol.el: Restore complete by description for insert link In-Reply-To: <86r10jdnzv.fsf@gmail.com> References: <86r10jdnzv.fsf@gmail.com> Date: Sun, 11 Sep 2022 20:02:45 +0800 Message-ID: <87k06aw23e.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::432; envelope-from=yantar92@gmail.com; helo=mail-pf1-x432.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1662897835; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=QUTSR/io1oxRcMQIcyfEFon2WqASXXAD9T+JzJlAcwM=; b=LelDwymcHVJTxatxswie7D/vRySAGnbWWnoxXHrDmHm07LFr4eg077xHPCmSPwFUfip+LH vAuCre38Eb9GY8FScfSk0lqnVzYN1lw7+RgwRR1QwdrXN/SsZk0vK/qIXv7wYyp+OEfNxv Kl/JQWONSyEJSLnMVr1bqLjl8zGs6kYny8sAfpGB/rI8RRed32zT/3PwmpRWTEjD/XJdN5 KybksxuvpnpWHTap61sbtez/350xd1yET8jHVesQW+FBIyq8ivsom0tV9T3fxvWcUmZOMK 3Ctu/6WDOtaklD5n+8fEU0ZvNQVjnrInvxndviHcIqmJ2f1CluoQJ7hss4G70Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1662897835; a=rsa-sha256; cv=none; b=ZL1KKC3J7Ddfb0uhWtHUNZNYZSELSxY591A9cWwMSbTHxiHcoRzlo3Q9cys4ZM7+vANews TpAukPRoVr2yYu7L1gmiI0n56DAZ+UsX90HjjnaSlirslfgKi1uJbNTxBifxV2uTgY6/5d lSzrQeb8td+Adegpds0bL3TxVvZV+TY4YMFUrgpoeXdeiQND9g1Av5BVQQSWS6pGx3w7V9 J6tcvzC8GwVToqJh6dvRI/VqMAS9dziBwNG3H8vhZIYllaSA4sbSuiaZb4h3JceGVA69ZM 11L8aPIJH9biEX6OaVIFCBovjDDw4I3AwAfhbi+auH/63XHGr7daycnEqS6CIA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=M3G0J9Wn; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.30 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=M3G0J9Wn; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 6C51EB7F5 X-Spam-Score: -3.30 X-Migadu-Scanner: scn1.migadu.com X-TUID: WwpMUHH+790i Tim Cross writes: > You don't appear to be getting a lot of feedback on this. However, I > think it is important work your doing. I suspect the lack of feedback is > partially due to Emacs' completion infrastructure being somewhat > confusing, combined with references to ido, which I suspect is one of > the less popular completion frameworks these days. . Not necessarily Emacs infrastructure. Org completion functions are fairly confusing as well, which makes it difficult to provide constructive feedback. We should really work towards (1) documenting the expected features in Org completion functions; (2) unifying and de-duplicating completion code across Org, like in https://orgmode.org/list/87zgisvuu5.fsf@localhost > My take on this, which might be completely wrong, is that org-mode > should not cater for or support any specific completion > framework. Things like ido, icomplete, fido, vertico, corfu, et. al. are > something which should be supported in a generic and abstract manner > i.e. we just provide minimal necessary code to generate the candidates > these systems use. From your description, I think this is what your > doing. Perhaps the requirements might become clearer if you also tried > other completion frameworks, like fido, icomplete and vertico. I'd say that we may still do it. At least, for the most common completion frameworks. However, we should do everything to reduce the maintenance overheads of such support. If some non-standard completion framework offer extra functionality compared to built-in, we can provide Org's framework that extends completion-read to support the extra functionality. What I have in mind is something like (org-completing-read normal-args extra-args) with extra-args only playing out when more featureful completion framework is active. However, it is critical not to require the normal Org code to account for non-standard frameworks. All the frameword-specific handling should be done in a separate localized function/library. Feel free to refute. -- Ihor Radchenko, Org mode contributor, Learn more about Org mode at https://orgmode.org/. Support Org development at https://liberapay.com/org-mode, or support my work at https://liberapay.com/yantar92